Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Tom Talpey
On 4/24/2015 8:23 AM, Michael Wang wrote: Add new callback query_transport() and implement for each HW. Mapping List: node-type link-layer old-transport new-transport ... mlx4IB_CA IB/ETH IB IB/IBOE mlx5IB_CA

[PATCH v6 21/26] IB/Verbs: Use management helper cap_ib_mcast()

2015-04-24 Thread Michael Wang
Introduce helper cap_ib_mcast() to help us check if the port of an IB device support Infiniband Multicast. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

[PATCH v6 18/26] IB/Verbs: Use management helper cap_ib_cm()

2015-04-24 Thread Michael Wang
Introduce helper cap_ib_cm() to help us check if the port of an IB device support Infiniband Communication Manager. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

[PATCH v6 22/26] IB/Verbs: Use management helper cap_read_multi_sge()

2015-04-24 Thread Michael Wang
Introduce helper cap_read_multi_sge() to help us check if the port of an IB device support RDMA Read Multiple Scatter-Gather Entries. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

[PATCH v6 17/26] IB/Verbs: Use management helper cap_ib_smi()

2015-04-24 Thread Michael Wang
Introduce helper cap_ib_smi() to help us check if the port of an IB device support Infiniband Subnet Management Interface. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc:

[PATCH v6 23/26] IB/Verbs: Use management helper cap_af_ib()

2015-04-24 Thread Michael Wang
Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

[PATCH v6 20/26] IB/Verbs: Use management helper cap_ib_sa()

2015-04-24 Thread Michael Wang
Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administration. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

[PATCH v6 24/26] IB/Verbs: Use management helper cap_eth_ah()

2015-04-24 Thread Michael Wang
Introduce helper cap_eth_ah() to help us check if the port of an IB device support Ethernet Address Handler. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

[PATCH v6 14/26] IB/Verbs: Reform cma_acquire_dev()

2015-04-24 Thread Michael Wang
Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

Re: [PATCH v6 00/26] IB/Verbs: IB Management Helpers

2015-04-24 Thread Michael Wang
Add missing Cc: Devesh Sharma devesh.sha...@emulex.com Liran Liss lir...@mellanox.com Dave Goodell dgood...@cisco.com Regards, Michael Wang On 04/24/2015 02:23 PM, Michael Wang wrote: Since v5: * Thanks to Ira, Devesh for the review and testing :-) * Thanks for the comments from Steve,

[PATCH v6 26/26] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-24 Thread Michael Wang
We have get rid of all the scene using legacy rdma_node_get_transport(), now clean it up. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com

[PATCH v6 06/26] IB/Verbs: Reform IB-core multicast

2015-04-24 Thread Michael Wang
Use raw management helpers to reform IB-core multicast. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com

[PATCH v6 02/26] IB/Verbs: Implement raw management helpers

2015-04-24 Thread Michael Wang
Add raw helpers: rdma_tech_ib rdma_tech_iboe rdma_tech_iwarp rdma_ib_or_iboe (transition, clean up later) To help us detect which technology the port supported. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

[PATCH v6 00/26] IB/Verbs: IB Management Helpers

2015-04-24 Thread Michael Wang
Since v5: * Thanks to Ira, Devesh for the review and testing :-) * Thanks for the comments from Steve, Tom, Jason, Hal, Devesh, Ira, Liran, Jason, Dave :-) Please remind me if anything missed :-P * Trivial fix for 4# * Drop the reform on acquiring link-layer in 9# * Drop cap_ipoib()

[PATCH v6 19/26] IB/Verbs: Use management helper cap_iw_cm()

2015-04-24 Thread Michael Wang
Introduce helper cap_iw_cm() to help us check if the port of an IB device support IWARP Communication Manager. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford

[PATCH v6 05/26] IB/Verbs: Reform IB-core sa_query

2015-04-24 Thread Michael Wang
Use raw management helpers to reform IB-core sa_query. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com

[PATCH v6 07/26] IB/Verbs: Reform IB-ulp ipoib

2015-04-24 Thread Michael Wang
Use raw management helpers to reform IB-ulp ipoib. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc:

[PATCH v6 11/26] IB/Verbs: Reform route related part in IB-core cma

2015-04-24 Thread Michael Wang
Use raw management helpers to reform route related part in IB-core cma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v6 15/26] IB/Verbs: Reform rest part in IB-core cma

2015-04-24 Thread Michael Wang
Use raw management helpers to reform rest part in IB-core cma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v6 16/26] IB/Verbs: Use management helper cap_ib_mad()

2015-04-24 Thread Michael Wang
Introduce helper cap_ib_mad() to help us check if the port of an IB device support Infiniband Management Datagrams. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

[PATCH v6 08/26] IB/Verbs: Reform IB-ulp xprtrdma

2015-04-24 Thread Michael Wang
Use raw management helpers to reform IB-ulp xprtrdma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc:

[PATCH v6 04/26] IB/Verbs: Reform IB-core cm

2015-04-24 Thread Michael Wang
Use raw management helpers to reform IB-core cm. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny ira.we...@intel.com Cc: Sean

[PATCH v6 25/26] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-24 Thread Michael Wang
We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

[PATCH v6 12/26] IB/Verbs: Reform mcast related part in IB-core cma

2015-04-24 Thread Michael Wang
Use raw management helpers to reform mcast related part in IB-core cma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug Ledford dledf...@redhat.com Cc: Ira Weiny

[PATCH v6 13/26] IB/Verbs: Reserve legacy transport type in 'dev_addr'

2015-04-24 Thread Michael Wang
Reserve the legacy transport type for the 'transport' member of 'struct rdma_dev_addr' until we make sure this is no longer needed. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

RE: [PATCH v6 02/26] IB/Verbs: Implement raw management helpers

2015-04-24 Thread Liran Liss
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- Add raw helpers: rdma_tech_ib rdma_tech_iboe rdma_tech_iwarp rdma_ib_or_iboe (transition, clean up later) To help us detect which technology the port supported. Replace rdma_tech_* with rdma_protocol_*.

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Michael Wang
On 04/24/2015 04:29 PM, Tom Talpey wrote: On 4/24/2015 8:23 AM, Michael Wang wrote: [snip] +static enum rdma_transport_type +mlx5_ib_query_transport(struct ib_device *device, u8 port_num) +{ +return RDMA_TRANSPORT_IB; +} + Just noticed that mlx5 is not being coded as RoCE-capable

RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-24 Thread Liran Liss
From: Hefty, Sean [mailto:sean.he...@intel.com] [snip] So, I think that our old-transport below is just fine. No need to change it (and you aren't, since it is currently implemented as a function). I think there is a need to change this. Encoding the transport into the node

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Doug Ledford
On Fri, 2015-04-24 at 10:46 -0400, Tom Talpey wrote: On 4/24/2015 10:35 AM, Michael Wang wrote: On 04/24/2015 04:29 PM, Tom Talpey wrote: On 4/24/2015 8:23 AM, Michael Wang wrote: [snip] +static enum rdma_transport_type +mlx5_ib_query_transport(struct ib_device *device, u8 port_num)

RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-24 Thread Liran Liss
From: Michael Wang [mailto:yun.w...@profitbricks.com] [snip] Depends on who is we. For ULPs, you are probably right. However, core services (e.g., mad management, CM, SA) do care about various details. In some cases, where it doesn't matter, this code will use management helpers.

Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-24 Thread Michael Wang
On 04/24/2015 04:44 PM, Liran Liss wrote: From: Michael Wang [mailto:yun.w...@profitbricks.com] [snip] [snip] We don't want to stop code branches that are not abstractions but rather depend on the specific technology! There is no generic iWARP CM - only one. There is no generic

Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-24 Thread Jason Gunthorpe
On Fri, Apr 24, 2015 at 03:00:15PM +, Liran Liss wrote: Currently, the only code in the kernel that has an SMI interface is IB. When OPA is introduced, add the proper helper. We already have tests checking for SMI is supported so QP0 can be created, this is to support ROCEE All I am

Re: [PATCH v6 02/26] IB/Verbs: Implement raw management helpers

2015-04-24 Thread Jason Gunthorpe
On Fri, Apr 24, 2015 at 03:15:54PM +, Liran Liss wrote: From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- +static inline int rdma_tech_iboe(struct ib_device *device, u8 port_num) +{ + return device-query_transport(device, port_num) + ==

Re: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Tom Talpey
On 4/24/2015 10:35 AM, Michael Wang wrote: On 04/24/2015 04:29 PM, Tom Talpey wrote: On 4/24/2015 8:23 AM, Michael Wang wrote: [snip] +static enum rdma_transport_type +mlx5_ib_query_transport(struct ib_device *device, u8 port_num) +{ +return RDMA_TRANSPORT_IB; +} + Just noticed that

RE: [PATCH v6 01/26] IB/Verbs: Implement new callback query_transport()

2015-04-24 Thread Liran Liss
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- [snip] a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 65994a1..d54f91e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -75,10 +75,13 @@ enum rdma_node_type { }; enum rdma_transport_type { +