Re: [PATCH 08/11] IB/cma: Add net_dev and private data checks to RDMA CM

2015-06-17 Thread Jason Gunthorpe
On Tue, Jun 16, 2015 at 08:26:26AM +0300, Haggai Eran wrote: On 15/06/2015 20:08, Jason Gunthorpe wrote: On Mon, Jun 15, 2015 at 11:47:13AM +0300, Haggai Eran wrote: Instead of relying on a the ib_cm module to check an incoming CM request's private data header, add these checks to the RDMA

RE: [PATCH 06/41] IB/hfi1: add char device instantiation code

2015-06-17 Thread Marciniszyn, Mike
Do you have a link to this comment? I'm missing a bunch of messages from this thread and can't find anything from Al in the logs. This commit appeared in qib and it did not appear on linux-rdma. I never saw it until it appeared. I emailed on list to Al in

RE: [PATCH v2 01/49] IB/core: Add OPA Port header definitions

2015-06-17 Thread Marciniszyn, Mike
include/rdma/opa_port_info.h | 433 This matches the current code structure, but is this the best location for this file? Do you have a suggestion? Mike

RE: [PATCH v2 47/49] IB/hfi1: add multicast routines

2015-06-17 Thread Marciniszyn, Mike
Ummm... This looks eerily similar to qib_verbs_mcast.c. Sed job on the file? Is there any way to get a description as to what the differences are between qib and hfi? We are working on what can be said on OPA and the hardware. We chose to impact qib as little as possible with this driver

Re: [PATCH v2 01/49] IB/core: Add OPA Port header definitions

2015-06-17 Thread Hal Rosenstock
On 6/17/2015 8:08 AM, Marciniszyn, Mike wrote: include/rdma/opa_port_info.h | 433 This matches the current code structure, but is this the best location for this file? Do you have a suggestion? Couldn't it be a header in the hfi1 driver directory ? Isn't it OPA specific ? -- Hal

[PATCH v3 47/49] IB/hfi1: add multicast routines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 45/49] IB/hfi1: add PSM sdma hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 37/49] IB/hfi1: add sdma header file

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 40/49] IB/hfi1: add tracepoint debug routines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 46/49] IB/hfi1: add general verbs handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 38/49] IB/hfi1: add SRQ handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 43/49] IB/hfi1: add UD QP handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 34/49] IB/hfi1: add RC QP handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 36/49] IB/hfi1: add sdma routines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 42/49] IB/hfi1: add UC QP handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 39/49] IB/hfi1: add sysfs routines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 41/49] IB/hfi1: add QSFP twsi routines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 35/49] IB/hfi1: add routines for RC/UC

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 44/49] IB/hfi1: add low level page locking

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 49/49] IB/core: Add opa driver to kbuild

2015-06-17 Thread Mike Marciniszyn
From: Jubin John jubin.j...@intel.com Signed-off-by: Jubin John jubin.j...@intel.com Signed-off-by: Mike Marciniszyn mike.marcinis...@intel.com --- drivers/infiniband/Kconfig |1 drivers/infiniband/hw/Makefile |1 drivers/infiniband/hw/hfi1/sysfs.c | 131

[PATCH v3 48/49] IB/hfi1: add driver make/config files

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 06/49] IB/hfi1: add chip register definitions

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 01/49] IB/core: Add header definitions

2015-06-17 Thread Mike Marciniszyn
From: Ira Weiny ira.we...@intel.com Add common OPA header definitions for driver build: - opa_port_info.h - opa_smi.h - hfi1_user.sh Additionally, ib_mad.h, has additional definitions that are common to ib_drivers including: - trap support - cca support The qib driver has the duplication

[PATCH v3 03/49] IB/hfi1: add chip specific support part2

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 00/49] Add OPA gen1 driver

2015-06-17 Thread Mike Marciniszyn
This patch series adds the OPA gen1 driver. The patches are based on the the following repo/branch: git://github.com/dledford/linux.git: to-be-rebased/for-4.2 The patches add the files and headers and the last patch add the build hooks. Comments address: - Remove verbs sysfs counters

[PATCH v3 07/49] IB/hfi1: add chip specific headers

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 05/49] IB/hfi1: add chip specific support part4

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 08/49] IB/hfi1: add common header file definitions

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 09/49] IB/hfi1: add completion queue processing

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 02/49] IB/hfi1: add chip specific support part1

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 04/49] IB/hfi1: add chip specific support part3

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 10/49] IB/hfi1: add debugfs handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 32/49] IB/hfi1: add qp handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 33/49] IB/hfi1: add qsfp handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

RE: [PATCH v2 39/49] IB/hfi1: add sysfs routines

2015-06-17 Thread Marciniszyn, Mike
what's SC and what's SC-to-VL? aren't you using SM to do such mappings? if this and the below sysfs work-around/s for the maybe current lack of SM to configure the port? why do the upstream kernel has to carry ~hundreds of sysfs entries forever for such non-documented things? This sysfs

[PATCH v3 24/49] IB/hfi1: add OPA mad handling part2

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 19/49] IB/hfi1: add module init hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 23/49] IB/hfi1: add OPA mad handling part1

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 18/49] IB/hfi1: add general hfi header file

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 27/49] IB/hfi1: add memory region handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 28/49] IB/hfi1: add misc OPA defines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 16/49] IB/hfi1: add PSM driver control/data path

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 17/49] IB/hfi1: add firmware hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 20/49] IB/hfi1: add interrupt hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 15/49] IB/hfi1: add eeprom hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 22/49] IB/hfi1: add rkey/lkey validation

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 26/49] IB/hfi1: add user/kernel memory sharing hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 14/49] IB/hfi1: add low lower receive functions

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 12/49] IB/hfi1: add diagnostic hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 13/49] IB/hfi1: add dma operation hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 11/49] IB/hfi1: add char device instantiation code

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

RE: [PATCH v2 25/49] IB/hfi1: add local mad header

2015-06-17 Thread Marciniszyn, Mike
+/* + * Generic trap/notice types + */ +#define IB_NOTICE_TYPE_FATAL 0x80 +#define IB_NOTICE_TYPE_URGENT 0x81 +#define IB_NOTICE_TYPE_SECURITY0x82 +#define IB_NOTICE_TYPE_SM 0x83 +#define IB_NOTICE_TYPE_INFO0x84 Moved to ib_mad.h in v3.

[PATCH v3 30/49] IB/hfi1: add pio handling

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 29/49] IB/hfi1: add pcie routines

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 25/49] IB/hfi1: add local mad header

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 21/49] IB/hfi1: add progress delay/restart hooks

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

[PATCH v3 31/49] IB/hfi1: add platform config definitions

2015-06-17 Thread Mike Marciniszyn
Signed-off-by: Andrew Friedley andrew.fried...@intel.com Signed-off-by: Arthur Kepner arthur.kep...@intel.com Signed-off-by: Brendan Cunningham brendan.cunning...@intel.com Signed-off-by: Brian Welty brian.we...@intel.com Signed-off-by: Caz Yokoyama caz.yokoy...@intel.com Signed-off-by: Dean Luick

Re: [PATCH acm] acme.c: Fix IPv6 address handling in inet_any_pton

2015-06-17 Thread Hal Rosenstock
On 6/17/2015 1:50 AM, Hefty, Sean wrote: Thanks - applied manually Thanks. acm/src/acme.c |2 +- Path? diff --git a/acm/src/acme.c b/acm/src/acme.c index 9bf7557..d54c8b9 100644 --- a/acm/src/acme.c +++ b/acm/src/acme.c @@ -787,7 +787,7 @@ static int inet_any_pton(char *addr,

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-17 Thread Haggai Eran
On Tuesday, June 16, 2015 7:47 PM, Hefty, Sean sean.he...@intel.com wrote: To: Haggai Eran; Doug Ledford Cc: linux-rdma@vger.kernel.org; net...@vger.kernel.org; Liran Liss; Guy Shapiro; Shachar Raindel; Yotam Kenneth; Jason Gunthorpe Subject: RE: [PATCH 04/11] IB/cm: Expose DGID in SIDR

RE: [PATCH 36/41] IB/hfi1: add low level page locking

2015-06-17 Thread Marciniszyn, Mike
+ * hfi1_get_user_pages - lock user pages into memory + * @start_page: the start page + * @num_pages: the number of pages + * @p: the output page structures + * + * This function takes a given start page (page aligned user virtual + * address) and pins it and the following specified

Re: [PATCH v3 01/49] IB/core: Add header definitions

2015-06-17 Thread Hal Rosenstock
On 6/17/2015 8:28 AM, Mike Marciniszyn wrote: From: Ira Weiny ira.we...@intel.com Add common OPA header definitions for driver build: - opa_port_info.h - opa_smi.h - hfi1_user.sh Additionally, ib_mad.h, has additional definitions that are common to ib_drivers including: - trap support

RE: [PATCH 14/14] IB/mad: Add final OPA MAD processing

2015-06-17 Thread Weiny, Ira
ib_verbs define an *extensive* direct HW access API, which is constantly evolving. This is the problem with verbs... You cannot describe the intricate object relations and semantics through an API. In addition, you can't abstract anything or fix stuff in SW. The only way to *truly* know

Re: [PATCH v3] libibverbs init.c: conditionally emit warning if no userspace driver found

2015-06-17 Thread Doug Ledford
On Jun 16, 2015, at 10:25 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: Ping. This is just a periodic query to see if there has been any progress on accepting this patch into libibverbs. The patch is accepted, I just haven’t pushed it out yet. On Jun 3, 2015, at 12:50

RE: [PATCH v2 01/49] IB/core: Add OPA Port header definitions

2015-06-17 Thread Hefty, Sean
include/rdma/opa_port_info.h | 433 This matches the current code structure, but is this the best location for this file? Do you have a suggestion? Couldn't it be a header in the hfi1 driver directory ? Isn't it OPA specific ? I don't have a specific suggestion. If the

Re: [PATCH 04/11] IB/cm: Expose DGID in SIDR request events

2015-06-17 Thread Jason Gunthorpe
On Tue, Jun 16, 2015 at 02:25:07PM +0300, Haggai Eran wrote: But how is that going to work? How is the sender to know it should be sending a GRH with the CM message? If the admin wants to use SIDR with alias GIDs, they will need to configure the system to enable GRH for such GMPs. (This

RE: [PATCH 06/41] IB/hfi1: add char device instantiation code

2015-06-17 Thread Hefty, Sean
PSM2 (and PSM) uses this to dialog with the driver for hardware specific setup. I'm suspected at some point in the past, this was ioctl based and changed due to bias against ioctl. Could this be distinguished based on a common command header? -- To unsubscribe from this list: send the line

Re: [PATCH 06/41] IB/hfi1: add char device instantiation code

2015-06-17 Thread Jason Gunthorpe
On Wed, Jun 17, 2015 at 12:05:08PM +, Marciniszyn, Mike wrote: Jason, what is your take on ioctl vs. write. Well, I think the global view keeps changing, so I'm not sure what is trendy now.. But personally, I hate seeing write() used to emulate ioctl() because 'ioctl is bad'. ie if you are

Re: [PATCH v2 39/49] IB/hfi1: add sysfs routines

2015-06-17 Thread Or Gerlitz
On Wed, Jun 17, 2015 at 2:48 PM, Marciniszyn, Mike mike.marcinis...@intel.com wrote: what's SC and what's SC-to-VL? aren't you using SM to do such mappings? if this and the below sysfs work-around/s for the maybe current lack of SM to configure the port? why do the upstream kernel has to

RE: [PATCH 00/41] Add OPA gen1 driver

2015-06-17 Thread Hefty, Sean
Ummm.. Could we get some more descriptions as to what this code is for? Do we have a new OmniPath protocol here as well or is it IB? Which standards are followed? I think the APIs that the driver uses need to be documented somewhere in particular if new sysfs entries etc are created.