Re: [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-07-06 Thread Luis R. Rodriguez
On Mon, Jul 6, 2015 at 5:44 PM, Luis R. Rodriguez wrote: > If we really wanted to we could consider arch_phys_wc_add() I mean adding a __arch_phys_wc_add() which does not check for pat_enabled(). > and > deal with that this will not check for pat_enabled() and forces MTRR... > I think Andy Luto

RE: IBV_SEND_INLINE Behavior Differing from Spec

2015-07-06 Thread Shachar Raindel
Hi, > From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > ow...@vger.kernel.org] On Behalf Of Christopher Mitchell > Sent: Tuesday, July 07, 2015 5:21 AM > > Roland, > > My libmlx4 is named libmlx4-rdmav2.so and timestamped 2014-01-01 (from > the package libmlx4-1, 1.0.5-1ubuntu1 for U

Re: [PATCH V5 3/5] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth

2015-07-06 Thread Sagi Grimberg
On 7/6/2015 5:35 PM, Steve Wise wrote: -Original Message- From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] Sent: Monday, July 06, 2015 2:51 AM To: Steve Wise; dledf...@redhat.com Cc: infinip...@intel.com; sa...@mellanox.com; ogerl...@mellanox.com; r...@mellanox.com; linux-rdma@vg

Re: IBV_SEND_INLINE Behavior Differing from Spec

2015-07-06 Thread Christopher Mitchell
Roland, My libmlx4 is named libmlx4-rdmav2.so and timestamped 2014-01-01 (from the package libmlx4-1, 1.0.5-1ubuntu1 for Ubuntu Trusty 14.04). I use a mutex-protected FIFO of send buffers to make sure only one thread is able to acquire a particular send buffer at a time, and my application does no

Re: [PATCH v2 2/2] x86/mm/pat, drivers/media/ivtv: move pat warn and replace WARN() with pr_warn()

2015-07-06 Thread Luis R. Rodriguez
On Mon, Jun 29, 2015 at 05:52:18AM -0400, Andy Walls wrote: > On June 29, 2015 2:55:05 AM EDT, Ingo Molnar wrote: > > > >* Andy Walls wrote: > > > >> On Fri, 2015-06-26 at 10:45 +0200, Ingo Molnar wrote: > >> > * Luis R. Rodriguez wrote: > >> > > >> > > On Thu, Jun 25, 2015 at 08:51:47AM +0200,

Re: [PATCH V5 0/5] iSER support for iWARP

2015-07-06 Thread Nicholas A. Bellinger
Hi Steve & Co, On Sun, 2015-07-05 at 12:44 -0500, Steve Wise wrote: > The following series implements support for iWARP transports in the iSER > initiator and target. This is based on Doug's k.o/for-4.2 branch. > > I've tested this on cxgb4 and mlx4 hardware. > > Changes since V4: > > iser: fi

RE: [PATCH for-4.2 0/1] RDMA/core: Fixes for port mapper client registration

2015-07-06 Thread Nikolova, Tatyana E
Hello Steve, >> how can I reproduce the original bug/issue and then test this fix on >> iw_cxgb4? Have iwpmd running and start an rdma application. Leave the rdma application running and restart the iwpmd. When you stop the application, if you have the debug enabled, you will see that the rem

Re: [PATCH v7 1/4] IB/netlink: Add defines for local service requests through netlink

2015-07-06 Thread Jason Gunthorpe
> > > +/* Local service status attribute */ > > > +enum { > > > + LS_NLA_STATUS_SUCCESS = 0, > > > + LS_NLA_STATUS_EINVAL, > > > + LS_NLA_STATUS_ENODATA, > > > + LS_NLA_STATUS_MAX > > > +}; > > > > So, this is never used, there seems to be a bunch of never used stuff > > - please audit everything

RE: [PATCH v7 1/4] IB/netlink: Add defines for local service requests through netlink

2015-07-06 Thread Wan, Kaike
> From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > Sent: Friday, July 03, 2015 5:16 PM > To: Wan, Kaike > Cc: linux-rdma@vger.kernel.org; Fleck, John; Weiny, Ira > Subject: Re: [PATCH v7 1/4] IB/netlink: Add defines for local service requests > through netlink > > On Tue, Jun 30, 2

RE: [PATCH for-4.2 0/1] RDMA/core: Fixes for port mapper client registration

2015-07-06 Thread Steve Wise
> -Original Message- > From: Tatyana Nikolova [mailto:tatyana.e.nikol...@intel.com] > Sent: Thursday, July 02, 2015 12:46 PM > To: Doug Ledford > Cc: john.s.laco...@intel.com; sw...@opengridcomputing.com; > linux-rdma@vger.kernel.org > Subject: [PATCH for-4.2 0/1] RDMA/core: Fixes for po

Re: [PATCH for-next V6 3/5] IB/uverbs: Enable device removal when there are active user space applications

2015-07-06 Thread Jason Gunthorpe
On Mon, Jul 06, 2015 at 05:08:08PM +0300, Yishai Hadas wrote: > The patch that introduces this bug was added 5 years ago by Alex Chiang and > Signed-off-by: Roland Dreier. > > Look at commit ID:2a72f212263701b927559f6850446421d5906c41, it can be seen > also at: > http://git.kernel.org/cgit/linux/

RE: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Steve Wise
> -Original Message- > From: linux-rdma-ow...@vger.kernel.org > [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Sagi Grimberg > Sent: Monday, July 06, 2015 11:18 AM > To: Steve Wise; dledf...@redhat.com > Cc: sa...@mellanox.com; ogerl...@mellanox.com; r...@mellanox.com; > linux-r

Re: [PATCH v3] libibverbs init.c: conditionally emit warning if no userspace driver found

2015-07-06 Thread Doug Ledford
On 07/06/2015 09:35 AM, Jeff Squyres (jsquyres) wrote: > On Jun 17, 2015, at 10:25 AM, Doug Ledford > wrote: >> >> The patch is accepted, I just haven’t pushed it out yet. > > Is there a timeline for when this patch will be available in the > upstream git repo and released in a new version of li

Re: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Sagi Grimberg
On 7/6/2015 5:37 PM, Steve Wise wrote: -Original Message- From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] Sent: Monday, July 06, 2015 2:54 AM To: Steve Wise; dledf...@redhat.com Cc: sa...@mellanox.com; ogerl...@mellanox.com; r...@mellanox.com; linux-rdma@vger.kernel.org; e...@me

RE: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Monday, July 06, 2015 2:59 AM > To: Steve Wise; dledf...@redhat.com > Cc: sa...@mellanox.com; ogerl...@mellanox.com; r...@mellanox.com; > linux-rdma@vger.kernel.org; e...@mellanox.com; target- > de...@vg

RE: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Monday, July 06, 2015 2:54 AM > To: Steve Wise; dledf...@redhat.com > Cc: sa...@mellanox.com; ogerl...@mellanox.com; r...@mellanox.com; > linux-rdma@vger.kernel.org; e...@mellanox.com; target- > de...@vg

RE: [PATCH V5 3/5] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth

2015-07-06 Thread Steve Wise
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Monday, July 06, 2015 2:51 AM > To: Steve Wise; dledf...@redhat.com > Cc: infinip...@intel.com; sa...@mellanox.com; ogerl...@mellanox.com; > r...@mellanox.com; linux-rdma@vger.kernel.org; > e...@mellanox

RE: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Steve Wise
> -Original Message- > From: Haggai Eran [mailto:hagg...@mellanox.com] > Sent: Monday, July 06, 2015 2:09 AM > To: Steve Wise; dledf...@redhat.com > Cc: sa...@mellanox.com; ogerl...@mellanox.com; r...@mellanox.com; > linux-rdma@vger.kernel.org; e...@mellanox.com; target- > de...@vger.ker

RE: [PATCH V3 0/5] Transport-independent MRs

2015-07-06 Thread Steve Wise
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Monday, July 06, 2015 12:26 AM > To: Steve Wise > Cc: dledf...@redhat.com; sa...@mellanox.com; ogerl...@mellanox.com; > r...@mellanox.com; linux-rdma@vger.kernel.org; > e...@mellanox.com; target-de...@vger

RE: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Steve Wise
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Monday, July 06, 2015 12:25 AM > To: Steve Wise > Cc: dledf...@redhat.com; sa...@mellanox.com; ogerl...@mellanox.com; > r...@mellanox.com; linux-rdma@vger.kernel.org; > e...@mellanox.com; target-de...@vger

Re: [PATCH for-next V6 3/5] IB/uverbs: Enable device removal when there are active user space applications

2015-07-06 Thread Yishai Hadas
On 6/30/2015 9:40 PM, Jason Gunthorpe wrote: On Tue, Jun 30, 2015 at 01:26:05PM +0300, Yishai Hadas wrote: struct ib_uverbs_device { - struct kref ref; + struct kref comp_ref; + struct kref fr

Re: [PATCH v3] libibverbs init.c: conditionally emit warning if no userspace driver found

2015-07-06 Thread Jeff Squyres (jsquyres)
On Jun 17, 2015, at 10:25 AM, Doug Ledford wrote: > > The patch is accepted, I just haven’t pushed it out yet. Is there a timeline for when this patch will be available in the upstream git repo and released in a new version of libibverbs? I ask because we'd like to see this patch get into upst

Re: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Sagi Grimberg
On 7/6/2015 2:22 AM, Steve Wise wrote: The semantics for MR access flags are not consistent across RDMA protocols. So rather than have applications try and glean what they need, have them pass in the intended roles and attributes for the MR to be allocated and let the RDMA core select the approp

Re: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Sagi Grimberg
On 7/6/2015 2:22 AM, Steve Wise wrote: The semantics for MR access flags are not consistent across RDMA protocols. So rather than have applications try and glean what they need, have them pass in the intended roles and attributes for the MR to be allocated and let the RDMA core select the approp

Re: [PATCH V5 5/5] RDMA/isert: Limit read depth based on the device max_sge_rd capability

2015-07-06 Thread Sagi Grimberg
On 7/5/2015 8:45 PM, Steve Wise wrote: Use the device's max_sge_rd capability to compute the target's read sge depth. Save both the read and write max_sge values in the isert_conn struct, and use these when creating RDMA_WRITE/READ work requests. Signed-off-by: Steve Wise Reviewed-by: Sagi G

Re: [PATCH V5 4/5] RDMA/isert: Set REMOTE_WRITE on DMA MRs to support iWARP devices

2015-07-06 Thread Sagi Grimberg
On 7/5/2015 8:45 PM, Steve Wise wrote: iWARP devices require REMOTE_WRITE for MRs used as the destination of an RDMA READ. So if the device protocol is iWARP, then set REMOTE_WRITE when allocating the DMA MR. Signed-off-by: Steve Wise Reviewed-by: Sagi Grimberg -- To unsubscribe from this l

Re: [PATCH V5 3/5] RDMA/iser: Limit sg tablesize and max_sectors to device fastreg max depth

2015-07-06 Thread Sagi Grimberg
On 7/5/2015 8:44 PM, Steve Wise wrote: Currently the sg tablesize, which dictates fast register page list depth to use, does not take into account the limits of the rdma device. So adjust it once we discover the device fastreg max depth limit. Also adjust the max_sectors based on the resulting s

Re: [PATCH V3 1/5] RDMA/core: Transport-independent access flags

2015-07-06 Thread Haggai Eran
On 06/07/2015 02:22, Steve Wise wrote: > +int rdma_device_access_flags(struct ib_pd *pd, int roles, int attrs) > +{ > + int access_flags = attrs; > + > + if (roles & RDMA_MRR_RECV) > + access_flags |= IB_ACCESS_LOCAL_WRITE; > + > + if (roles & RDMA_MRR_WRITE_DEST) > +