What opcodes are supposed to be submitted by users?
Currently we do not define opcodes in the UAPI and kinda rely that
userspace uses the same ones as the kernel.
For thos defines by libibverbs (RDMA_WRITE, RDMA_WRITE_WITH_IMM,
SEND, SEND_WITH_IMM, RDMA_READ, ATOMIC_CMP_AND_SWP and
On 8/18/2015 8:50 PM, Jason Gunthorpe wrote:
On Thu, Aug 13, 2015 at 06:32:07PM +0300, Yishai Hadas wrote:
@@ -501,10 +586,24 @@ static ssize_t ucma_destroy_id(struct ucma_file *file,
const char __user *inbuf,
+ if (!ctx-closing) {
+ mutex_unlock(mut);
+
On 7/23/2015 8:55 PM, Jason Gunthorpe wrote:
On Thu, Jul 23, 2015 at 01:15:16PM +0300, Sagi Grimberg wrote:
I was hoping we'd move the DMA flush and translate into here and make
it mandatory. Is there any reason not to do that?
The reason I didn't added it in was so the ULPs can make sure
On Wed, Aug 19, 2015 at 02:56:24PM +0300, Sagi Grimberg wrote:
So I had a go with moving the DMA mapping into ib_map_mr_sg() and
it turns out mapping somewhat poorly if the ULP _may_ register memory
or just send sg_lists (like storage targets over IB/iWARP). So the ULP
will sometimes use the
Keep it out for now.
Ok, I was also thinking on moving the access flags
to the work request again. It doesn't make much sense there
unless I go with what Jason suggested with ib_map_mr_[lkey|rkey]
to protect against remote access for lkeys in IB which to me, sounds
redundant at this point
This series shrinks the WR size by splitting out the different WR
types.
Patch number two is too large for the mailinglist, so if you didn't
get it grab it here:
http://git.infradead.org/users/hch/rdma.git/commitdiff/30e522ee6c1d7adb614d7308f09fbfd71c6d3e07
or the full git tree at:
The field is only initialized in mlx, but never used.
If we want to add proper XRC support it should be done with a new
struct ib_xrc_wr.
This shrinks the various WR structures by another 4 bytes.
Signed-off-by: Christoph Hellwig h...@lst.de
---
drivers/infiniband/hw/mlx5/qp.c | 1 -
We have many WR opcodes that are only supported in kernel space
and/or require optional information to be copied into the WR
structure. Reject all those not explicitly handled so that we
can't pass invalid information to drivers.
Cc: sta...@vger.kernel.org
Signed-off-by: Christoph Hellwig
On Wed, Aug 19, 2015 at 02:56:24PM +0300, Sagi Grimberg wrote:
On 7/23/2015 8:55 PM, Jason Gunthorpe wrote:
On Thu, Jul 23, 2015 at 01:15:16PM +0300, Sagi Grimberg wrote:
I was hoping we'd move the DMA flush and translate into here and make
it mandatory. Is there any reason not to do that?
On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote:
Reviewed-by: Jason Gunthorpe jguntho...@obsidianresearch.com
AFAIK, this path is rarely (never?) actually used. I think all the
drivers we have can post directly from userspace.
Oh, interesting. Is there any chance to
On Wed, Aug 19, 2015 at 07:48:02PM +0200, Christoph Hellwig wrote:
On Wed, Aug 19, 2015 at 11:46:14AM -0600, Jason Gunthorpe wrote:
Reviewed-by: Jason Gunthorpe jguntho...@obsidianresearch.com
AFAIK, this path is rarely (never?) actually used. I think all the
drivers we have can post
On Wed, Aug 19, 2015 at 06:37:34PM +0200, Christoph Hellwig wrote:
The field is only initialized in mlx, but never used.
If we want to add proper XRC support it should be done with a new
struct ib_xrc_wr.
This shrinks the various WR structures by another 4 bytes.
Reviewed-by: Jason
On Wed, Aug 19, 2015 at 07:09:18PM +0300, Sagi Grimberg wrote:
Ok, I was also thinking on moving the access flags
to the work request again.
Yes, with the current code I don't think we need it in the MR.
I'd prefer to get this right with a different helper like Steve
suggested:
int
On Wed, Aug 19, 2015 at 06:37:32PM +0200, Christoph Hellwig wrote:
We have many WR opcodes that are only supported in kernel space
and/or require optional information to be copied into the WR
structure. Reject all those not explicitly handled so that we
can't pass invalid information to
On Wed, Aug 19, 2015 at 04:59:11PM +0300, Yishai Hadas wrote:
On 8/18/2015 8:50 PM, Jason Gunthorpe wrote:
On Thu, Aug 13, 2015 at 06:32:07PM +0300, Yishai Hadas wrote:
@@ -501,10 +586,24 @@ static ssize_t ucma_destroy_id(struct ucma_file
*file, const char __user *inbuf,
+ if
AFAIK, this path is rarely (never?) actually used. I think all the
drivers we have can post directly from userspace.
I didn't think the ipath or qib drivers post from userspace.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to
16 matches
Mail list logo
