Re: [PATCH] IB/cma: Fix net_dev reference leak with failed requests

2015-08-30 Thread Or Gerlitz
On Thu, Aug 27, 2015 at 5:55 AM, Haggai Eran hagg...@mellanox.com wrote: When no matching listening ID is found for a given request, the net_dev that was used to find the request isn't released. Fixes: 20c36836ecad (IB/cma: Use found net_dev for passive connections) same here, Doug, if this

Re: [PATCH v4 09/14] IB/cm: Expose BTH P_Key in CM and SIDR request events

2015-08-30 Thread Sagi Grimberg
On 7/30/2015 5:50 PM, Haggai Eran wrote: The rdma_cm module will later use the P_Key from the BTH to de-mux requests. See discussion at: http://www.spinics.net/lists/netdev/msg336067.html I've been hitting errors with srp target with this series applied. Not sure if this series exposes a

Re: shrink struct ib_send_wr V3

2015-08-30 Thread Sagi Grimberg
On 8/30/2015 6:31 PM, Sagi Grimberg wrote: - patch 2 now explicitly replaces the weird overloading in the mlx5 driver with an explicit embedding of struct ib_send_wr, similar to what we do for all other MRs. That's nice, There is one non-trivial spot that was missed in

Re: shrink struct ib_send_wr V3

2015-08-30 Thread Sagi Grimberg
- patch 2 now explicitly replaces the weird overloading in the mlx5 driver with an explicit embedding of struct ib_send_wr, similar to what we do for all other MRs. That's nice, There is one non-trivial spot that was missed in mlx5_ib_post_send though: diff --git

Re: [PATCH] IB/cma: Fix net_dev reference leak with failed requests

2015-08-30 Thread Doug Ledford
On 08/30/2015 02:12 AM, Or Gerlitz wrote: On Thu, Aug 27, 2015 at 5:55 AM, Haggai Eran hagg...@mellanox.com wrote: When no matching listening ID is found for a given request, the net_dev that was used to find the request isn't released. Fixes: 20c36836ecad (IB/cma: Use found net_dev for

Re: mlx4 problems with 4.2-rc8

2015-08-30 Thread Doug Ledford
On 08/29/2015 09:13 PM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 10:27 PM, Doug Ledford dledf...@redhat.com wrote: I'm seeing this with rc8 on a dual port mlx4 adapter set to IB/Eth mode: mmm, both Amir and myself are just finishing vacations... so WB notes are not always lovely as you want

Re: [patch] IB/core: missing curly braces in ib_find_gid()

2015-08-30 Thread Doug Ledford
On 08/30/2015 12:59 AM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 9:02 PM, Doug Ledford dledf...@redhat.com wrote: On 08/28/2015 09:10 PM, ira.weiny wrote: On Tue, Aug 18, 2015 at 12:22:10PM +0300, Dan Carpenter wrote: Smatch says that, based on the indenting, we should probably add curly