Re: [PATCH v4 09/14] IB/cm: Expose BTH P_Key in CM and SIDR request events

2015-08-31 Thread Haggai Eran
On 30/08/2015 21:23, Sagi Grimberg wrote: > > Looks like for some reason cm_get_bth_pkey got pkey_index of 0x > instead of 0 (working on the default pkey 0x at entry 0). It looks like the mlx5 driver doesn't interpret the completion format correctly. It takes a field defined in the

Re: mlx4 problems with 4.2-rc8

2015-08-31 Thread Matan Barak
On 8/31/2015 1:38 AM, Doug Ledford wrote: On 08/29/2015 09:13 PM, Or Gerlitz wrote: On Fri, Aug 28, 2015 at 10:27 PM, Doug Ledford wrote: I'm seeing this with rc8 on a dual port mlx4 adapter set to IB/Eth mode: mmm, both Amir and myself are just finishing vacations...

[PATCH] mlx5: Fix incorrect wc pkey_index assignment for GSI messages

2015-08-31 Thread Sagi Grimberg
Since patch series "Demux IB CM requests in the rdma_cm module" the P_Key index is taken from the work completion rather than the message itself (see http://www.spinics.net/lists/netdev/msg335599.html). The HCA provides us with the message P_Key. In order to provide the P_Key index, we need to

Re: [PATCH v3 01/49] IB/core: Add header definitions

2015-08-31 Thread ira.weiny
Hal, I'm working on a couple of patches to address these comments. I will be submitting them in the next day or so. On Wed, Jun 17, 2015 at 10:12:41AM -0400, Hal Rosenstock wrote: > On 6/17/2015 8:28 AM, Mike Marciniszyn wrote: > > From: Ira Weiny > > > > Add common OPA

Re: shrink struct ib_send_wr V3

2015-08-31 Thread Christoph Hellwig
On Sun, Aug 30, 2015 at 06:31:35PM +0300, Sagi Grimberg wrote: >> - patch 2 now explicitly replaces the weird overloading in the mlx5 >> driver with an explicit embedding of struct ib_send_wr, similar >> to what we do for all other MRs. > > That's nice, > > There is one non-trivial spot

Re: [PATCH] mlx5: Fix incorrect wc pkey_index assignment for GSI messages

2015-08-31 Thread Or Gerlitz
On Mon, Aug 31, 2015 at 6:24 PM, Sagi Grimberg wrote: > Since patch series "Demux IB CM requests in the rdma_cm module" the > P_Key index is taken from the work completion rather than the message itself so prior to this series nobody in the IB core (and maybe across the whole

Re: mlx4 problems with 4.2-rc8

2015-08-31 Thread Or Gerlitz
On Mon, Aug 31, 2015 at 4:02 PM, Doug Ledford wrote: > On 08/31/2015 03:09 AM, Matan Barak wrote: >> Actually, it looks like the dump stack we've got before [1] was fixed. >> This happens when the mlx4 driver is used in setups where number of >> cores >= 32. >> Doug, is

Re: mlx4 problems with 4.2-rc8

2015-08-31 Thread Doug Ledford
On 08/31/2015 04:21 PM, Or Gerlitz wrote: > On Mon, Aug 31, 2015 at 4:02 PM, Doug Ledford wrote: >> On 08/31/2015 03:09 AM, Matan Barak wrote: > >>> Actually, it looks like the dump stack we've got before [1] was fixed. >>> This happens when the mlx4 driver is used in setups

Re: [PATCH] IB/cma: Fix net_dev reference leak with failed requests

2015-08-31 Thread Doug Ledford
On 08/31/2015 11:20 AM, Weiny, Ira wrote: >> >> On 08/30/2015 02:12 AM, Or Gerlitz wrote: >>> On Thu, Aug 27, 2015 at 5:55 AM, Haggai Eran >> wrote: When no matching listening ID is found for a given request, the net_dev that was used to find the request isn't

Re: shrink struct ib_send_wr V3

2015-08-31 Thread Doug Ledford
On 08/31/2015 12:11 PM, Christoph Hellwig wrote: > On Sun, Aug 30, 2015 at 06:31:35PM +0300, Sagi Grimberg wrote: >>> - patch 2 now explicitly replaces the weird overloading in the mlx5 >>> driver with an explicit embedding of struct ib_send_wr, similar >>> to what we do for all other

Re: [PATCH v4 09/14] IB/cm: Expose BTH P_Key in CM and SIDR request events

2015-08-31 Thread Sagi Grimberg
On 8/31/2015 9:50 AM, Haggai Eran wrote: On 30/08/2015 21:23, Sagi Grimberg wrote: Looks like for some reason cm_get_bth_pkey got pkey_index of 0x instead of 0 (working on the default pkey 0x at entry 0). It looks like the mlx5 driver doesn't interpret the completion format