Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: > > Commit 8301a2c047cc ("xprtrdma: Limit work done by completion > handler") was supposed to prevent xprtrdma's upcall handlers from > starving other softIRQ work by letting them return to the provider > before all CQEs

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

On Fri, Sep 18, 2015 at 11:51:09AM -0400, Doug Ledford wrote: > On 09/16/2015 02:22 AM, Dan Carpenter wrote: > > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > > oops on failure. > > > > Signed-off-by: Dan Carpenter > > Thanks, applied.

Re: [PATCH v1 03/18] xprtrdma: Remove completion polling budgets

Hi Devesh- On Sep 18, 2015, at 2:52 AM, Devesh Sharma wrote: > On Fri, Sep 18, 2015 at 2:14 AM, Chuck Lever wrote: >> >> Commit 8301a2c047cc ("xprtrdma: Limit work done by completion >> handler") was supposed to prevent xprtrdma's upcall

RE: [PATCH] infiniband:core:Fix error handling in the function cm_lap_handler

> diff --git a/drivers/infiniband/core/cm.c b/drivers/infiniband/core/cm.c > index ea4db9c..8fab3a7 100644 > --- a/drivers/infiniband/core/cm.c > +++ b/drivers/infiniband/core/cm.c > @@ -2812,7 +2812,12 @@ static int cm_lap_handler(struct cm_work *work) > cm_init_av_for_response(work->port,

Re: [patch] IB/hfi1: fix a locking bug

On 09/16/2015 02:22 AM, Dan Carpenter wrote: > mutex_trylock() returns zero on failure, not EBUSY. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD signature.asc Description: OpenPGP

Re: [patch] IB/hfi1: checking for NULL instead of IS_ERR

On 09/16/2015 02:22 AM, Dan Carpenter wrote: > __get_txreq() returns an ERR_PTR() but this checks for NULL so it would > oops on failure. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford GPG KeyID: 0E572FDD

Re: [PATCH V2] IB/hfi: Properly set permissions for user device files

On 09/17/2015 01:47 PM, ira.we...@intel.com wrote: > From: Ira Weiny > > Some of the device files are required to be user accessible for PSM while > most should remain accessible only by root. > > Add a parameter to hfi1_cdev_init which controls if the user should have >

[PULL REQUEST] Please pull rdma.git

Hi Linus, The new hfi1 driver in staging/rdma has had a number of fixup patches since being added to the tree. This is the first batch of those fixes. The following changes since commit 447e9a4d27484175a84daaa8e03d35c650f443b7: IB/ehca: Deprecate driver, move to staging, schedule deletion

Re: [patch] IB/hfi1: fix copy_to/from_user() error handling

On 09/15/2015 06:35 AM, Dan Carpenter wrote: > copy_to/from_user() returns the number of bytes which we were not able > to copy. It doesn't return an error code. > > Also a couple places had a printk() on error and I removed that because > people can take advantage of it to fill

Re: [PATCH] IB/hfi1: fix sdma_descq_cnt parameter parsing

On 09/15/2015 10:19 AM, Mike Marciniszyn wrote: > The boolean tests should have been or-ed. > > Reported-by: David Binderman > Reviewed-by: Jubin John > Signed-off-by: Mike Marciniszyn Thanks, applied. -- Doug Ledford

Re: [PATCH] IB/hfi1: fix pstateinfo from returning improperly byteswapped value

On 09/09/2015 01:28 AM, ira.we...@intel.com wrote: > From: Ira Weiny > > Byteswap link_width_downgrade_*_active values before sending on the wire. In > addition properly define the Port State Info structure. > > Reviewed-by: Dennis Dalessandro

Re: [patch v2] IB/hfi1: info leak in get_ctxt_info()

On 09/16/2015 02:42 AM, Dan Carpenter wrote: > The cinfo struct has a hole after the last struct member so we need to > zero it out. Otherwise we disclose some uninitialized stack data. > > Signed-off-by: Dan Carpenter Thanks, applied. -- Doug Ledford