Re: [PATCH] IB/iser: constify iser_reg_ops structure

2015-11-29 Thread Sagi Grimberg
On 28/11/2015 17:52, Julia Lawall wrote: The iser_reg_ops structures are never modified, so declare them as const. Done with the help of Coccinelle. Signed-off-by: Julia Lawall Thanks, Acked-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the

[PATCH 0/4] mstflint source code cleanup patches

2015-11-29 Thread Bart Van Assche
These four patches bring the mstflint coding style closer to that of the other RDMA user space software. The patches in this series are: 0001-Fix-several-automake-warnings.patch 0002-Makefile.am-Remove-the-undefined-variable-MFT_EXT_LI.patch 0003-crd_read_line-Rework-code-to-suppress-a-compiler-

[PATCH 1/4] Fix several automake warnings

2015-11-29 Thread Bart Van Assche
Avoid that automake reports the following warning messages: configure.ac:13: warning: AM_INIT_AUTOMAKE: two- and three-arguments forms are deprecated. For more info, see: configure.ac:13: http://www.gnu.org/software/automake/manual/automake.html#Modernize-AM_005fINIT_005fAUTOMAKE-invocation sma

[PATCH 2/4] Makefile.am: Remove the undefined variable MFT_EXT_LIBS_INC_DIR

2015-11-29 Thread Bart Van Assche
This avoids that the option sequence "-I -I" is passed to the compiler, a sequence that causes weird error messages to be printed. Signed-off-by: Bart Van Assche --- mlxconfig/Makefile.am| 2 +- mlxfwops/lib/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/m

[PATCH 3/4] crd_read_line(): Rework code to suppress a compiler warning

2015-11-29 Thread Bart Van Assche
Avoid that gcc prints a warning about not checking the result of fgets(). Signed-off-by: Bart Van Assche --- mstdump/crd_lib/crdump.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mstdump/crd_lib/crdump.c b/mstdump/crd_lib/crdump.c index 451a944..3e3c4bc 100755 --- a/ms

[PATCH 4/4] Fix compiler warnings about set-but-not-used variables

2015-11-29 Thread Bart Van Assche
Recent gcc versions emit a warning if a variable is set but not used. Suppress these warnings by removing dummy assignments to unused arguments. Additionally, enable the compiler command-line option -Wno-unused-parameter and remove the '(void)arg' statements that thereby became superfluous. Signed

[PATCH 0/3] constify mmu_notifier_ops structures

2015-11-29 Thread Julia Lawall
mmu_notifier_ops structures are never modified, so declare them all as const. --- drivers/infiniband/core/umem_odp.c |2 +- drivers/iommu/amd_iommu_v2.c |2 +- drivers/xen/gntdev.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) -- To unsubscribe from this

[PATCH 3/3] IB/core: constify mmu_notifier_ops structures

2015-11-29 Thread Julia Lawall
This mmu_notifier_ops structure is never modified, so declare it as const, like the other mmu_notifier_ops structures. Done with the help of Coccinelle. Signed-off-by: Julia Lawall --- The patches in this series are independent of each other. drivers/infiniband/core/umem_odp.c |2 +- 1 fi

Re: [PATCH 3/3] IB/core: constify mmu_notifier_ops structures

2015-11-29 Thread Haggai Eran
On 30/11/2015 00:02, Julia Lawall wrote: > This mmu_notifier_ops structure is never modified, so declare it as > const, like the other mmu_notifier_ops structures. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall Reviewed-by: Haggai Eran Thanks, Haggai -- To unsubscribe