Re: [PATCH 10/13] IB/srp: use the new CQ API

2015-12-13 Thread Sagi Grimberg
Allright. How do you want to proceed? The current rdma-cq branch has all kinds of dependencies, but I've also prepared a new rdma-cq.2 branch that could go straight on top of your current queue: http://git.infradead.org/users/hch/rdma.git/shortlog/refs/heads/rdma-cq.2 If you're ready to

Re: completion queue abstraction V2

2015-12-13 Thread Sagi Grimberg
Needless to say, on the entire series you can add my: Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [RFC contig pages support 1/2] IB: Supports contiguous memory operations

2015-12-13 Thread Shachar Raindel
> -Original Message- > From: Christoph Hellwig [mailto:h...@infradead.org] > Sent: Wednesday, December 09, 2015 8:40 PM > > On Wed, Dec 09, 2015 at 10:00:02AM +, Shachar Raindel wrote: > > As far as gain is concerned, we are seeing gains in two cases here: > > 1. If the system has

Re: [PATCH for-next V2 05/11] IB/core: Add rdma_network_type to wc

2015-12-13 Thread Matan Barak
On Sun, Dec 13, 2015 at 3:56 PM, Liran Liss wrote: >> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > >> >> > You are pushing abstraction into provider code instead of handling it in a >> generic way. >> >> No, I am defining an API that *make sense* and doesn't

Re: [PATCH for-next V1 2/5] IB/core: Add ib_is_udata_cleared

2015-12-13 Thread Haggai Eran
On 10/12/2015 19:29, Matan Barak wrote: > On Thu, Dec 10, 2015 at 5:20 PM, Haggai Eran wrote: >> On 10/12/2015 16:59, Matan Barak wrote: >>> On Mon, Dec 7, 2015 at 3:18 PM, Haggai Eran wrote: On 12/03/2015 05:44 PM, Matan Barak wrote: >

RE: [PATCH for-next V2 05/11] IB/core: Add rdma_network_type to wc

2015-12-13 Thread Liran Liss
> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- > > > You are pushing abstraction into provider code instead of handling it in a > generic way. > > No, I am defining an API that *make sense* and doesn't leak useless details. > Of course that doesn't force code duplication or

Re: [PATCH v3 1/6] svcrdma: Do not send XDR roundup bytes for a write chunk

2015-12-13 Thread Chuck Lever
Hi Tom- > On Dec 12, 2015, at 10:14 PM, Tom Talpey wrote: > > Two small comments. > > On 12/7/2015 12:42 PM, Chuck Lever wrote: >> Minor optimization: when dealing with write chunk XDR roundup, do >> not post a Write WR for the zero bytes in the pad. Simply update >> the

Re: [PATCH v3 5/6] svcrdma: Add infrastructure to receive backwards direction RPC/RDMA replies

2015-12-13 Thread Chuck Lever
Hi Tom- > On Dec 12, 2015, at 10:24 PM, Tom Talpey wrote: > > Three comments. > > On 12/7/2015 12:43 PM, Chuck Lever wrote: >> To support the NFSv4.1 backchannel on RDMA connections, add a >> capability for receiving an RPC/RDMA reply on a connection >> established by a