ocrdma failure in 4.4.0-rc5

2015-12-19 Thread Doug Ledford
Hi Devesh, Testing 4.4.0-rc5, the ocrdma driver is failing for me (100% reliably). If you have vlans off of the main device, this is what I get from the Fedora rawhide 4.4.0-rc5 kernel: -- Doug Ledford GPG KeyID: 0E572FDD [ 26.692881] be2net :85:00.0

[PATCH] IB/usnic: delete unneeded IS_ERR test

2015-12-19 Thread Julia Lawall
kzalloc doesn't return ERR_PTR, so there is no need to test for it. The semantic match that finds this problem is as follows: (http://coccinelle.lip6.fr/) // @@ expression x,e; @@ * x = kzalloc(...) ... when != x = e * IS_ERR_OR_NULL(x) // Signed-off-by: Julia Lawall

Re: [PATCH 09/10] IB: remove the struct ib_phys_buf definition

2015-12-19 Thread Or Gerlitz
On 12/18/2015 3:55 PM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Reviewed-by: Sagi Grimberg Reviewed-by: Jason Gunthorpe [core] Reviewed-by: Steve Wise Here, too, please avoid

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

2015-12-19 Thread Or Gerlitz
On 12/20/2015 9:25 AM, Or Gerlitz wrote: On 12/18/2015 3:55 PM, Christoph Hellwig wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 284916d..e45776e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1306,7 +1306,6 @@ struct ib_mr { u64

Re: RoCE passive side failures on 4.4-rc5

2015-12-19 Thread Or Gerlitz
On 12/17/2015 3:58 PM, Or Gerlitz wrote: Using 4.4-rc5+ [1] and **not** applying any of the patches I sent today, I noted that RoCE passive side isn't working (rdma-cm, ibv_rc_pingpong works). I have two nodes in ConnectX3 VPI config (port1 IB and port2 Eth), the one with the 4.4-rc5 kernel

[PATCH] libmlx5: Add gitignore file to the project

2015-12-19 Thread Leon Romanovsky
From: Leon Romanovsky Add gitignore file to the libmlx5 project. Signed-off-by: Leon Romanovsky --- .gitignore | 20 1 file changed, 20 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitignore new file

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

2015-12-19 Thread Or Gerlitz
On 12/18/2015 4:14 PM, Bart Van Assche wrote: On 12/18/2015 02:55 PM, Christoph Hellwig wrote: Signed-off-by: Christoph Hellwig Shouldn't the description of this patch be changed into something like "Remove the usecnt field from ib_mr since it is always zero" ? Agree. I

Re: [PATCH 10/10] IB: remove the unused usecnt field from struct ib_mr

2015-12-19 Thread Or Gerlitz
On 12/18/2015 3:55 PM, Christoph Hellwig wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 284916d..e45776e 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1306,7 +1306,6 @@ struct ib_mr { u64iova; u32