Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-08 Thread Benjamin Herrenschmidt
On Tue, 2013-10-08 at 20:55 -0700, H. Peter Anvin wrote: Why not add a minimum number to pci_enable_msix(), i.e.: pci_enable_msix(pdev, msix_entries, nvec, minvec) ... which means nvec is the number of interrupts *requested*, and minvec is the minimum acceptable number (otherwise fail).

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-07 Thread Benjamin Herrenschmidt
On Mon, 2013-10-07 at 14:01 -0400, Tejun Heo wrote: I don't think the same race condition would happen with the loop. The problem case is where multiple msi(x) allocation fails completely because the global limit went down before inquiry and allocation. In the loop based interface, it'd

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-06 Thread Benjamin Herrenschmidt
On Sun, 2013-10-06 at 08:02 +0200, Alexander Gordeev wrote: On Sun, Oct 06, 2013 at 08:46:26AM +1100, Benjamin Herrenschmidt wrote: On Sat, 2013-10-05 at 16:20 +0200, Alexander Gordeev wrote: So my point is - drivers should first obtain a number of MSIs they *can* get, then *derive

Re: [PATCH RFC 00/77] Re-design MSI/MSI-X interrupts enablement pattern

2013-10-05 Thread Benjamin Herrenschmidt
On Sat, 2013-10-05 at 16:20 +0200, Alexander Gordeev wrote: So my point is - drivers should first obtain a number of MSIs they *can* get, then *derive* a number of MSIs the device is fine with and only then request that number. Not terribly different from memory or any other type of resource

Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver

2013-06-11 Thread Benjamin Herrenschmidt
On Wed, 2013-05-22 at 07:26 -0500, Rob Herring wrote: git://sources.calxeda.com/kernel/linux.git of-platform-removal Ben, Did you have a chance to test this? I want to get this into -next. I tested the one in for-next (sorry for the high latency). Works fine. Ack. Cheers, Ben. -- To

Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver

2013-05-22 Thread Benjamin Herrenschmidt
On Wed, 2013-05-22 at 07:26 -0500, Rob Herring wrote: Did you have a chance to test this? I want to get this into -next. Ah sorry, skipped out of my mind, I'll get to it asap... Cheers, Ben. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver

2013-04-25 Thread Benjamin Herrenschmidt
On Thu, 2013-04-25 at 10:23 -0500, Rob Herring wrote: Ben, Can I have your Ack for this? The change is straightforward and neither of the 2 drivers used the id parameter that is removed. Didn't you get my mail about a compile failure caused by this patch ? Or did you send an update that I

Re: [PATCH 1/5] ibmebus: convert of_platform_driver to platform_driver

2013-04-25 Thread Benjamin Herrenschmidt
On Thu, 2013-04-25 at 14:14 -0500, Rob Herring wrote: On 04/25/2013 12:35 PM, Benjamin Herrenschmidt wrote: On Thu, 2013-04-25 at 10:23 -0500, Rob Herring wrote: Ben, Can I have your Ack for this? The change is straightforward and neither of the 2 drivers used the id parameter

Re: [PATCH 2/2]: Powerpc: Fix EHCA driver on relocatable kernel

2010-08-23 Thread Benjamin Herrenschmidt
On Thu, 2010-08-19 at 23:10 -0500, Sonny Rao wrote: the eHCA driver registers a MR for all of kernel memory, but makes the assumption that valid memory exists at KERNELBASE. This assumption may not be true in the case of a relocatable kernel, so use KERNELBASE + PHYSICAL_START to get the true