RE: [PATCH] iser-target: Handle errors from isert_put_datain and isert_get_dataout

2015-03-09 Thread Chris Moore
> From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > On 3/7/2015 9:19 AM, Nicholas A. Bellinger wrote: > > On Sat, 2015-03-07 at 04:16 +0200, Sagi Grimberg wrote: > >> On 3/6/2015 7:56 PM, Chris Moore wrote: > >>> isert_put_datain() always returns 1 and isert

[PATCH] iser-target: Handle errors from isert_put_datain and isert_get_dataout

2015-03-06 Thread Chris Moore
two functions handle errors from ib_post_send() in the same way as other functions within ib_isert.c Signed-off-by: Chris Moore --- diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert/ib_isert.c index 075b19c..7394ba9 100644 --- a/drivers/infiniband/ulp/isert

RE: [PATCH] IB/isert: Adjust CQ size to HW limits

2014-11-03 Thread Chris Moore
> -Original Message- > From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il] > Sent: Sunday, November 02, 2014 4:37 AM > To: Chris Moore; linux-rdma@vger.kernel.org > Cc: Nicholas A. Bellinger > Subject: Re: [PATCH] IB/isert: Adjust CQ size to HW limits > > On 1

[PATCH] IB/isert: Adjust CQ size to HW limits

2014-10-31 Thread Chris Moore
This is the isert version of the patch that Minh Tran submitted for iser. isert has the same issue of trying to create a CQ with more CQEs than are supported by the hardware. Signed-off-by: Chris Moore --- diff --git a/drivers/infiniband/ulp/isert/ib_isert.c b/drivers/infiniband/ulp/isert

RE: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-30 Thread Chris Moore
> On 10/29/2014 8:05 PM, Chris Moore wrote: > >> On Wed, 2014-10-22 at 12:02 +0300, Or Gerlitz wrote: > >>> On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: > >>>> On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: > >>>>> On Mon, Oct 2

RE: Can someone help me understand the reason for this code in ib_isert.c?

2014-10-29 Thread Chris Moore
> On Wed, 2014-10-22 at 12:02 +0300, Or Gerlitz wrote: > > On 10/22/2014 8:06 AM, Nicholas A. Bellinger wrote: > > > On Tue, 2014-10-21 at 00:13 +0300, Or Gerlitz wrote: > > >> On Mon, Oct 20, 2014 at 6:29 PM, Chris Moore > wrote: > > >>> T

Can someone help me understand the reason for this code in ib_isert.c?

2014-10-20 Thread Chris Moore
The following code is in isert_conn_setup_qp() in ib_isert.c: /* * FIXME: Use devattr.max_sge - 2 for max_send_sge as * work-around for RDMA_READ.. */ attr.cap.max_send_sge = device->dev_attr.max_sge - 2; It's not clear from the comment what this