Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

On Thu, Dec 24, 2015 at 10:25:08AM +0200, Or Gerlitz wrote: > On 12/24/2015 9:31 AM, Faisal Latif wrote: > >On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote: > >>On 12/22/2015 1:13 AM, Faisal Latif wrote: > >>>+ > >>>+enum i40iw_memreg_

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

On Wed, Dec 23, 2015 at 08:39:32AM -0800, Or Gerlitz wrote: > On 12/23/2015 6:35 PM, Faisal Latif wrote: > > I will provide new patch series for latest k.o. Also will make sure of > > shallow threading for the series. > > Please make sure that the cover letter will in

Re: [PATCH V1 08/16] i40iw: add files for iwarp interface

On Wed, Dec 23, 2015 at 08:42:01AM -0800, Or Gerlitz wrote: > On 12/22/2015 1:13 AM, Faisal Latif wrote: > > + > > +enum i40iw_memreg_type { > > + IW_MEMREG_TYPE_MEM = 0x, > > + IW_MEMREG_TYPE_QP = 0x0001, > > + IW_MEMREG_TYPE_CQ = 0x0002, &

Re: [PATCH V1 15/16] i40iw: add entry in rdma_netlink

On Wed, Dec 23, 2015 at 08:50:15AM -0800, Or Gerlitz wrote: > On 12/22/2015 1:13 AM, Faisal Latif wrote: > > Add entry for port mapper services. > > > > Signed-off-by: Faisal Latif <faisal.la...@intel.com> > > --- > > include/uapi/rdma/rdma_netlink.h

Re: [PATCH V1 00/16] add Intel(R) X722 iWARP driver

On Wed, Dec 23, 2015 at 09:05:08AM -0800, Or Gerlitz wrote: > On 12/22/2015 1:13 AM, Faisal Latif wrote: > > This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet > > controller for PCI Physical Functions. > > Is there any public info on the X722, I

[PATCH V1 00/16] add Intel(R) X722 iWARP driver

a driver registration mechanism, resource allocations, and device reset coordination mechanisms. This patch series is based on Doug Ledford's k.o/for-4.5. Anjali Singhai Jain (1) net/ethernet/intel/i40e: Add support for client interface for IWARP driver Faisal Latif(15): infiniband/hw/i40iw

[PATCH V1 14/16] i40iw: Kconfig and Kbuild for iwarp module

Kconfig and Kbuild needed to build iwarp module. Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/Kbuild | 43 + drivers/infiniband/hw/i40iw/Kconfig | 7 ++ 2 files changed, 50 insertions(+) create mode 100644 d

[PATCH V1 02/16] i40iw: add main, hdr, status

com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw.h| 568 + drivers/infiniband/hw/i40iw/i40iw_main.c | 1907 drivers/infiniband/hw/i40iw/i40iw_status.h | 100 ++ 3 files changed, 2575 insertions(+) cr

[PATCH V1 03/16] i40iw: add connection management code

i40iw_cm.c i40iw_cm.h are used for connection management. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw

[PATCH V1 12/16] i40iw: user kernel shared files

i40iw_user.h and i40iw_uk.c are used by both user library as well as kernel requests. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/h

[PATCH V1 15/16] i40iw: add entry in rdma_netlink

Add entry for port mapper services. Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- include/uapi/rdma/rdma_netlink.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h index c19a5dc..4fa418d 100644 --- a/includ

[PATCH V1 01/16] i40e: Add support for client interface for IWARP driver

From: Anjali Singhai Jain This patch adds a Client interface for i40iw driver support. Also expands the Virtchannel to support messages from i40evf driver on behalf of i40iwvf driver. This client API is used by the i40iw and i40iwvf driver to access the core driver

[PATCH V1 05/16] i40iw: add pble resource files

i40iw_pble.[ch] to manage pble resource for iwarp clients. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/

[PATCH V1 13/16] i40iw: virtual channel handling files

i40iw_vf.[ch] and i40iw_virtchnl[ch] are used for virtual channel support for iWARP VF module. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/i

[PATCH V1 09/16] i40iw: add file to handle cqp calls

i40iw_ctrl.c provides for hardware wqe supporti and cqp. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i

[PATCH V1 11/16] i40iw: add X722 register file

X722 Hardware registers defines for iWARP component. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw

[PATCH V1 06/16] i40iw: add hmc resource files

i40iw_hmc.[ch] are to manage hmc for the device. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw

[PATCH V1 07/16] i40iw: add hw and utils files

i40iw_hw.c, i40iw_utils.c and i40iw_osdep.h are files to handle interrupts and processing. Added feeback from Cristoph Hellwig. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.

[PATCH V1 04/16] i40iw: add puda code

i40iw_puda.[ch] are files to handle iwarp connection packets as well as exception packets over multiple privilege mode uda queues. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.

[PATCH V1 16/16] i40iw: changes for build of i40iw module

MAINTAINERS, Kconfig, and Makefile to build i40iw module Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- MAINTAINERS| 10 ++ drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + 3 files changed, 12 insertions(+) diff

[PATCH V1 08/16] i40iw: add files for iwarp interface

i40iw_verbs.[ch] are to handle iwarp interface. Added feedback provided by Christoph Hellwig Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/i

[PATCH V1 10/16] i40iw: add hardware related header files

header files for hardware accesses Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw_d.h| 1713 ++ drivers/infiniband/hw/i40iw/i40iw_p.h| 106 ++ drivers/infiniband/hw/i40iw/i40iw_type.h

[PATCH 02/15] i40iw: add main, hdr, status

com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw.h| 573 + drivers/infiniband/hw/i40iw/i40iw_main.c | 1905 drivers/infiniband/hw/i40iw/i40iw_status.h | 100 ++ 3 files changed, 2578 insertions(+) cr

[PATCH 04/15] i40iw: add puda code

i40iw_puda.[ch] are files to handle iwarp connection packets as well as exception packets over multiple privilege mode uda queues. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.

[PATCH 01/15] i40e: Add support for client interface for IWARP driver

From: Anjali Singhai Jain This patch adds a Client interface for i40iw driver support. Also expands the Virtchannel to support messages from i40evf driver on behalf of i40iwvf driver. This client API is used by the i40iw and i40iwvf driver to access the core driver

[PATCH 09/15] i40iw: add file to handle cqp calls

i40iw_ctrl.c provides for hardware wqe supporti and cqp. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i

[PATCH 08/15] i40iw: add files for iwarp interface

i40iw_verbs.[ch] are to handle iwarp interface. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw_ucontext.h | 110 ++ dri

[PATCH 15/15] i40iw: changes for build of i40iw module

IAINTAINERS< Kconfig, Makefile and rdma_netlink.h to include i40iw Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- MAINTAINERS | 10 ++ drivers/infiniband/Kconfig | 1 + drivers/infiniband/hw/Makefile | 1 + include/uapi/rdma/rdma_netli

[PATCH 13/15] i40iw: virtual channel handling files

i40iw_vf.[ch] and i40iw_virtchnl[ch] are used for virtual channel support for iWARP VF module. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/i

[PATCH 14/15] i40iw: Kconfig and Kbuild for iwarp module

Kconfig and Kbuild needed to build iwarp module. Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/Kbuild | 43 + drivers/infiniband/hw/i40iw/Kconfig | 7 ++ 2 files changed, 50 insertions(+) create mode 100644 d

[PATCH 05/15] i40iw: add pble resource files

i40iw_pble.[ch] to manage pble resource for iwarp clients. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/

[PATCH 12/15] i40iw: user kernel shared files

i40iw_user.h and i40iw_uk.c are used by both user library as well as kernel requests. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/h

[PATCH 06/15] i40iw: add hmc resource files

i40iw_hmc.[ch] are to manage hmc for the device. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw

[PATCH 11/15] i40iw: add X722 register file

X722 Hardware registers defines for iWARP component. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw

[PATCH 07/15] i40iw: add hw and utils files

i40iw_hw.c, i40iw_utils.c and i40iw_osdep.h are files to handle interrupts and processing. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/h

[PATCH 03/15] i40iw: add connection management code

i40iw_cm.c i40iw_cm.h are used for connection management. Acked-by: Anjali Singhai Jain <anjali.sing...@intel.com> Acked-by: Shannon Nelson <shannon.nel...@intel.com> Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw

[PATCH 10/15] i40iw: add hardware related header files

header files for hardware accesses Signed-off-by: Faisal Latif <faisal.la...@intel.com> --- drivers/infiniband/hw/i40iw/i40iw_d.h| 1713 ++ drivers/infiniband/hw/i40iw/i40iw_p.h| 106 ++ drivers/infiniband/hw/i40iw/i40iw_type.h

[PATCH 00/15] add Intel(R) X722 iWARP driver

. This patch series is based on Doug Ledford's /github.com/dledford/linux.git Anjali Singhai Jain (1) net/ethernet/intel/i40e: Add support for client interface for IWARP driver Faisal Latif(14): infiniband/hw/i40iw: add main, hdr, status infiniband/hw/i40iw: add connection management code infiniband/hw

[PATCH] RDMA/nes: ip address print changes

Fix printing of ip addresses to use %pI4. Reported-by: Roland Dreier rol...@purestorage.com Signed-off-by: Tatyana Nikolova tatyana.e.nikol...@intel.com Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c | 96 +++- drivers

[PATCH 1/3] RDMA/nes: Fix terminate connection

Fixes a crash that occurs during close when error async event is received. Terminate message is not sent to the remote node if already processing close. Signed-off-by: Tatyana Nikolova tatyana.e.nikol...@intel.com Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes

[PATCH 2/3] RDMA/nes: Print ip address for critcal errors

Prints the IP address of the remote host when critical asynchronous event is received. Signed-off-by: Tatyana Nikolova tatyana.e.nikol...@intel.com Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_hw.c | 10 ++ 1 files changed, 10 insertions(+), 0

[PATCH] RDMA/nes: Modified FIN handling causes hang in A0 cards

The changing state to CLOSING when FIN is received causes A0 cards to hang and the interface will not be active. Now in the FIN handling, a check is made if it is A0 card or not. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_hw.c |3 ++- drivers

[PATCH] RDMA/nes: double CLOSE event indication crash

for MPA response from user. When MPA accept is receives, the driver send offloads the connection and sends CLOSE event. The driver get an AE indicating RESET receive and also send CLOSE event causing BUG() to hit in the core. RESET handling and sending CLOSE events are fixed. Signed-off-by: Faisal Latif

[PATCH] RDMA/nes: change state to closing after FIN

When driver receives an AE for FIN receive indication, it closes the connection without changing the state of the connection in the hardware to closing. By changing the state to closing, hardware will do normal close sequence. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers

[PATCH] RDMA/nes: Sometimes ifdown command hangs

When ib_unregister_device() is called from netdev stop during ifdown, it sometimes hangs. Changes made to indicate port_err to ib_dispatch_event() during netdev stop and port_active during netdev open. The ib_unregister_device() is only called during remove of the module. Signed-off-by: Faisal

[PATCH] RDMA/nes: ethtool read hardware registers for rx/tx stats

Enhance ethtool to read hardware registers for rcv/tx error stats. Also added support for free pbl resources and remove cq depth stats which are not used. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_nic.c | 72 ++ 1 files

[PATCH] RDMA/nes: AE for closed QP causes crash

Under abnormal termination, modify_qp() closes qp and AE handling also attempts to close qp causing system to crash. Now we check the state of QP before processing the AE. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_hw.c |9 + 1 files changed

[PATCH] RDMA/nes: ethtool to read hardware registers for Rx/Tx error stats

Enhance ethtool to read hardware registers for rcv/tx error stats. Also added support for free pbl resources and remoce cq depth stats which are not used. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_nic.c | 72 ++ 1 files

[PATCH v2] RDMA/nes: set assume_alligned_header bit

set assume_alligned_header bit set in qp context as requested by hardware group. Signed-off-by: Faisal Latif faisal.la...@intel.com --- v2 change: As recommended by Roland, Combine NES_QPCONTEXT_ORDIRD_AAH with the NES_QPCONTEXT_ORDIRD_ALSMM for ird_ord_sizes. drivers/infiniband/hw/nes

[PATCH] rdma/nes: set assume_alligned_header bit

set assume bit alligned bit in qp context as recommended by hardware group. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_verbs.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_verbs.c b/drivers

[PATCH 01/02] RDMA/nes: atomic counters for cm listener create and destroy

Running long hour iterative MPI tests, sometimes ethtool statistics CM Destroy Listener count is more than CM Create Listener. This inconsistency is fixed by making counter variable atomic. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes.h |4

[PATCH 02/02] RDMA/nes: listener destroyed during loopback setup crash

When listener is destroyed and where is MPA response pending for loopback connection, the active side cm_node gets destroyed in cm_event_connect_error() and again in nes_accept()/nes_reject(). Incrementing cm_node's refcount to not be destroyed by cm_event_connect_error(). Signed-off-by: Faisal

[PATCH 01/11] RDMA/nes: change MAX_CM_BUFFER define

Changed MAX_CM_BUFFER for MPA frame to be conformant to RFC 5044. This will change it to 512 + 20 instead of 512. Signed-off-by: Faisal Latif faisal.la...@intel.com diff --git a/drivers/infiniband/hw/nes/nes_cm.h b/drivers/infiniband/hw/nes/nes_cm.h index 90e8e4d..2d867a6 100644

[PATCH 01/11] RDMA/nes: change MAX_CM_BUFFER define

Changed MAX_CM_BUFFER for MPA frame to be conformant to RFC 5044. This will change it to 512 + 20 instead of 512. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.h |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers

[PATCH 02/11] RDMA/nes: fix query of ORD values

The ORD size needs updating as we are supporting more inbound READ resources per connection. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_verbs.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/nes

[PATCH 03/11] RDMA/nes: MPA request/response error checking

During Xansation testing, error handling of MPA frame msg/response is not handled properly. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c | 31 +-- 1 files changed, 29 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 04/11] RDMA/nes: Resource not freed for REJECT connection

During testing of REJECT connection error handling, the cm_id resources are not release. When retransmit timer expires, need to send reset message to remote node before sending ABORTED event. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c |2 ++ 1

[PATCH 05/11] RDMA/nes: crash in nes_accept

is NES_CM_STATE_MPAREQ_RCVD then its new state is set to NES_CM_STATE_LISTENER_DESTROYED and it is not freed. When nes_accept() or nes_reject() is received, its state is checked for NES_CM_STATE_LISTENER_DESTROYED and in this case the cm_node is freed and error is returned. Signed-off-by: Faisal Latif

[PATCH 06/11] RDMA/nes: abnormal listener termination causes loopback node crash

-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c | 16 +++- 1 files changed, 3 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index ec04786..20e21f1 100644 --- a/drivers

[PATCH 08/11] RDMA/nes: check for zero stag

STags are generated randomly but the driver does not correctly prevent a zero STag. Using STag zero is privileged and causes a user space application to fail. This change prevents the driver from trying to allocate a zero STag. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers

[PATCH 10/11] RDMA/nes: FIN during MPA startup causes timeout

...@intel.com Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c |9 - 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index b139806..4acf04a 100644 --- a/drivers

[PATCH 11/11] RDMA/nes: stale arp issue fix

is same as in system. Signed-off-by: Faisal Latif faisal.la...@intel.com --- drivers/infiniband/hw/nes/nes_cm.c | 45 +-- 1 files changed, 32 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/hw/nes/nes_cm.c b/drivers/infiniband/hw/nes/nes_cm.c index