[PATCH linux-next v5] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-15 Thread Honggang Li
- cosnole log - Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') Signed-off-by: Honggang Li --- .../net/ethernet/mellanox/mlx5/core/pagealloc.c| 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/

Re: [PATCH linux-next v4] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-15 Thread Honggang LI
On Wed, Apr 15, 2015 at 10:11:51AM +0300, Or Gerlitz wrote: > On 4/15/2015 9:21 AM, Honggang Li wrote: > >Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size > >to firmware') > > > >Signed-off-by: Honggang Li > ain't over...

[PATCH linux-next v3] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-15 Thread Honggang Li
7;s comment. ere...@dev.mellanox.co.il Fixes: 5aa7add8f14b ("infiniband/ipoib: implement ndo_get_iflink") Signed-off-by: Honggang Li --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/ulp/

Re: [PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-15 Thread Honggang LI
On Wed, Apr 15, 2015 at 08:27:23AM +0300, Or Gerlitz wrote: > On 4/15/2015 6:19 AM, Honggang Li wrote: > >Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) > > This isn't the way to write the fix note, do it that way > > Fixes: bf

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-15 Thread Honggang LI
On Tue, Apr 14, 2015 at 07:30:03PM +0300, Erez Shitrit wrote: > > @@ -846,7 +846,10 @@ static int ipoib_get_iflink(const struct net_device > > *dev) > > { > > struct ipoib_dev_priv *priv = netdev_priv(dev); > > > > - return priv->parent->ifindex; > > + if (priv && priv->parent

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang LI
There was network accident in the office. I can't find this email in public mailing list. So, I reset it. If you had recived this, please ignore it. thanks On Wed, Apr 15, 2015 at 01:16:40PM +0800, Honggang LI wrote: > On Tue, Apr 14, 2015 at 07:30:03PM +0300, Erez Shitr

[PATCH linux-next v4] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang Li
- cosnole log - Fixes: bf0bf77f6519 ('mlx5: Support communicating arbitrary host page size to firmware') Signed-off-by: Honggang Li --- drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/

[PATCH linux-next v3] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang Li
- cosnole log - Fix(bf0bf77 mlx5: Support communicating arbitrary host page size to firmware) Signed-off-by: Honggang Li --- .../net/ethernet/mellanox/mlx5/core/pagealloc.c| 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx

Re: [PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 10:23:16PM +0300, Eli Cohen wrote: > On Mon, Apr 13, 2015 at 05:21:58PM +0800, Honggang Li wrote: > > @@ -241,7 +243,7 @@ static void free_4k(struct mlx5_core_dev *dev, u64 addr) > > static int alloc_system_page(struct mlx5_core_dev *dev, u16 func_id) > &

[PATCH] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang Li
;8b> 80 20 01 00 00 c9 c3 0f 1f 84 00 00 00 00 00 55 48 89 e5 66 RIP [] ipoib_get_iflink+0x10/0x20 [ib_ipoib] RSP CR2: 0120 ---[ end trace a8610f6e9640eb85 ]--- Fixes: 5aa7add8f14b ("infiniband/ipoib: implement ndo_get_iflink") Signed-off-by: Honggang Li --- dr

[PATCH linux-next v2] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang Li
f88026eb1c7c0, priv->parent = (null) ipoib_get_iflink dev = 880225c8a000, priv = 880225c8a7c0, priv->parent = (null) ipoib_get_iflink dev = 880225c8a000, priv = 880225c8a7c0, priv->parent = (null) ----- console log --- Hong

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 05:49:55PM +0200, Nicolas Dichtel wrote: > Le 14/04/2015 17:44, Honggang LI a écrit : > >On Tue, Apr 14, 2015 at 08:34:33AM -0700, Eric Dumazet wrote: > >>On Tue, 2015-04-14 at 23:20 +0800, Honggang Li wrote: > >>>Starting monitoring for VG v

Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 05:37:57PM +0200, Andrew Lunn wrote: > > > > > And I suspect that it is the same for ipvlan and dsa. > > I agree about DSA. I don't see any way this could happen. > > Andrew I only keep the ipoib patch and drop the rest patches. thanks -- To unsubscribe from this list:

Re: [PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 08:34:33AM -0700, Eric Dumazet wrote: > On Tue, 2015-04-14 at 23:20 +0800, Honggang Li wrote: > > Starting monitoring for VG vg_rdma01: 3 logical volume(s) in volume > > group "vg_rdma01" monitored > > [ OK ] > > > &g

Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Honggang LI
On Tue, Apr 14, 2015 at 04:26:27PM +0100, Patrick McHardy wrote: > > That is completely useless. vlan (=netdev_priv) can not be NULL as > netdev_priv() never returns NULL and vlan->lowerdev is always valid > because a macvlan wouldn't make much sense otherwise. OK, please drop this patch. thanks

[PATCH linux-next 2/4] ipvlan: fix possible NULL pointer dereference in ipvlan_get_iflink

2015-04-14 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/net/ipvlan/ipvlan_main.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c index 77b92a0..479fcf7 100644 --- a/drivers/net/ipvlan/ipvlan_main.c +++ b/drivers/net

[PATCH linux-next 1/4] infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink

2015-04-14 Thread Honggang Li
;8b> 80 20 01 00 00 c9 c3 0f 1f 84 00 00 00 00 00 55 48 89 e5 66 RIP [] ipoib_get_iflink+0x10/0x20 [ib_ipoib] RSP CR2: 0120 ---[ end trace a8610f6e9640eb85 ]--- Signed-off-by: Honggang Li --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 5 - 1 file changed, 4 insertion

[PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Honggang Li
Signed-off-by: Honggang Li --- drivers/net/macvlan.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c index b227a13..1e59f39 100644 --- a/drivers/net/macvlan.c +++ b/drivers/net/macvlan.c @@ -998,7 +998,9 @@ static int

[PATCH linux-next 4/4] net/dsa: fix possible NULL pointer dereference in dsa_slave_get_iflink

2015-04-14 Thread Honggang Li
Signed-off-by: Honggang Li --- net/dsa/slave.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/net/dsa/slave.c b/net/dsa/slave.c index 827cda56..070b599 100644 --- a/net/dsa/slave.c +++ b/net/dsa/slave.c @@ -59,7 +59,10 @@ static int dsa_slave_get_iflink(const struct

[PATCH linux-next 0/4] fix possile NULL pointer dereference in ndo_get_iflink callback functions

2015-04-14 Thread Honggang Li
single patch. However, those files have be maintained by different maintainers. So, I split it for review. It also will be convenient to remove one or more patches with the rest not be affected. Honggang Li (4): infiniband/ipoib: fix possible NULL pointer dereference in ipoib_get_iflink ipvlan

[PATCH linux-next v2] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-13 Thread Honggang Li
- cosnole log - Signed-off-by: Honggang Li --- drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c i

Re: [linux-next PATCH] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-13 Thread Honggang LI
On Mon, Apr 13, 2015 at 06:47:11AM +, Eli Cohen wrote: > On Mon, Apr 13, 2015 at 08:33:33AM +0800, Honggang LI wrote: > > > > Yes, replaced all of the PAGE_MASK in the file. Please see attched new > > patch. > > > > I think you need to send the new patch

Re: [linux-next PATCH] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-12 Thread Honggang LI
UM_4K_IN_PAGE, will reserve the high four bytes. So, free_4k/find_fw_page will randomly failed. thanks > int err; > int nid = dev_to_node(&dev->pdev->dev); > > -- > 1.8.3.1 > >From 393cfb80c10e8e3a89baf7d235dde7aa3c64837d Mon Sep 17 00:00:00 2001 From:

[linux-next PATCH] mlx5: wrong page mask if CONFIG_ARCH_DMA_ADDR_T_64BIT enabled for 32Bit architectures

2015-04-12 Thread Honggang Li
- cosnole log - Signed-off-by: Honggang Li --- drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c index df