[PATCH] IB/sysfs: Fix sparse warning on attr_id

2016-01-03 Thread ira . weiny
From: Ira Weiny Attributed ID was declared as an int while the value should really be big endian 16. Fixes: 35c4cbb17811 ("IB/core: Create get_perf_mad function in sysfs.c") Reported-by: Bart Van Assche Signed-off-by: Ira Weiny --- drivers/infiniband/core/sysfs.c | 4 ++-- 1 file

[PATCH V5 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

2015-12-21 Thread ira . weiny
From: Ira Weiny This was a single patch before. The change to dev_dbg required a precursor patch to add the dd_dev_dbg which is consistent with the other dev_* macros which automatically use struct hfi1_devdata. Changes from V4: Fix build error which arose from other patches being

[PATCH V5 1/2] staging/rdma/hfi1: add dd_dev_dbg

2015-12-21 Thread ira . weiny
From: Ira Weiny To be used in future patches add dd_dev_dbg. dd_* functions properly decode the hfi1_devdata structure used throughout the driver Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/hfi.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rdma/hfi1

[PATCH V5 2/2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-12-21 Thread ira . weiny
From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- Changes from V1: Add comments concerning the very

[PATCH v2 10/14] staging/rdma/hfi1: Add Expected receive init and free functions

2015-12-17 Thread ira . weiny
. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 154 +-- 1 file changed, 144 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rdma/hfi1/user_exp_rcv.c b/drivers/staging/rdma/hfi1/user_exp_rcv.c index

[PATCH v2 07/14] staging/rdma/hfi1: Add definitions and support functions for TID groups

2015-12-17 Thread ira . weiny
buffer. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 64 1 file changed, 64 insertions(+) diff --git a/drivers/staging/rdma/hfi1/user_exp_rcv.c b/drivers/staging/rdma/hfi1/user_exp_rcv.c index bafeddf67c8f

[PATCH v2 09/14] staging/rdma/hfi1: Convert lock to mutex

2015-12-17 Thread ira . weiny
From: Mitko Haralanov The exp_lock lock does not need to be a spinlock as all its uses are in process context and allowing the process to sleep when the mutex is contended might be benefitial. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 12

[PATCH v2 06/14] staging/rdma/hfi1: Remove un-needed variable

2015-12-17 Thread ira . weiny
From: Mitko Haralanov There is no need to use a separate variable for a return value and a label when returning right away would do just as well. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 11 --- 1 file changed, 4 insertions

[PATCH v2 13/14] staging/rdma/hfi1: Add TID entry program function body

2015-12-17 Thread ira . weiny
Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 263 ++- 1 file changed, 259 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/hfi1/user_exp_rcv.c b/drivers/staging/rdma/hfi1/user_exp_rcv.c index 776ce003248e..d33f579675b7 10

[PATCH v2 14/14] staging/rdma/hfi1: Enable TID caching feature

2015-12-17 Thread ira . weiny
used other complications and ugliness. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 448 +++ drivers/staging/rdma/hfi1/hfi.h | 14 - drivers/staging/rdma/hfi1/init.c | 3 - drivers/staging/rdma/hf

[PATCH v2 01/14] staging/rdma/hfi1: Add function stubs for TID caching

2015-12-17 Thread ira . weiny
use of these functions. Signed-off-by: Mitko Haralanov Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/Kconfig| 1 + drivers/staging/rdma/hfi1/Makefile | 2 +- drivers/staging/rdma/hfi1/hfi.h | 4 + drivers/staging/rdma/hfi1/user_exp_rcv.c | 264

[PATCH v2 02/14] uapi/rdma/hfi/hfi1_user.h: Correct comment for capability bit

2015-12-17 Thread ira . weiny
From: Mitko Haralanov The HFI1_CAP_TID_UNMAP comment was incorrectly implying the opposite of what capability actually did. Correct this error. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- include/uapi/rdma/hfi/hfi1_user.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH v2 05/14] staging/rdma/hfi1: Add definitions needed for TID caching support

2015-12-17 Thread ira . weiny
From: Mitko Haralanov In preparation for adding the TID caching support, there is a set of headers, structures, and variables which will be needed. This commit adds them to the hfi.h header file. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/hfi.h | 20

[PATCH v2 08/14] staging/rdma/hfi1: Start adding building blocks for TID caching

2015-12-17 Thread ira . weiny
e RcvArray group entries with these physical chunks, and unprogram the RcvArray groups. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- Changes from V1: Add comment to program_rcvarray Fix >= on tididx drivers/staging/rdma/hfi1/user_ex

[PATCH v2 11/14] staging/rdma/hfi1: Add MMU notifier callback function

2015-12-17 Thread ira . weiny
currently unused and is being added in preparation for the TID caching feature. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 67 +++- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH v2 03/14] uapi/rdma/hfi/hfi1_user.h: Convert definitions to use BIT() macro

2015-12-17 Thread ira . weiny
From: Mitko Haralanov Convert bit definitions to use BIT() macro as per checkpatch.pl requirements. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- include/uapi/rdma/hfi/hfi1_user.h | 56 +++ 1 file changed, 28 insertions(+), 28 deletions

[PATCH v2 00/14] Implement Expected Receive TID Caching

2015-12-17 Thread ira . weiny
From: Ira Weiny Expected receives work by user-space libraries (PSM) calling into the driver with information about the user's receive buffer and have the driver DMA-map that buffer and program the HFI to receive data directly into it. This is an expensive operation as it requires the driv

[PATCH v2 12/14] staging/rdma/hfi1: Add TID free/clear function bodies

2015-12-17 Thread ira . weiny
done on purpose to help with patch reviews as the programming code path is much longer. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 91 +--- 1 file changed, 85 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH v2 04/14] uapi/rdma/hfi/hfi1_user.h: Add command and event for TID caching

2015-12-17 Thread ira . weiny
switch() statement in file_ops.c for completeness and in preparation for its usage later. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 1 + include/uapi/rdma/hfi/hfi1_user.h| 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff

[PATCH 14/14] staging/rdma/hfi1: Enable TID caching feature

2015-12-16 Thread ira . weiny
used other complications and ugliness. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/file_ops.c | 448 +++ drivers/staging/rdma/hfi1/hfi.h | 14 - drivers/staging/rdma/hfi1/init.c | 3 - drivers/staging/rdma/hf

[PATCH 13/14] staging/rdma/hfi1: Add TID entry program function body

2015-12-16 Thread ira . weiny
e RcvArray entries in the hardware. With this function, the TID caching functionality is implemented. However, it is still unused. The switch will come in a later patch in the series, which will remove the old functionality and switch the driver over to TID caching. Reviewed-by: Ira Weiny Sig

[PATCH 11/14] staging/rdma/hfi1: Add MMU notifier callback function

2015-12-16 Thread ira . weiny
currently unused and is being added in preparation for the TID caching feature. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 67 +++- 1 file changed, 65 insertions(+), 2 deletions(-) diff --git a/drivers/staging

[PATCH 10/14] staging/rdma/hfi1: Add Expected receive init and free functions

2015-12-16 Thread ira . weiny
. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 154 +-- 1 file changed, 144 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rdma/hfi1/user_exp_rcv.c b/drivers/staging/rdma/hfi1/user_exp_rcv.c index

[PATCH 12/14] staging/rdma/hfi1: Add TID free/clear function bodies

2015-12-16 Thread ira . weiny
done on purpose to help with patch reviews as the programming code path is much longer. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 91 +--- 1 file changed, 85 insertions(+), 6 deletions(-) diff --git a/drivers

[PATCH 02/14] uapi/rdma/hfi/hfi1_user.h: Correct comment for capability bit

2015-12-16 Thread ira . weiny
From: Mitko Haralanov The HFI1_CAP_TID_UNMAP comment was incorrectly implying the opposite of what capability actually did. Correct this error. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- include/uapi/rdma/hfi/hfi1_user.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[PATCH 06/14] staging/rdma/hfi1: Remove un-needed variable

2015-12-16 Thread ira . weiny
From: Mitko Haralanov There is no need to use a separate variable for a return value and a label when returning right away would do just as well. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/file_ops.c | 11 --- 1 file changed, 4 insertions

[PATCH 05/14] staging/rdma/hfi1: Add definitions needed for TID caching support

2015-12-16 Thread ira . weiny
From: Mitko Haralanov In preparation for adding the TID caching support, there is a set of headers, structures, and variables which will be needed. This commit adds them to the hfi.h header file. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/hfi.h | 20

[PATCH 07/14] staging/rdma/hfi1: Add definitions and support functions for TID groups

2015-12-16 Thread ira . weiny
buffer. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 64 1 file changed, 64 insertions(+) diff --git a/drivers/staging/rdma/hfi1/user_exp_rcv.c b/drivers/staging/rdma/hfi1/user_exp_rcv.c index bafeddf67c8f

[PATCH 09/14] staging/rdma/hfi1: Convert lock to mutex

2015-12-16 Thread ira . weiny
From: Mitko Haralanov The exp_lock lock does not need to be a spinlock as all its uses are in process context and allowing the process to sleep when the mutex is contended might be benefitial. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/file_ops.c | 12

[PATCH 08/14] staging/rdma/hfi1: Start adding building blocks for TID caching

2015-12-16 Thread ira . weiny
e RcvArray group entries with these physical chunks, and unprogram the RcvArray groups. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_exp_rcv.c | 310 +++ 1 file changed, 310 insertions(+) diff --git a/drivers/staging

[PATCH 01/14] staging/rdma/hfi1: Add function stubs for TID caching

2015-12-16 Thread ira . weiny
use of these functions. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/Kconfig| 1 + drivers/staging/rdma/hfi1/Makefile | 2 +- drivers/staging/rdma/hfi1/hfi.h | 4 + drivers/staging/rdma/hfi1/user_exp_rcv.c | 264

[PATCH 03/14] uapi/rdma/hfi/hfi1_user.h: Convert definitions to use BIT() macro

2015-12-16 Thread ira . weiny
From: Mitko Haralanov Convert bit definitions to use BIT() macro as per checkpatch.pl requirements. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- include/uapi/rdma/hfi/hfi1_user.h | 56 +++ 1 file changed, 28 insertions(+), 28 deletions

[PATCH 00/14] Implement Expected Receive TID Caching

2015-12-16 Thread ira . weiny
From: Ira Weiny Expected receives work by user-space libraries (PSM) calling into the driver with information about the user's receive buffer and have the driver DMA-map that buffer and program the HFI to receive data directly into it. This is an expensive operation as it requires the driv

[PATCH 04/14] uapi/rdma/hfi/hfi1_user.h: Add command and event for TID caching

2015-12-16 Thread ira . weiny
switch() statement in file_ops.c for completeness and in preparation for its usage later. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/file_ops.c | 1 + include/uapi/rdma/hfi/hfi1_user.h| 5 - 2 files changed, 5 insertions(+), 1 deletion(-) diff

[PATCH] IB/mad: Ensure fairness in ib_mad_completion_handler

2015-12-10 Thread ira . weiny
recv queue size. However, it was kept fixed such that increasing those queue sizes would not adversely affect fairness in the future. Reviewed-by: Ira Weiny Signed-off-by: Dean Luick --- drivers/infiniband/core/mad.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers

[PATCH v2 5/5] staging/rdma/hfi1: Add page lock limit check for SDMA requests

2015-12-08 Thread ira . weiny
necessary to put all the completed SDMA tx requests onto a separate list (txcmp) and offload the actual clean-up and unpinning work to a workqueue. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- Changes from V1: Fix off by 1 error drivers

[PATCH v2 4/5] staging/rdma/hfi1: Detect SDMA transmission error early

2015-12-08 Thread ira . weiny
From: Mitko Haralanov It is possible for an SDMA transmission error to happen during the processing of an user SDMA transfer. In that case it is better to detect it early and abort any further attempts to send more packets. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers

[PATCH v2 3/5] staging/rdma/hfi1: Clean-up unnecessary goto statements

2015-12-08 Thread ira . weiny
From: Mitko Haralanov Clean-up unnecessary goto statements based on feedback from the mailing list on previous patch submissions. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_sdma.c | 37 +-- 1 file changed, 14

[PATCH v2 2/5] staging/rdma/hfi1: Unconditionally clean-up SDMA queues

2015-12-08 Thread ira . weiny
From: Mitko Haralanov There is no need to cleck if the packet queue is allocated when cleaning up a user context. The hfi1_user_sdma_free_queues() function already does all the required checks. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/file_ops.c | 3

[PATCH v2 0/5] Clean up SDMA engine code

2015-12-08 Thread ira . weiny
From: Ira Weiny Various improvements to the SDMA engine code. --- Changes from V1: Fix off by one error in the last patch Mitko Haralanov (5): staging/rdma/hfi1: Convert to use get_user_pages_fast staging/rdma/hfi1: Unconditionally clean-up SDMA queues staging/rdma/hfi1: Clean-up

[PATCH v2 1/5] staging/rdma/hfi1: Convert to use get_user_pages_fast

2015-12-08 Thread ira . weiny
From: Mitko Haralanov Convert hfi1_get_user_pages() to use get_user_pages_fast(), which is much fatster. The mm semaphore is still taken to update the pinned page count but is for a much shorter amount of time. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma

[PATCH 0/5] staging/rdma/hfi1: Clean up SDMA engine code

2015-12-02 Thread ira . weiny
From: Ira Weiny Various improvements to the SDMA engine code. Mitko Haralanov (5): staging/rdma/hfi1: Convert to use get_user_pages_fast staging/rdma/hfi1: Unconditionally clean-up SDMA queues staging/rdma/hfi1: Clean-up unnecessary goto statements staging/rdma/hfi1: Detect SDMA

[PATCH 3/5] staging/rdma/hfi1: Clean-up unnecessary goto statements

2015-12-02 Thread ira . weiny
From: Mitko Haralanov Clean-up unnecessary goto statements based on feedback from the mailing list on previous patch submissions. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_sdma.c | 37 +-- 1 file changed, 14

[PATCH 4/5] staging/rdma/hfi1: Detect SDMA transmission error early

2015-12-02 Thread ira . weiny
From: Mitko Haralanov It is possible for an SDMA transmission error to happen during the processing of an user SDMA transfer. In that case it is better to detect it early and abort any further attempts to send more packets. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers

[PATCH 2/5] staging/rdma/hfi1: Unconditionally clean-up SDMA queues

2015-12-02 Thread ira . weiny
From: Mitko Haralanov There is no need to cleck if the packet queue is allocated when cleaning up a user context. The hfi1_user_sdma_free_queues() function already does all the required checks. Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/file_ops.c | 3

[PATCH 5/5] staging/rdma/hfi1: Add page lock limit check for SDMA requests

2015-12-02 Thread ira . weiny
necessary to put all the completed SDMA tx requests onto a separate list (txcmp) and offload the actual clean-up and unpinning work to a workqueue. Reviewed-by: Dennis Dalessandro Reviewed-by: Ira Weiny Signed-off-by: Mitko Haralanov --- drivers/staging/rdma/hfi1/user_sdma.c | 279

[PATCH 1/5] staging/rdma/hfi1: Convert to use get_user_pages_fast

2015-12-02 Thread ira . weiny
From: Mitko Haralanov Convert hfi1_get_user_pages() to use get_user_pages_fast(), which is much fatster. The mm semaphore is still taken to update the pinned page count but is for a much shorter amount of time. Signed-off-by: Mitko Haralanov Reviewed-by: Ira Weiny --- drivers/staging/rdma

[PATCH v3 01/13] staging/rdma/hfi1: diag.c use BIT macros

2015-12-01 Thread ira . weiny
From: Ira Weiny Use BIT macros rather than shifts. Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1/diag.c index 0aaad7412842..8faad4556ae1 100644

[PATCH v3 07/13] staging/rdma/hfi1: diag.c correct sizeof parameter

2015-12-01 Thread ira . weiny
From: Ira Weiny sizeof should use the variable rather than the struct definition to ensure that type changes are properly accounted for. Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rdma/hfi1

[PATCH v3 03/13] staging/rdma/hfi1: diag.c fix logical continuations

2015-12-01 Thread ira . weiny
From: Ira Weiny Place logical operators at the end of the previous line when using a multi-line statement. Found by checkpatch --strict Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rdma

[PATCH v3 00/13] Fix hfi1_ioctl locking

2015-12-01 Thread ira . weiny
From: Ira Weiny It was identified that hfi1_ioctl may sleep with a spin lock held. This was identified publicly here: http://www.spinics.net/lists/linux-rdma/msg29926.html As well as by our internal development. This series cleans up the code and parameter checks, as well as fixing the

[PATCH v3 04/13] staging/rdma/hfi1: diag.c fix white space errors

2015-12-01 Thread ira . weiny
From: Ira Weiny Add or remove whitespace according to checkpatch --strict Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 30 ++ 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma

[PATCH v3 10/13] staging/rdma/hfi1: hfi1_ioctl remove setlink state

2015-12-01 Thread ira . weiny
From: Ira Weiny Set link state is not supported remove from the switch statement and allow the default to return -ENOTTY Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from v1: Just remove the check for SETLINKSTATE and allow the switch to default to

[PATCH v3 09/13] staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors

2015-12-01 Thread ira . weiny
From: Ira Weiny Rather than have a switch in a large else clause make the parameter checks return immediately. Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 348 +++ 1 file changed, 173 insertions(+), 175

[PATCH v3 08/13] staging/rdma/hfi1: Fix camel case variables

2015-12-01 Thread ira . weiny
From: Ira Weiny physState, linkState, and devState should be phys_state, link_state, and dev_state Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a

[PATCH v3 05/13] staging/rdma/hfi1: diag.c change null comparisons

2015-12-01 Thread ira . weiny
From: Ira Weiny Use !foo rather than (foo == NULL) as recommended by checkpatch --strict Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging

[PATCH v3 12/13] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.

2015-12-01 Thread ira . weiny
-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from V1: Adjust to add the done label which can't be removed until a later patch Removed SETLINKSTATE drivers/staging/rdma/hfi1/diag.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH v3 06/13] staging/rdma/hfi1: diag.c add missing braces

2015-12-01 Thread ira . weiny
From: Ira Weiny Else statements should continue using braces even if there is only 1 line in the block. Found by checkpatch --strict Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rdma

[PATCH v3 13/13] staging/rdma/hfi1: Return immediately on error

2015-12-01 Thread ira . weiny
From: Dennis Dalessandro Now that the spinlock is not taken throughout hfi1_ioctl it is safe to return early rather than setting a variable and falling through the switch. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from V1

[PATCH v3 02/13] staging/rdma/hfi1: diag.c fix alignment

2015-12-01 Thread ira . weiny
From: Ira Weiny Fix line alignment in various places as caught by checkpatch --strict. Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma

[PATCH v3 11/13] staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks

2015-12-01 Thread ira . weiny
From: Ira Weiny Final clean up of the if/then/else clause for the parameter checks of hfi1_ioctl Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from v1: SETLINKSTATE is removed drivers/staging/rdma/hfi1/diag.c | 23 +-- 1 file changed, 13

[PATCH v4 0/2] staging/rdma/hfi1: set Gen 3 half-swing for integrated devices.

2015-12-01 Thread ira . weiny
From: Ira Weiny This was a single patch before. The change to dev_dbg required a precursor patch to add the dd_dev_dbg which is consistent with the other dev_* macros which automatically use struct hfi1_devdata. Dean Luick (1): staging/rdma/hfi1: set Gen3 half-swing for integrated devices

[PATCH v4 1/2] staging/rdma/hf1: add dd_dev_dbg

2015-12-01 Thread ira . weiny
From: Ira Weiny To be used in future patches add dd_dev_dbg. dd_* functions properly decode the hfi1_devdata structure used throughout the driver Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/hfi.h | 4 1 file changed, 4 insertions(+) diff --git a/drivers/staging/rdma/hfi1

[PATCH v4 2/2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-12-01 Thread ira . weiny
From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- Changes from V1: Add comments concerning the very

[PATCH v2 3/7] staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors

2015-11-16 Thread ira . weiny
From: Ira Weiny Rather than have a switch in a large else clause make the parameter checks return immediately. Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 348 +++ 1 file changed, 173 insertions(+), 175

[PATCH v2 5/7] staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks

2015-11-16 Thread ira . weiny
From: Ira Weiny Final clean up of the if/then/else clause for the parameter checks of hfi1_ioctl Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from v1: SETLINKSTATE is removed drivers/staging/rdma/hfi1/diag.c | 23 +-- 1 file changed, 13

[PATCH v2 4/7] staging/rdma/hfi1: hfi1_ioctl remove setlink state

2015-11-16 Thread ira . weiny
From: Ira Weiny Set link state is not supported remove from the switch statement and allow the default to return -ENOTTY Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from v1: Just remove the check for SETLINKSTATE and allow the switch to default to

[PATCH v2 7/7] staging/rdma/hfi1: Return immediately on error

2015-11-16 Thread ira . weiny
From: Dennis Dalessandro Now that the spinlock is not taken throughout hfi1_ioctl it is safe to return early rather than setting a variable and falling through the switch. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from V1

[PATCH v2 6/7] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.

2015-11-16 Thread ira . weiny
-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- Changes from V1: Adjust to add the done label which can't be removed until a later patch Removed SETLINKSTATE drivers/staging/rdma/hfi1/diag.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --

[PATCH v2 2/7] staging/rdma/hfi1: Fix camel case variables

2015-11-16 Thread ira . weiny
From: Ira Weiny physState, linkState, and devState should be phys_state, link_state, and dev_state Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a

[PATCH v2 0/7] Fix hfi1_ioctl locking

2015-11-16 Thread ira . weiny
From: Ira Weiny It was identified that hfi1_ioctl may sleep with a spin lock held. This was identified publicly here: http://www.spinics.net/lists/linux-rdma/msg29926.html As well as by our internal development. This series cleans up the code and parameter checks, as well as fixing the

[PATCH v2 1/7] staging/rdma/hfi1: diag.c Correct code style issues

2015-11-16 Thread ira . weiny
From: Jubin John Correct the checks on diag.c with the latest checkpatch Reviewed-by: Dennis Dalessandro Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 81 ++-- 1 file changed, 37

[PATCH v3] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-11-16 Thread ira . weiny
From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- Changes from V1: Add comments concerning the very

[PATCH 4/8] staging/rdma/hfi1: remove unneeded goto done

2015-11-10 Thread ira . weiny
From: Ira Weiny This goto done is followed by an if (ret) break in the outer switch clause. It is unnecessary. Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers

[PATCH 7/8] staging/rdma/hfi1: Reduce snoop locking scope in IOCTL handler.

2015-11-10 Thread ira . weiny
Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rdma/hfi1/diag.c b/drivers/staging/rdma/hfi1/diag.c index 43f08080480c

[PATCH 3/8] staging/rdma/hfi1: Return early from hfi1_ioctl parameter errors

2015-11-10 Thread ira . weiny
From: Ira Weiny Rather than have a switch in a large else clause make the parameter checks return immediately. Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 348 +++ 1 file changed, 173 insertions(+), 175

[PATCH 5/8] staging/rdma/hfi1: return early if setlink state was specified

2015-11-10 Thread ira . weiny
From: Ira Weiny Set link state was not supported and so we can return early in the parameter checks rather than falling through the switch clause. Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 8 +++- 1 file changed, 3 insertions(+), 5

[PATCH 6/8] staging/rdma/hfi1: Further clean up hfi1_ioctl parameter checks

2015-11-10 Thread ira . weiny
From: Ira Weiny Final clean up of the if/then/else clause for the parameter checks of hfi1_ioctl Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a

[PATCH 8/8] staging/rdma/hfi1: Return immediately on error

2015-11-10 Thread ira . weiny
From: Dennis Dalessandro Now that the spinlock is not taken throughout hfi1_ioctl it is safe to return early rather than setting a variable and falling through the switch. Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1

[PATCH 1/8] staging/rdma/hfi1: diag.c Correct code style issues

2015-11-10 Thread ira . weiny
From: Jubin John Using the latest checkpatch correct the checks on diag.c Reviewed-by: Dennis Dalessandro Reviewed-by: Mike Marciniszyn Signed-off-by: Jubin John Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 81 ++-- 1 file changed, 37

[PATCH 2/8] staging/rdma/hfi1: Fix camel case variables

2015-11-10 Thread ira . weiny
From: Ira Weiny physState, linkState, and devState should be phys_state, link_state, and dev_state Signed-off-by: Dennis Dalessandro Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a

[PATCH 0/8] Fix hfi1_ioctl locking

2015-11-10 Thread ira . weiny
From: Ira Weiny It was identified that hfi1_ioctl may sleep with a spin lock held. This was identified publicly here: http://www.spinics.net/lists/linux-rdma/msg29926.html As well as by our internal development. This series cleans up the code and parameter checks, as well as fixing the

[PATCH] staging/rdma/hfi1: Handle packets with invalid RHF on context 0

2015-11-10 Thread ira . weiny
Haralanov Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/chip.c | 74 - drivers/staging/rdma/hfi1/driver.c | 108 - drivers/staging/rdma/hfi1/hfi.h

[PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

2015-11-10 Thread ira . weiny
-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/diag.c | 27 ++- drivers/staging/rdma/hfi1/hfi.h | 20 ++ drivers/staging/rdma/hfi1/ruc.c | 15 ++- drivers/staging/rdma/hfi1/verbs.c | 55 ++- drivers/staging/rdma/hfi1

[RESEND PATCH v4 1/3] staging/rdma/hfi1: move hfi1_migrate_qp

2015-11-09 Thread ira . weiny
From: Mike Marciniszyn Move hfi1_migrate_qp from ruc.c to qp.[hc] in prep for modifying the QP workqueue. Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- This patch was previously sent as #7/9 but 5/9 failed. I'm resending 7,8, and 9 as they did not explicitly depend on 5

[RESEND PATCH v4 3/3] staging/rdma/hfi1: pre-compute sc and sde for RC/UC QPs

2015-11-09 Thread ira . weiny
From: Mike Marciniszyn Now that we have a multi-threaded work queue we precomputed and store the SC and SDE on RC and UC QPs for faster access. Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- This patch was previously sent as #9/9 but 5/9 failed

[RESEND PATCH v4 2/3] staging/rdma/hfi1: Use parallel workqueue for SDMA engines

2015-11-09 Thread ira . weiny
WQ_CPU_INTENSIVE and WQ_HIGHPRI specified. Then change send to use the new scheduler which no longer needs to get the s_lock Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- Changes from v3: Split patch out code refactoring and separate

[PATCH v2] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-11-09 Thread ira . weiny
From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- Changes from V1: Add comments concerning the very

[PATCH v3 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-09 Thread ira . weiny
From: Vennila Megavannan Add a module paramter to toggle prescan/Fast ECN Detection and remove the Kconfig option which used to control this. Reviewed-by: Arthur Kepner Reviewed-by: Mike Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Ira Weiny --- Changes from V1: Redo

[PATCH v2 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-05 Thread ira . weiny
time will result in a significant reduction of performance at the node level but may result in better overall fabric/cluster performance. Reviewed-by: Arthur Kepner Reviewed-by: Mike Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Ira Weiny --- Changes from V1: Redo commit

[PATCH 1/3] staging/rdma/hfi1: don't cache "prescan head"

2015-11-04 Thread ira . weiny
idable race, and to avoid getting out of sync we always start prescanning at the current "rcd->head" entry. Reviewed-by: Mike Marciniszyn Reviewed-by: Dennis Dalessandro Signed-off-by: Arthur Kepner Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/driver.c | 13 +++-

[PATCH 3/3] staging/rdma/hfi1: Method to toggle "fast ECN" detection

2015-11-04 Thread ira . weiny
From: Vennila Megavannan Add a module paramter to toggle prescan/Fast ECN Detection. In addition change the PRESCAN_RXQ Kconfig default to "yes". Reviewed-by: Arthur Kepner Reviewed-by: Mike Marciniszyn Signed-off-by: Vennila Megavannan Signed-off-by: Ira Weiny --- drivers/staging

[PATCH 0/3] staging/rdma/hfi1: complete fixes for ECN detection

2015-11-04 Thread ira . weiny
From: Ira Weiny The following 3 patches fix the ECN detection and add a module parameter to turn the prescan of the receive queue on and off. Arthur Kepner (2): staging/rdma/hfi1: don't cache "prescan head" staging/rdma/hfi1: optionally prescan rx queue for {B,F}ECNs -

[PATCH 2/3] staging/rdma/hfi1: optionally prescan rx queue for {B,F}ECNs - UC, RC

2015-11-04 Thread ira . weiny
). Afterward, the packet will be processed normally. Reviewed-by: Mike Marciniszyn Reviewed-by: Dennis Dalessandro Signed-off-by: Arthur Kepner Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/driver.c | 64 +++--- drivers/staging/rdma/hfi1/rc.c | 10

[PATCH] staging/rdma/hfi1: set Gen3 half-swing for integrated devices

2015-11-04 Thread ira . weiny
From: Dean Luick Correctly set half-swing for integrated devices. A0 needs all fields set for CcePcieCtrl. B0 and later only need a few fields set. Reviewed-by: Stuart Summers Signed-off-by: Dean Luick Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/chip_registers.h | 11

[PATCH v4 2/9] staging/rdma/hfi1: Clean up macro indentation

2015-10-30 Thread ira . weiny
From: Mitko Haralanov In preparation for implementing Expected TID caching we do some simple clean up of header file macros. Signed-off-by: Mitko Haralanov Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/common.h | 15 --- include/uapi/rdma/hfi/hfi1_user.h | 26

[PATCH v4 5/9] staging/rdma/hfi1: Add function stubs for TID caching

2015-10-30 Thread ira . weiny
use of these functions. Signed-off-by: Mitko Haralanov Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/Kconfig| 1 + drivers/staging/rdma/hfi1/Makefile | 2 +- drivers/staging/rdma/hfi1/user_exp_rcv.c | 314 +++ drivers/staging/rdma/hfi1

[PATCH v4 9/9] staging/rdma/hfi: pre-compute sc and sde for RC/UC QPs

2015-10-30 Thread ira . weiny
From: Mike Marciniszyn Now that we have a multi-threaded work queue we precomputed and store the SC and SDE on RC and UC QPs for faster access. Reviewed-by: Dennis Dalessandro Signed-off-by: Mike Marciniszyn Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/qp.c| 27

[PATCH v4 1/9] staging/rdma/hfi1: Remove file pointer macros

2015-10-30 Thread ira . weiny
From: Ira Weiny Remove the following macros in favor of explicit use of struct hfi1_filedata and various sub structures. ctxt_fp subctxt_fp tidcursor_fp user_sdma_pkt_fp user_sdma_comp_fp Reviewed-by: Mitko Haralanov Signed-off-by: Ira Weiny --- drivers/staging/rdma/hfi1/file_ops.c | 124

[PATCH v4 6/9] staging/rdma/hfi1: Implement Expected Receive TID caching

2015-10-30 Thread ira . weiny
quot;unlimited" (as we've done up to this point), may result in jobs being killed by the kernel's OOM due to them taking up excessive amounts of memory. Reviewed-by: Arthur Kepner Reviewed-by: Dennis Dalessandro Signed-off-by: Mitko Haralanov Signed-off-by: Ira Weiny --- Change

  1   2   3   4   5   6   7   8   9   10   >