On Thu, May 28, 2015 at 11:11:30AM -0700, Shirley Ma wrote:
> NFSD workqueue mode vs. threading mode performance impacts: (Shirley)
> -
> Shirley has spent sometime test/fix/evaluating NFSD workqueue mode
> originally implemented b
On Thu, Jul 09, 2015 at 04:45:47PM -0400, Chuck Lever wrote:
> Increased to 1 megabyte.
Why not more or less?
Why do we even have this constant, why shouldn't we just use
RPCSVC_MAXPAYLOAD?
--b.
>
> Signed-off-by: Chuck Lever
> ---
>
> include/linux/sunrpc/svc_rdma.h |2 +-
> 1 files ch
On Fri, Jul 10, 2015 at 10:18:14AM -0400, J. Bruce Fields wrote:
> On Thu, Jul 09, 2015 at 04:45:47PM -0400, Chuck Lever wrote:
> > Increased to 1 megabyte.
>
> Why not more or less?
>
> Why do we even have this constant, why shouldn't we just use
> RPCSVC_MAXPAYLO
On Fri, Jul 10, 2015 at 10:59:48AM -0400, Chuck Lever wrote:
>
> On Jul 10, 2015, at 10:18 AM, bfie...@fieldses.org wrote:
>
> > On Thu, Jul 09, 2015 at 04:45:47PM -0400, Chuck Lever wrote:
> >> Increased to 1 megabyte.
> >
> > Why not more or less?
> >
> > Why do we even have this constant, wh
On Fri, Jul 10, 2015 at 11:59:20AM -0400, Chuck Lever wrote:
>
> On Jul 10, 2015, at 11:54 AM, J. Bruce Fields wrote:
>
> > On Fri, Jul 10, 2015 at 10:59:48AM -0400, Chuck Lever wrote:
> >>
> >> On Jul 10, 2015, at 10:18 AM, bfie...@fieldses.org wrote:
> >
;s tree
> to avoid any merge problems.
Sounds fine. I've got some changes to those files in my for-next as
well, but they don't appear to conflict.
Feel free to add my
Acked-by: J. Bruce Fields
to patch 3/4 if it helps.
--b.
>
> ---
>
> Sagi Grimberg (1):
&
my tree nearby
there is 31193fe5f6fb "svcrdma: Remove svc_rdma_fastreg()", which
shouldn't conflict.
Acked-by: J. Bruce Fields
--b.
> ---
> net/sunrpc/xprtrdma/svc_rdma_transport.c |6 --
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --
On Mon, Apr 05, 2010 at 10:55:12AM -0400, Chuck Lever wrote:
> On 04/03/2010 09:27 AM, Tom Tucker wrote:
>> RPC6 requires that it be possible to create endpoints that listen
>> exclusively for IPv4 or IPv6 connection requests. This is not currently
>> supported by the RDMA API.
>>
>> Signed-off-by:
On Mon, Apr 05, 2010 at 10:50:16AM -0500, Tom Tucker wrote:
> J. Bruce Fields wrote:
>> On Mon, Apr 05, 2010 at 10:55:12AM -0400, Chuck Lever wrote:
>>
>>> On 04/03/2010 09:27 AM, Tom Tucker wrote:
>>>
>>>> RPC6 requires that it be possible to
On Mon, Apr 05, 2010 at 12:16:18PM -0400, J. Bruce Fields wrote:
> On Mon, Apr 05, 2010 at 10:50:16AM -0500, Tom Tucker wrote:
> > J. Bruce Fields wrote:
> >> On Mon, Apr 05, 2010 at 10:55:12AM -0400, Chuck Lever wrote:
> >>
> >>> On 04/03/2010 09:27 AM, T
On Tue, Oct 12, 2010 at 03:33:46PM -0500, Tom Tucker wrote:
> Hi Bruce,
>
> These fixes are ready for 2.6.37. They fix two bugs in the server-side
> NFSRDMA transport.
Both applied and pushed out, thanks.
--b.
>
> Thanks,
> Tom
> ---
>
> Tom Tucker (2):
> svcrdma: Cleanup DMA unmapping
On Sun, Nov 21, 2010 at 03:41:18PM +0200, Boaz Harrosh wrote:
> On 11/21/2010 02:23 PM, Hiroyuki Sato wrote:
> > Hello lists
> >
> > OS: CentOS 5.5
> > kernel: 2.6.36 rebuild myself.
> >
> >
> > I'm trying to test NFS/RDMA.
> > I tried to mount nfs_server:/mnt volume on on nfs_client
> > b
On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote:
> Svcrdma currently advertises 1MB, which is too large. The correct value
> is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page
> size. This bug is usually benign because the Linux X64 NFSRDMA client
> correctly limit
On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote:
> On 9/22/2014 1:39 PM, J. Bruce Fields wrote:
> >On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote:
> >>Svcrdma currently advertises 1MB, which is too large. The correct value
> >>is the max scatter-g
On Tue, Sep 23, 2014 at 02:42:34PM -0500, Steve Wise wrote:
>
> > > diff --git a/net/sunrpc/xprtrdma/xprt_rdma.h
> > > b/net/sunrpc/xprtrdma/xprt_rdma.h
> > > index c419498..a9cf5c3 100644
> > > --- a/net/sunrpc/xprtrdma/xprt_rdma.h
> > > +++ b/net/sunrpc/xprtrdma/xprt_rdma.h
> > > @@ -392,4 +392
On Tue, Sep 23, 2014 at 02:53:28PM -0500, Steve Wise wrote:
>
>
> > -Original Message-
> > From: 'J. Bruce Fields' [mailto:bfie...@fieldses.org]
> > Sent: Tuesday, September 23, 2014 2:48 PM
> > To: Steve Wise
> > Cc: 'Chuck Lever'
On Mon, Sep 29, 2014 at 11:07:25AM -0500, Steve Wise wrote:
>
> Hey Bruce, is this version acceptable for 3.18?
Yes, applying, thanks for the reminder.--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo
On Mon, Nov 10, 2014 at 08:54:27AM -0600, Chuck Lever wrote:
>
> On Nov 10, 2014, at 8:36 AM, Anna Schumaker wrote:
>
> > Hey Chuck,
> >
> >
> > On 11/08/2014 08:14 PM, Chuck Lever wrote:
> >> The Linux NFS/RDMA server used to reject NFSv3 WRITE requests when
> >> pad optimization was enabled.
On Fri, Jan 09, 2015 at 02:23:11PM -0500, Chuck Lever wrote:
> Simpler approach, and this needs to be done before the tail is
> copied to the end of the read list (pre-requisite for a subsequent
> patch).
>
> Fixes: e560e3b510d2 ("svcrdma: Add zero padding if the client... ")
Wait, does this actu
On Fri, Jan 09, 2015 at 02:21:54PM -0500, Chuck Lever wrote:
> In addition to miscellaneous clean up, the following series of
> patches for the Linux NFS server introduces support in the
> server’s RPC/RDMA transport implementation for RDMA_NOMSG type
> messages, and fixes a bug that prevents the s
On Fri, Jan 09, 2015 at 03:40:51PM -0500, Chuck Lever wrote:
>
> On Jan 9, 2015, at 3:39 PM, J. Bruce Fields wrote:
>
> > On Fri, Jan 09, 2015 at 02:21:54PM -0500, Chuck Lever wrote:
> >> In addition to miscellaneous clean up, the following series of
> >>
On Tue, Jan 13, 2015 at 11:31:16AM -0600, Steve Wise wrote:
>
> Reviewed-by: Steve Wise
Thanks, applying for 3.20.
--b.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/m
On Mon, Sep 28, 2015 at 09:31:25AM -0500, Steve Wise wrote:
> On 9/21/2015 12:24 PM, Steve Wise wrote:
> >The server rdma_read_chunk_lcl() and rdma_read_chunk_frmr() functions
> >were not taking into account the initial page_offset when determining
> >the rdma read length. This resulted in a read
On Mon, Sep 28, 2015 at 04:49:21PM -0500, Steve Wise wrote:
>
>
> > -Original Message-
> > From: J. Bruce Fields [mailto:bfie...@fieldses.org]
> > Sent: Monday, September 28, 2015 4:05 PM
> > To: Steve Wise
> > Cc: trond.mykleb...@primarydata.com; l
On Tue, Oct 06, 2015 at 01:44:25PM -0400, Doug Ledford wrote:
> On 09/28/2015 05:46 PM, Steve Wise wrote:
> > The server rdma_read_chunk_lcl() and rdma_read_chunk_frmr() functions
> > were not taking into account the initial page_offset when determining
> > the rdma read length. This resulted in a
On Wed, Oct 07, 2015 at 01:33:05PM -0400, Doug Ledford wrote:
> On 10/07/2015 01:01 PM, J. Bruce Fields wrote:
> > On Tue, Oct 06, 2015 at 01:44:25PM -0400, Doug Ledford wrote:
> >> On 09/28/2015 05:46 PM, Steve Wise wrote:
> >>> The server rdma_read_chunk_
On Mon, Oct 12, 2015 at 10:53:39AM -0400, Chuck Lever wrote:
> Now that the NFS server advertises a maximum payload size of 1MB
> for RPC/RDMA again, it crashes in svc_process_common() when NFS
> client sends a 1MB NFS WRITE on an NFS/RDMA mount.
>
> The server has set up a 259 element array of st
On Wed, Nov 11, 2015 at 03:20:33PM -0500, Chuck Lever wrote:
>
> > On Nov 3, 2015, at 3:10 PM, Chuck Lever wrote:
> >
> >
> >> On Oct 16, 2015, at 9:30 AM, Chuck Lever wrote:
> >>
> >> Minor optimization: when dealing with write chunk XDR roundup, do
> >> not post a Write WR for the zero byte
On Thu, Nov 12, 2015 at 09:47:13AM -0500, Chuck Lever wrote:
> I wish git send-mail had an address book. I’m really tired
> of misspelling the to/cc addresses on patches.
Hah. Yeah, my hack is a text file of addresses that I cut-and-paste
from.
--b.
>
> Resending so there is one thread for all
On Tue, Dec 08, 2015 at 07:31:56AM -0600, Steve Wise wrote:
>
>
> > -Original Message-
> > From: Chuck Lever [mailto:chuck.le...@oracle.com]
> > Sent: Monday, December 07, 2015 9:45 AM
> > To: Steve Wise
> > Cc: linux-rdma@vger.kernel.org; Veeresh U. Kokatnur; Linux NFS Mailing List
> > S
On Mon, Dec 14, 2015 at 04:30:09PM -0500, Chuck Lever wrote:
> Minor optimization: when dealing with write chunk XDR roundup, do
> not post a Write WR for the zero bytes in the pad. Simply update
> the write segment in the RPC-over-RDMA header to reflect the extra
> pad bytes.
>
> The Reply chunk
On Mon, Dec 21, 2015 at 04:15:23PM -0500, Chuck Lever wrote:
>
> > On Dec 21, 2015, at 4:07 PM, J. Bruce Fields wrote:
> >
> > On Mon, Dec 14, 2015 at 04:30:09PM -0500, Chuck Lever wrote:
> >> Minor optimization: when dealing with write chunk XDR roundup, do
&g
On Mon, Dec 21, 2015 at 05:11:56PM -0500, Chuck Lever wrote:
>
> > On Dec 21, 2015, at 4:29 PM, J. Bruce Fields wrote:
> >
> > On Mon, Dec 21, 2015 at 04:15:23PM -0500, Chuck Lever wrote:
> >>
> >>> On Dec 21, 2015, at 4:07 PM, J. Bruce Fields wrote:
On Wed, Dec 16, 2015 at 05:40:09PM +0530, Devesh Sharma wrote:
> iozone passed on ocrdma device.
What other testing has there been of this patchset?
Connectathon, xfstests, and pynfs make more of an effort to test corner
cases, iozone isn't much of a test of correctness.
--b.
> Link bounce fail
On Thu, Dec 10, 2015 at 07:49:59PM -0500, Chuck Lever wrote:
>
> > On Dec 10, 2015, at 6:30 PM, Christoph Hellwig wrote:
> >
> > On Thu, Dec 10, 2015 at 11:07:03AM -0700, Jason Gunthorpe wrote:
> >> The ARM folks do this sort of stuff on a regular basis.. Very early on
> >> Doug prepares a topic
On Thu, Apr 10, 2014 at 01:37:23PM -0500, Steve Wise wrote:
> From: Tom Tucker
>
> This patch refactors the marshalling logic to remove the intermediary
> map structures. It also fixes an existing bug where the NFSRDMA server
> was not minding the device fast register page list length limitation
On Fri, Apr 25, 2014 at 09:24:47AM -0400, Chuck Lever wrote:
> Hi Bruce-
>
> On Apr 25, 2014, at 6:58 AM, J. Bruce Fields wrote:
>
> > On Thu, Apr 10, 2014 at 01:37:23PM -0500, Steve Wise wrote:
> >> From: Tom Tucker
> >>
> >> This patch
On Tue, May 06, 2014 at 12:46:27PM -0500, Steve Wise wrote:
> From: Tom Tucker
>
> Change poll logic to grab up to 6 completions at a time.
>
> RDMA write and send completions no longer deal with fastreg objects.
>
> Set SVCRDMA_DEVCAP_FAST_REG and allocate a dma_mr based on the device
> capabi
On Tue, May 06, 2014 at 12:46:21PM -0500, Steve Wise wrote:
> This patch series refactors the NFSRDMA server marshalling logic to
> remove the intermediary map structures. It also fixes an existing bug
> where the NFSRDMA server was not minding the device fast register page
> list length limitatio
On Tue, May 06, 2014 at 04:02:41PM -0500, Steve Wise wrote:
> On 5/6/2014 2:21 PM, J. Bruce Fields wrote:
> >On Tue, May 06, 2014 at 12:46:27PM -0500, Steve Wise wrote:
> >>From: Tom Tucker
> >>
> >>Change poll logic to grab up to 6 completions at a time.
>
On Mon, May 19, 2014 at 01:40:22PM -0400, Chuck Lever wrote:
> An NFS/RDMA client's source port is meaningless for RDMA transports.
> The transport layer typically sets the source port value on the
> connection to a random ephemeral port.
>
> Currently, NFS server administrators must specify the "
On Thu, May 22, 2014 at 03:55:17PM -0400, bfields wrote:
> On Mon, May 19, 2014 at 01:40:22PM -0400, Chuck Lever wrote:
> > An NFS/RDMA client's source port is meaningless for RDMA transports.
> > The transport layer typically sets the source port value on the
> > connection to a random ephemeral p
On Mon, Jun 02, 2014 at 11:47:58AM -0500, Steve Wise wrote:
>
>
> > Steve
> >
> > I have not checked the code because I am away from my laptop
> > But I assume mlx and mthca is using fmr and cxgb4 is using
> > rdma-read-with-invalidate
> which
> > has implicit fence.
> >
> > If invalidate is i
On Mon, Jun 02, 2014 at 11:52:47AM -0500, Steve Wise wrote:
> > > You're correct. And this bug appears to be in the current upstream code
> > > as well. If
> an
> > > IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it
> > > until the prior
> > read
> > > completes.
> > >
> >
On Mon, Jun 02, 2014 at 12:06:39PM -0500, Steve Wise wrote:
>
> > On Mon, Jun 02, 2014 at 11:52:47AM -0500, Steve Wise wrote:
> > > > > You're correct. And this bug appears to be in the current upstream
> > > > > code as well.
> If
> > > an
> > > > > IB_WR_LOCAL_INV wr is used, it must include I
On Thu, Jun 05, 2014 at 09:54:31AM -0500, Steve Wise wrote:
> This applies on top of:
>
> commit e5a070216356dbcb03607cb264cc3104e17339b3
> Author: Steve Wise
> Date: Wed May 28 15:12:01 2014 -0500
>
> svcrdma: refactor marshalling logic
Sorry, I lost track--was th
On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote:
> The server should comply with RFC 5667,
Where's the relevant language? (I took a quick look but didn't see it.)
> and handle WRITE payloads
> that may not have a zero pad on the end (XDR length round-up).
>
> Fixes: f34b9568 (The NF
On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote:
>
> On Jul 10, 2014, at 2:19 PM, J. Bruce Fields wrote:
>
> > On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote:
> >> The server should comply with RFC 5667,
> >
> > Where's the rel
On Thu, Jul 10, 2014 at 03:07:34PM -0400, Chuck Lever wrote:
> Hi Bruce-
>
> On Jul 10, 2014, at 2:49 PM, J. Bruce Fields wrote:
>
> > On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote:
> >>
> >> On Jul 10, 2014, at 2:19 PM, J. Bruce Fields wrote:
On Wed, Jul 09, 2014 at 01:49:15PM -0500, Steve Wise wrote:
> Function send_write() must stop creating sges when it reaches the device
> max and return the amount sent in the RDMA Write to the caller.
Queueing up for 3.17, thanks.--b.
>
> Signed-off-by: Steve Wise
> ---
>
> net/sunrpc/xprtrdm
On Thu, Jul 10, 2014 at 04:43:54PM -0400, Chuck Lever wrote:
> I think the sanity check you pointed out is strictly satisfied by
> testing against the unaligned number of bytes. Is there a strong
> reason to do the extra math for that check during each WRITE?
I can't think of any good reason why t
Thanks, applying for 3.17.--b.
On Thu, Jul 31, 2014 at 03:26:07PM -0500, Steve Wise wrote:
> In svc_rdma_accept(), if rdma_create_qp() fails, there is useless
> logic to try and call rdma_create_qp() again with reduced sge depths.
> The assumption, I guess, was that perhaps the initial sge depths
On Wed, Feb 06, 2013 at 05:48:15PM +0200, Yan Burman wrote:
> When killing mount command that got stuck:
> ---
>
> BUG: unable to handle kernel paging request at 880324dc7ff8
> IP: [] rdma_read_xdr+0x8bb/0xd40 [svcrdma]
> PGD 1a0c063 PUD 32f82e063 PMD 32
On Wed, Feb 06, 2013 at 05:24:35PM -0500, J. Bruce Fields wrote:
> On Wed, Feb 06, 2013 at 05:48:15PM +0200, Yan Burman wrote:
> > When killing mount command that got stuck:
> > ---
> >
> > BUG: unable to handle kernel paging
On Mon, Feb 11, 2013 at 03:19:42PM +, Yan Burman wrote:
> > -Original Message-
> > From: J. Bruce Fields [mailto:bfie...@fieldses.org]
> > Sent: Thursday, February 07, 2013 18:42
> > To: Yan Burman
> > Cc: linux-...@vger.kernel.org; sw...@openg
On Mon, Feb 11, 2013 at 03:19:42PM +, Yan Burman wrote:
> > -Original Message-
> > From: J. Bruce Fields [mailto:bfie...@fieldses.org]
> > Sent: Thursday, February 07, 2013 18:42
> > To: Yan Burman
> > Cc: linux-...@vger.kernel.org; sw...@openg
On Thu, Apr 18, 2013 at 12:47:09PM +, Yan Burman wrote:
>
>
> > -Original Message-
> > From: Wendy Cheng [mailto:s.wendy.ch...@gmail.com]
> > Sent: Wednesday, April 17, 2013 21:06
> > To: Atchley, Scott
> > Cc: Yan Burman; J. Bruce Fields; To
On Wed, Apr 24, 2013 at 12:35:03PM +, Yan Burman wrote:
>
>
> > -Original Message-
> > From: J. Bruce Fields [mailto:bfie...@fieldses.org]
> > Sent: Wednesday, April 24, 2013 00:06
> > To: Yan Burman
> > Cc: Wendy Cheng; Atchley, Scott; To
On Wed, Apr 24, 2013 at 11:05:40AM -0400, J. Bruce Fields wrote:
> On Wed, Apr 24, 2013 at 12:35:03PM +, Yan Burman wrote:
> >
> >
> > > -Original Message-----
> > > From: J. Bruce Fields [mailto:bfie...@fieldses.org]
> > > Sent: Wednesday,
On Sun, Apr 28, 2013 at 06:28:16AM +, Yan Burman wrote:
> > > > > > > >> On Wed, Apr 17, 2013 at 7:36 AM, Yan Burman
> > > > > > > >>
> > > > > > > >>> I've been trying to do some benchmarks for NFS over RDMA
> > > > > > > >>> and I seem to
> > > > > > > only get about half of the bandwidth th
On Sun, Apr 28, 2013 at 10:42:48AM -0400, J. Bruce Fields wrote:
> On Sun, Apr 28, 2013 at 06:28:16AM +, Yan Burman wrote:
> > > > > > > > >> On Wed, Apr 17, 2013 at 7:36 AM, Yan Burman
> > > > > > > > >>
> > >
61 matches
Mail list logo