This looks better, but I have a couple of comments (below).
I can modify those and add it to a couple of patches I have piped for 3.18-rcX.
Thanks for the prompt review of the patch.
So I see this as a temp fix for now. A more thorough fix will follow in 3.19.
I like to follow up with all
Hi Or,
So just to recaphere.
With your driver maximal attributes of 8K CQEs per CQ and 32 CQs per device,
do/what we need to change s.t that the iser initiator functional with it's
current code is functional on 3.18-rc1?
Yes, I've just verified the patch with 3.18-rc1 on both ocrdma and mlx4
On 10/22/2014 12:11 AM, Minh Duc Tran wrote:
Hi Or,
So just to recaphere.
With your driver maximal attributes of 8K CQEs per CQ and 32 CQs per
device, do/what we need to change s.t that the iser initiator functional
with it's current code is functional on 3.18-rc1?
Yes, I've just verified
+++ b/drivers/infiniband/ulp/iser/iser_verbs.c
@@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device
*device)
if (IS_ERR(device-pd))
goto pd_err;
+ max_cqe = (dev_attr-max_cqe ISER_MAX_CQ_LEN) ?
+ dev_attr-max_cqe :
On 10/20/2014 11:01 AM, Or Gerlitz wrote:
On Mon, Oct 20, 2014 at 8:36 AM, Minh Duc Tran
minhduc.t...@emulex.com ---
a/drivers/infiniband/ulp/iser/iser_verbs.c
+++ b/drivers/infiniband/ulp/iser/iser_verbs.c
@@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device
Hi Sagi,
I've created a new patch over the 21 iser patches you have mentioned early in
this thread. It is pasted at the end of this email.
If I understand correctly, this patch will be applied along with Or's TODO list.
ISER_MAX_RX_CQ_LEN 4096 /* This number should
With the HW and fw profile we are running with the ocrdma currently, it's 8k
per CQ. This number could change if we run on different hw or fw profile.
-Original Message-
From: Or Gerlitz [mailto:gerlitz...@gmail.com]
Sent: Wednesday, October 15, 2014 3:32 PM
To: Minh Duc Tran
Cc
of cpu cores on the system to
distribute CQ processing per core? */
We are open for suggestions.
-Minh
-Original Message-
From: Or Gerlitz [mailto:ogerl...@mellanox.com]
Sent: Tuesday, October 14, 2014 12:51 AM
To: Jay Kallickal; Minh Duc Tran
Cc: micha...@cs.wisc.edu; linux-rdma
