Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Patrick McHardy
On 14.04, Honggang Li wrote: > Signed-off-by: Honggang Li > --- > drivers/net/macvlan.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/macvlan.c b/drivers/net/macvlan.c > index b227a13..1e59f39 100644 > --- a/drivers/net/macvlan.c > +++ b/drivers/net/macv

Re: [PATCH linux-next 3/4] macvlan: fix possible NULL pointer dereference in macvlan_dev_get_iflink

2015-04-14 Thread Patrick McHardy
On 14.04, Honggang LI wrote: > On Tue, Apr 14, 2015 at 04:26:27PM +0100, Patrick McHardy wrote: > > > > That is completely useless. vlan (=netdev_priv) can not be NULL as > > netdev_priv() never returns NULL and vlan->lowerdev is always valid > > because a ma

[PATCH 5/5] IPoIB: add support for TIPC protocol

2013-04-17 Thread Patrick McHardy
ar to IPv4/IPv6 unicast packets in ipoib_start_xmit(). An alternative would be to remove all ethertype limitations since they're not necessary anymore, all TIPC needs to know about is ARP and RARP since it wants to always perform "path find", even if a path is already known. Si

[PATCH 3/5] tipc: set skb->protocol in eth_media packet transmission

2013-04-17 Thread Patrick McHardy
100 1000 0100 1001 [P.(..0. 0x0010: 03e8 0001 20c9 d043 12d9 ...C 0x0020: Signed-off-by: Patrick McHardy --- net/tipc/eth_media.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/t

[PATCH 4/5] tipc: add InfiniBand media type

2013-04-17 Thread Patrick McHardy
rer:0 link:0 Send queue max:1 avg:0 Signed-off-by: Patrick McHardy --- net/tipc/Kconfig| 7 + net/tipc/Makefile | 2 + net/tipc/bearer.c | 2 +- net/tipc/bearer.h | 9 ++ net/tipc/core.c | 12 +- net/tipc/ib_media.c | 387 6

[PATCH 2/5] tipc: move bcast_addr from struct tipc_media to struct tipc_bearer

2013-04-17 Thread Patrick McHardy
Some network protocols, like InfiniBand, don't have a fixed broadcast address but one that depends on the configuration. Move the bcast_addr to struct tipc_bearer and initialize it with the broadcast address of the network device when the bearer is enabled. Signed-off-by: Patrick Mc

[PATCH 1/5] tipc: remove unused str2addr media callback

2013-04-17 Thread Patrick McHardy
Signed-off-by: Patrick McHardy --- net/tipc/bearer.h| 2 -- net/tipc/eth_media.c | 20 2 files changed, 22 deletions(-) diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h index 39f1192..cc2d74e 100644 --- a/net/tipc/bearer.h +++ b/net/tipc/bearer.h @@ -77,7 +77,6

[PATCH v2 0/5] tipc: add TIPC over Infiniband support

2013-04-17 Thread Patrick McHardy
The following patchset adds support for running TIPC over InfiniBand. The patchset consists of three parts (+ a minor fix for the ethernet media type): - Preparation: removal of an the unused str2addr callback and move of the bcast_addr from struct tipc_media to struct tipc_bearer. This is neces

Re: [PATCH 4/5] tipc: add InfiniBand media type

2013-04-07 Thread Patrick McHardy
On Sun, Apr 07, 2013 at 05:07:12PM +0800, Ying Xue wrote: > > > --- a/net/tipc/core.c > > +++ b/net/tipc/core.c > > @@ -82,6 +82,7 @@ static void tipc_core_stop_net(void) > > { > > tipc_net_stop(); > > tipc_eth_media_stop(); > > + tipc_ib_media_stop(); > > } > > > > /** > > @@ -93,8

Re: [PATCH 4/5] tipc: add InfiniBand media type

2013-04-07 Thread Patrick McHardy
On Sun, Apr 07, 2013 at 11:19:06AM +0200, Bart Van Assche wrote: > On 04/03/13 14:43, Patrick McHardy wrote: > >diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h > >+#ifdef CONFIG_TIPC_MEDIA_IB > >+int tipc_ib_media_start(void); > >+void tipc_ib_media_st

Re: [PATCH 5/5] IPoIB: add support for TIPC protocol

2013-04-03 Thread Patrick McHardy
On Wed, Apr 03, 2013 at 06:31:49PM +0300, Or Gerlitz wrote: > On 03/04/2013 15:43, Patrick McHardy wrote: > >[...] all TIPC needs to know about is ARP and RARP since > >it wants to always perform "path find", even if a path is already known. > >[...] > > No

Re: [PATCH 4/5] tipc: add InfiniBand media type

2013-04-03 Thread Patrick McHardy
On Wed, Apr 03, 2013 at 04:41:40PM +0200, Erik Hugne wrote: > On Wed, Apr 03, 2013 at 02:43:29PM +0200, Patrick McHardy wrote: > > diff --git a/net/tipc/Kconfig b/net/tipc/Kconfig > > index 4f99600..900ee66 100644 > > --- a/net/tipc/Kconfig > > +++ b/net/tipc/Kconfig &g

[PATCH 1/5] tipc: remove unused str2addr media callback

2013-04-03 Thread Patrick McHardy
Signed-off-by: Patrick McHardy --- net/tipc/bearer.h| 2 -- net/tipc/eth_media.c | 20 2 files changed, 22 deletions(-) diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h index 39f1192..cc2d74e 100644 --- a/net/tipc/bearer.h +++ b/net/tipc/bearer.h @@ -77,7 +77,6

[PATCH RFC 0/5] tipc: add support for TIPC over InfiniBand

2013-04-03 Thread Patrick McHardy
The following patchset adds support for running TIPC over InfiniBand. The patchset consists of three parts (+ a minor fix for the ethernet media type): - Preparation: removal of an the unused str2addr callback and move of the bcast_addr from struct tipc_media to struct tipc_bearer. This is neces

[PATCH 4/5] tipc: add InfiniBand media type

2013-04-03 Thread Patrick McHardy
rer:0 link:0 Send queue max:1 avg:0 Signed-off-by: Patrick McHardy --- net/tipc/Kconfig| 7 + net/tipc/Makefile | 2 + net/tipc/bearer.c | 2 +- net/tipc/bearer.h | 9 ++ net/tipc/core.c | 14 +- net/tipc/ib_media.c | 387 6

[PATCH 2/5] tipc: move bcast_addr from struct tipc_media to struct tipc_bearer

2013-04-03 Thread Patrick McHardy
Some network protocols, like InfiniBand, don't have a fixed broadcast address but one that depends on the configuration. Move the bcast_addr to struct tipc_bearer and initialize it with the broadcast address of the network device when the bearer is enabled. Signed-off-by: Patrick Mc

[PATCH 3/5] tipc: set skb->protocol in eth_media packet transmission

2013-04-03 Thread Patrick McHardy
100 1000 0100 1001 [P.(..0. 0x0010: 03e8 0001 20c9 d043 12d9 ...C 0x0020: Signed-off-by: Patrick McHardy --- net/tipc/eth_media.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/t

[PATCH 5/5] IPoIB: add support for TIPC protocol

2013-04-03 Thread Patrick McHardy
ar to IPv4/IPv6 unicast packets in ipoib_start_xmit(). An alternative would be to remove all ethertype limitations since they're not necessary anymore, all TIPC needs to know about is ARP and RARP since it wants to always perform "path find", even if a path is already known. Si

[PATCH] IB/ipoib: Fix crash resulted as of use after free for multicast object

2012-08-30 Thread Patrick McHardy
is called, where for that end, we move the RTNL lock wrapped code to ipoib_mcast_join_finish(). Signed-off-by: Patrick McHardy --- drivers/infiniband/ulp/ipoib/ipoib_main.c |2 +- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 19 ++- 2 files changed, 11 inserti