Re: [RFC PATCH 2/2] IB/uverbs: Add support for user registration of mmap memory

2010-12-02 Thread Ralph Campbell
On Thu, 2010-12-02 at 12:24 -0800, Tom Tucker wrote: Personally I think the biggest issue is that I don't think the pfn to dma address mapping logic is portable. Perhaps. That is why the core Linux VM folks should be involved. On 12/2/10 1:35 PM, Ralph Campbell wrote: I understand the need

Re: [PATCH 3/3] ibacm: check for special handling of loopback requests

2010-11-16 Thread Ralph Campbell
On Tue, 2010-11-16 at 16:15 -0800, Hefty, Sean wrote: ... @@ -2620,6 +2663,12 @@ static void acm_set_options(void) } fclose(f); + + if (!(f = fopen(/sys/module/mlx4_core/parameters/block_loopback, r))) + return; + + fscanf(f, %d, loopback_prot); +

RE: [PATCH 3/3] ibacm: check for special handling of loopback requests

2010-11-16 Thread Ralph Campbell
On Tue, 2010-11-16 at 16:54 -0800, Hefty, Sean wrote: This seems to introduce an HCA specific dependency. yep :( This is why ACM just handles it rather than exposing any sort of option to a user. Isn't ibacm supposed to work with different HCAs? It does and still will, even in a

RE: [PATCH 3/3] ibacm: check for special handling of loopback requests

2010-11-16 Thread Ralph Campbell
I guess what I'm objecting to is hard coding mlx4. I was trying to think of a way that would allow other HCAs to support the block loopback option in the future. It looks like ipoib sets IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK for kernel QPs but this isn't defined in libibverbs yet. It seems

Re: [PATCH] [libipathverbs] Fix 32 bit libipathverbs

2010-10-25 Thread Ralph Campbell
Thanks, applied. On Fri, 2010-10-22 at 15:43 -0700, Jason Gunthorpe wrote: Trying to use a 64 bit kernel with a 32 bit userspace results in local protection violations reported to the CQ. This is caused by a difference in padding for ipath_rwe, so make the padding 64 bit uses explicit.

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-25 Thread Ralph Campbell
fixing but I think separate patches make sense for those. ---BeginMessage--- If CONFIG_PCI_MSI is not set, and a QLE7140 is present, the pointer dd was uninitialized. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_init.c |1 + 1 files changed, 1

RE: BUG dump from QIB

2010-10-22 Thread Ralph Campbell
. I'll submit a patch to remove the feature :-). From: Jason Gunthorpe [jguntho...@obsidianresearch.com] Sent: Friday, October 22, 2010 1:40 PM To: Ralph Campbell; RDMA list Subject: BUG dump from QIB Hi Ralph, It doesn't look like smp_processor_id

RE: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Ralph Campbell
not set case. From: linux-rdma-ow...@vger.kernel.org [linux-rdma-ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe [jguntho...@obsidianresearch.com] Sent: Friday, October 22, 2010 1:42 PM To: Ralph Campbell; RDMA list Subject: [PATCH] [IB/QIB] Fix failure

RE: [PATCH] [IB/QIB] Fix failure to load driver if PCI error reporting doesn't enable

2010-10-22 Thread Ralph Campbell
pci_enable_pcie_error_reporting() is optional. From: linux-rdma-ow...@vger.kernel.org [linux-rdma-ow...@vger.kernel.org] On Behalf Of Jason Gunthorpe [jguntho...@obsidianresearch.com] Sent: Friday, October 22, 2010 2:36 PM To: Ralph Campbell Cc: RDMA list

RE: [PATCH] [IB/QIB] Process RDMA WRITE ONLY with IMMEDIATE properly

2010-10-22 Thread Ralph Campbell
I don't think it needs the extra blank lines but I agree the code is correct. From: Jason Gunthorpe [jguntho...@obsidianresearch.com] Sent: Friday, October 22, 2010 3:00 PM To: Ralph Campbell; RDMA list Subject: [PATCH] [IB/QIB] Process RDMA WRITE ONLY

[PATCH 1/2] IB/qib: fix uninitialized pointer if CONFIG_PCI_MSI not set

2010-10-22 Thread Ralph Campbell
If CONFIG_PCI_MSI is not set, and a QLE7140 is present, the pointer dd was uninitialized. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_init.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/qib

[PATCH] IB/qib: clean up properly if pci_set_consistent_dma_mask() fails

2010-10-22 Thread Ralph Campbell
From: Jason Gunthorpe jguntho...@obsidianresearch.com Clean up properly if pci_set_consistent_dma_mask() fails. Signed-off-by: Jason Gunthorpe jguntho...@obsidianresearch.com --- drivers/infiniband/hw/qib/qib_pcie.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git

[PATCH] IB/qib: fix RDMA write with immediate

2010-10-22 Thread Ralph Campbell
The immediate word for RDMA_WRITE_ONLY_WITH_IMMEDIATE was being extracted from the wrong location in the header. Thanks to Jason Gunthorpe jguntho...@obsidianresearch.com for finding this. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_rc.c |5

Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-19 Thread Ralph Campbell
On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote: * qib_cq_wq is a separate singlethread workqueue. Does the queue require strict single thread execution ordering? IOW, does each work have to be executed in the exact queued order and no two works should execute in parallel? Or was

RE: [PATCHv10 03/12] ib_core: IBoE UD packet packing support

2010-10-14 Thread Ralph Campbell
From: linux-rdma-ow...@vger.kernel.org [linux-rdma-ow...@vger.kernel.org] On Behalf Of Eli Cohen [...@dev.mellanox.co.il] Sent: Thursday, October 14, 2010 2:57 PM To: Roland Dreier Cc: RDMA list Subject: Re: [PATCHv10 03/12] ib_core: IBoE UD packet

Re: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-09-30 Thread Ralph Campbell
current = 0xc0074b4ce0e0 paca= 0xc0f64a00 pid = 13605, comm = modprobe 12:mon Thanks Pradeep IB/ipoib: fix race when handling IPOIB_CM_RX_DRAIN_WRID From: Ralph Campbell ralph.campb...@qlogic.com ipoib_cm_start_rx_drain() calls ib_post_send() and *then* moves

Re: [PATCH 02/13] drivers/infiniband: Remove unnecessary casts of private_data

2010-09-07 Thread Ralph Campbell
Acked-by: Ralph Campbell ralph.campb...@qlogic.com On Sat, 2010-09-04 at 18:52 -0700, Joe Perches wrote: Signed-off-by: Joe Perches j...@perches.com --- drivers/infiniband/hw/qib/qib_file_ops.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband

RE: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-09-03 Thread Ralph Campbell
. From: Pradeep Satyanarayana [prade...@linux.vnet.ibm.com] Sent: Thursday, September 02, 2010 8:41 PM To: Ralph Campbell Cc: Roland Dreier; linux-rdma@vger.kernel.org Subject: Re: [PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

Re: [PATCH] IB/ipoib: Initialize ipoib_neigh list properly

2010-08-30 Thread Ralph Campbell
You are correct that it needs to be initialized but I think you must have made an error in applying the patch. If you look again at the latest version of the patch this line is present. https://patchwork.kernel.org/patch/120013/ On Tue, 2010-08-24 at 20:51 -0700, Ira Weiny wrote: I applied

Re: [PATCH RFC] ipoib: good references make good neighbors

2010-08-30 Thread Ralph Campbell
The problem with this solution is that it creates a reference counting loop so that the reference count never goes to zero. struct neighbour in the kernel points to struct ipoib_neigh which points back to struct neighbor. If the back pointer holds a reference, then something besides

RE: CQ overrun with ib_send_bw

2010-08-17 Thread Ralph Campbell
Technologies -Original Message- From: Tziporet Koren Sent: Tuesday, August 17, 2010 2:19 PM To: Ralph Campbell; Hefty, Sean; Ido Shamay; Amir Ancel Cc: Sumeet Lahorani; linux-rdma@vger.kernel.org Subject: RE: CQ overrun with ib_send_bw On 8/13/2010 10:21 PM, Ralph Campbell wrote: On Fri

[PATCH v5 0/1] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-08-17 Thread Ralph Campbell
Hopefully, this is the last update needed to this patch and it can be applied. It has been in use within QLogic for several months without problems. Changes from v4 to v5: Removed the break; in ipoib_cm_flush_path() so now the function comment matches the code. Updated the error case code in

[PATCH v5] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-08-17 Thread Ralph Campbell
-neigh==NULL and on priv-cm.reap_task list or being destroyed by ipoib_cm_tx_reap(). Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/ulp/ipoib/ipoib.h | 14 + drivers/infiniband/ulp/ipoib/ipoib_cm.c| 108 ++ drivers/infiniband/ulp/ipoib

Re: [PATCH v5 0/1] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-08-17 Thread Ralph Campbell
BTW, I will be around today and tomorrow to reply to comments but then I will be on vacation through August. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

RE: CQ overrun with ib_send_bw

2010-08-13 Thread Ralph Campbell
On Fri, 2010-08-13 at 12:14 -0700, Hefty, Sean wrote: I know there is a bug with ib_send_bw -b (bi-directional) since it doesn't create a CQ that is large enough for all the posted sends *and* receives. I have tried several times to get the following patch applied but I never got a reply

Re: yet again the atomic operations

2010-08-10 Thread Ralph Campbell
On Tue, 2010-08-10 at 04:46 -0700, Rui Machado wrote: There are two kinds supported. QLogic's driver does them in the host driver so they are atomic with respect to all the CPUs in the host. I'm just curious about this: how does this work? Is the CPU getting interrupted and doing the

Re: yet again the atomic operations

2010-08-06 Thread Ralph Campbell
On Fri, 2010-08-06 at 04:43 -0700, Rui Machado wrote: Hi there, There are two kinds supported. QLogic's driver does them in the host driver so they are atomic with respect to all the CPUs in the host. Mellanox uses HCA wide atomic which means the HCA will do a memory read/write without

Re: {RFC] ibv_post_send()/ibv_post_recv() kernel path optimizations

2010-08-06 Thread Ralph Campbell
On Fri, 2010-08-06 at 03:03 -0700, Walukiewicz, Miroslaw wrote: Currently the ibv_post_send()/ibv_post_recv() path through kernel (using /dev/infiniband/rdmacm) could be optimized by removing dynamic memory allocations on the path. Currently the transmit/receive path works following way:

Re: How to know if SRQ is being used in SRP?

2010-08-05 Thread Ralph Campbell
SRP doesn't use a SRQ. Look at drivers/infiniband/ulp/srp/ib_srp.c for ib_create_qp() and the init_attr.cap.max_recv_wr is set and init_attr.ib_srq is not set. On Thu, 2010-08-05 at 09:38 -0700, Suresh Shelvapille wrote: Folks: I have the envious task of figuring out whether SRQ is being

Re: yet again the atomic operations

2010-08-05 Thread Ralph Campbell
Atomic ops are optional. Mellanox and QLogic HCAs support them, I don't know about the other HCAs. There are two kinds supported. QLogic's driver does them in the host driver so they are atomic with respect to all the CPUs in the host. Mellanox uses HCA wide atomic which means the HCA will do a

[PATCH 2/2] IB/qib: fix race between qib_error_qp() and receive packet processing

2010-08-02 Thread Ralph Campbell
state at the same time, thus leading to kernel panics. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- 0 files changed, 0 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c index e0f65e3..6c39851 100644 --- a/drivers

Re: [RFC PATCH 2/4] uverbs: Add common ib_iomem_get service

2010-07-29 Thread Ralph Campbell
below... On Thu, 2010-07-29 at 12:07 -0700, Tom Tucker wrote: On 7/29/10 1:22 PM, Ralph Campbell wrote: On Thu, 2010-07-29 at 09:25 -0700, Tom Tucker wrote: From: Tom Tuckert...@opengridcomputing.com Add an ib_iomem_get service that converts a vma to an array of physical addresses

Re: [Suspected SPAM] Re: [RFC PATCH 2/4] uverbs: Add common ib_iomem_get service

2010-07-29 Thread Ralph Campbell
On Thu, 2010-07-29 at 13:41 -0700, Jason Gunthorpe wrote: On Thu, Jul 29, 2010 at 03:29:37PM -0500, Tom Tucker wrote: Also, I'd like to see a strong defence of this new user space API particularly: 1) Why can't this be done with the existing ibv_reg_mr, like huge pages are.

Re: [Suspected SPAM] Re: [RFC PATCH 2/4] uverbs: Add common ib_iomem_get service

2010-07-29 Thread Ralph Campbell
On Thu, 2010-07-29 at 15:57 -0700, Jason Gunthorpe wrote: You would need to modify ib_umem_get() to check for the VM_PFNMAP flag and build the struct ib_umem similar to the proposed ib_iomem_get(). However, the page reference counting/sharing issue would need to be solved. I think there

Re: About a shortcoming of the verbs API

2010-07-28 Thread Ralph Campbell
On Wed, 2010-07-28 at 11:05 -0700, Roland Dreier wrote: Actually, I tried to implement the completion callback in a workqueue thread but ipoib_cm_handle_tx_wc() calls netif_tx_lock() which isn't safe unless it is called from an IRQ handler or netif_tx_lock_bh() is called first. Oh,

Re: About a shortcoming of the verbs API

2010-07-28 Thread Ralph Campbell
On Wed, 2010-07-28 at 11:16 -0700, Roland Dreier wrote: Actually, I tried to implement the completion callback in a workqueue thread but ipoib_cm_handle_tx_wc() calls netif_tx_lock() which isn't safe unless it is called from an IRQ handler or netif_tx_lock_bh() is called first.

Re: [PATCH V3] ib_qib: Allow writes to the diag_counters to be able to clear them

2010-07-21 Thread Ralph Campbell
Acked-by: Ralph Campbell ralph.campb...@qlogic.com On Tue, 2010-07-13 at 18:53 -0700, Ira Weiny wrote: From: Ira Weiny wei...@llnl.gov Date: Wed, 7 Jul 2010 17:35:34 -0700 Subject: [PATCH] ib_qib: Allow writes to the diag_counters to be able to clear them Changes in V3: Add non

[PATCH] IB/qib: set cfgctxts to number of CPUs by default

2010-07-21 Thread Ralph Campbell
have 12 cores, the default isn't optimal and should be set to 12 even though 16 hardware contexts need to be enabled. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |2 +- drivers/infiniband/hw/qib/qib_init.c|2 +- 2 files changed, 2

Re: IB/ipoib: fix dangling pointer reference to ipoib_neigh and ipoib_path -when will it go upstream?

2010-07-16 Thread Ralph Campbell
On Fri, 2010-07-16 at 02:13 -0700, Pradeep Satyanarayana wrote: Ralph Campbell wrote: On Thu, 2010-07-15 at 04:56 -0700, Pradeep Satyanarayana wrote: Pradeep Satyanarayana wrote: Pradeep Satyanarayana wrote: Roland Dreier wrote: I guess I came to a premature conclusion. One set

Re: IB/ipoib: fix dangling pointer reference to ipoib_neigh and ipoib_path -when will it go upstream?

2010-07-15 Thread Ralph Campbell
I will write up a description of the locking as I understand it and the changes I made. Give me a day or two to write it up and check it. On Thu, 2010-07-15 at 04:56 -0700, Pradeep Satyanarayana wrote: Pradeep Satyanarayana wrote: Pradeep Satyanarayana wrote: Roland Dreier wrote: I guess

Re: IB/ipoib: fix dangling pointer reference to ipoib_neigh and ipoib_path -when will it go upstream?

2010-07-15 Thread Ralph Campbell
On Thu, 2010-07-15 at 04:56 -0700, Pradeep Satyanarayana wrote: Pradeep Satyanarayana wrote: Pradeep Satyanarayana wrote: Roland Dreier wrote: I guess I came to a premature conclusion. One set of tests ran fine and I made that conclusion. Another set of tests caused the following

[PATCH] IB/qib: if qib_init() fails, driver fails to clean up properly

2010-07-01 Thread Ralph Campbell
and not installing the microcode file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_init.c | 10 ++ 1 files changed, 10 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c

[PATCH] IB/qib: turn off IB latency mode

2010-06-23 Thread Ralph Campbell
Turn off IB latency mode. This improves link quality for slower process chips. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b

[PATCH 0/7] various fixes for QIB driver

2010-06-17 Thread Ralph Campbell
The following patches are for various bug fixes. I'm not sure what counts as a regression for code that is newly introduced. I'm hoping that all except #2 can be made for 2.6.35 whereas #2 can wait for 2.6.36 since it is actually a feature. IB/qib: avoid a rare 7322 chip problem by not marking

[PATCH 1/7] IB/qib: avoid a rare 7322 chip problem by not marking VL15 bufs as WC

2010-06-17 Thread Ralph Campbell
From: Dave Olson dave.ol...@qlogic.com Don't set write combining via PAT on the VL15 buffers to avoid a rare problem with unaligned writes from interrupt-flushed store buffers. Signed-off-by: Dave Olson dave.ol...@qlogic.com --- drivers/infiniband/hw/qib/qib.h |1 +

[PATCH 2/7] IB/qib: allow PSM to select from multiple port assignment algorithms

2010-06-17 Thread Ralph Campbell
From: Dave Olson dave.ol...@qlogic.com We formerly allowed only full specification, or using all contexts within an HCA before moving to the next HCA. We now allow an additional method, of round-robining through HCAs, and make that the default. Signed-off-by: Dave Olson dave.ol...@qlogic.com

[PATCH 3/7] IB/qib: mask hardware error during link reset

2010-06-17 Thread Ralph Campbell
The HCA checks for certain hardware errors which can be falsely triggered when the IB link is reset. The fix is to mask them rather than report them. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_7322_regs.h | 48

[PATCH 4/7] IB/qib: clear eager buffer memory for each new process

2010-06-17 Thread Ralph Campbell
The eager buffers are not being cleared before being mmapped into a new user address space. This is a potential security risk and should be fixed. Note that the eager header queue is already being cleared OK. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib

[PATCH 5/7] IB/qib: clear 6120 hardware error register

2010-06-17 Thread Ralph Campbell
The hardware error register needs to be cleared or another interrupt will be generated, thus causing an infinite loop. This is a regression introduced when removing debug output. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba6120.c |3 +-- 1

[PATCH 6/7] IB/qib: update 7322 serdes tables

2010-06-17 Thread Ralph Campbell
Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 16 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib/qib_iba7322.c index 8ee0ac6..5eedf83

[PATCH 7/7] IB/qib: completion queue callback needs to be single threaded

2010-06-17 Thread Ralph Campbell
. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_init.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_init.c b/drivers/infiniband/hw/qib/qib_init.c index 1d4db4b..7831ff8 100644 --- a/drivers/infiniband

Re: Mellanox implementation for atomic operations

2010-06-16 Thread Ralph Campbell
The ib_qib driver supports atomic IB operations and they are global since it does it in the host software instead of PCIe bus transactions which don't have global atomic support (yet). On Tue, 2010-06-15 at 13:50 -0700, Dotan Barak wrote: Hi. On 10/05/2010 08:42, lihaidong wrote: Hi, I

Re: variable length array in qib

2010-06-02 Thread Ralph Campbell
Sure. I will work on a patch. On Wed, 2010-06-02 at 14:37 -0700, Roland Dreier wrote: qib has the code void qib_disarm_piobufs_set(struct qib_devdata *dd, unsigned long *mask, unsigned cnt) { struct qib_pportdata *ppd,

[PATCH] IB/qib: define max IB ports instead of variable stack allocation

2010-06-02 Thread Ralph Campbell
Rather than use a variable size array allocation on the stack, define a constant for the maximum array size possible. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib.h|3 +++ drivers/infiniband/hw/qib/qib_tx.c |2 +- 2 files changed, 4

[PATCH] IB/qib: fix powerpc compile warnings

2010-05-26 Thread Ralph Campbell
Fix the compile warnings for uninitialized variables in qib_fs.c when compiling for powerpc. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_fs.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infiniband/hw/qib

[PATCH] IB/qib: use a single txselect module parameter for serdes tuning

2010-05-26 Thread Ralph Campbell
with the simpler, single parameter method of setting the serdes parameters. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 582 ++- 1 files changed, 179 insertions(+), 403 deletions(-) diff --git a/drivers/infiniband/hw

Re: [PATCH v4 11/11] IB/qib: Add qib_verbs.h

2010-05-25 Thread Ralph Campbell
On Mon, 2010-05-24 at 21:22 -0700, Roland Dreier wrote: OK, I merged all the qib-related stuff up and put it in my for-next branch. I expect ot send it to Linus soon. Thank you very much! -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

[PATCH] IB/qib: fix undefined symbol error when CONFIG_PCI_MSI undefined

2010-05-25 Thread Ralph Campbell
This patch fixes a compile error saying qib_init_iba6120_funcs() is undefined when CONFIG_PCI_MSI is not defined. Thanks to Randy Dunlap randy.dun...@oracle.com for finding this and suggesting the fix. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib

[PATCH 0/52] IB/qib: add

2010-05-18 Thread Ralph Campbell
The following patches introduce an updated and renamed version of the ipath HCA driver which supports the QLogic PCIe QLE SDR, DDR, and QDR series of HCAs. Rather than try to patch the ipath driver to include support for QDR, multiple ports, bug fixes, and many other structual changes, the ib_qib

[PATCH v4 01/11] IB/qib: Add qib_6120_regs.h

2010-05-18 Thread Ralph Campbell
This creates the qib_6120_regs.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_6120_regs.h | 977 + 1 files changed, 977 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_6120_regs.h

[PATCH v4 02/11] IB/qib: Add qib_7220.h

2010-05-18 Thread Ralph Campbell
creates the qib_7220.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_7220.h | 156 ++ 1 files changed, 156 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_7220.h diff --git

[PATCH v4 06/11] IB/qib: Add qib_diag.c

2010-05-18 Thread Ralph Campbell
creates the qib_diag.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_diag.c | 894 ++ 1 files changed, 894 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_diag.c diff --git

[PATCH v4 07/11] IB/qib: Add qib_dma.c

2010-05-18 Thread Ralph Campbell
creates the qib_dma.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_dma.c | 182 +++ 1 files changed, 182 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_dma.c diff --git

[PATCH v4 09/11] IB/qib: Add qib_init.c

2010-05-18 Thread Ralph Campbell
creates the qib_init.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_init.c | 1580 ++ 1 files changed, 1580 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_init.c diff --git

[PATCH v4 10/11] IB/qib: Add qib_sd7220.c

2010-05-18 Thread Ralph Campbell
creates the qib_sd7220.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_sd7220.c | 1413 1 files changed, 1413 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_sd7220.c diff --git

[PATCH v4 11/11] IB/qib: Add qib_verbs.h

2010-05-18 Thread Ralph Campbell
creates the qib_verbs.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_verbs.h | 1100 + 1 files changed, 1100 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_verbs.h diff --git

[PATCH 0/52] IB/qib: add

2010-05-06 Thread Ralph Campbell
The following patches introduce an updated and renamed version of the ipath HCA driver which supports the QLogic PCIe QLE SDR, DDR, and QDR series of HCAs. Rather than try to patch the ipath driver to include support for QDR, multiple ports, bug fixes, and many other structual changes, the ib_qib

[PATCH v3 01/52] IB/qib: Add Kconfig

2010-05-06 Thread Ralph Campbell
This creates the Kconfig file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/Kconfig | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/Kconfig diff --git a/drivers/infiniband/hw/qib

[PATCH v3 04/52] IB/qib: Add qib_6120_regs.h

2010-05-06 Thread Ralph Campbell
This creates the qib_6120_regs.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_6120_regs.h | 977 + 1 files changed, 977 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_6120_regs.h

[PATCH v3 08/52] IB/qib: Add qib_common.h

2010-05-06 Thread Ralph Campbell
creates the qib_common.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_common.h | 758 1 files changed, 758 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_common.h diff --git

[PATCH v3 09/52] IB/qib: Add qib_cq.c

2010-05-06 Thread Ralph Campbell
creates the qib_cq.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_cq.c | 483 1 files changed, 483 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_cq.c diff --git a/drivers

[PATCH v3 11/52] IB/qib: Add qib_dma.c

2010-05-06 Thread Ralph Campbell
creates the qib_dma.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_dma.c | 182 +++ 1 files changed, 182 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_dma.c diff --git

[PATCH v3 12/52] IB/qib: Add qib_driver.c

2010-05-06 Thread Ralph Campbell
creates the qib_driver.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_driver.c | 665 1 files changed, 665 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_driver.c diff --git

[PATCH v3 13/52] IB/qib: Add qib_eeprom.c

2010-05-06 Thread Ralph Campbell
creates the qib_eeprom.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_eeprom.c | 451 1 files changed, 451 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_eeprom.c diff --git

[PATCH v3 15/52] IB/qib: Add qib_fs.c

2010-05-06 Thread Ralph Campbell
creates the qib_fs.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_fs.c | 613 1 files changed, 613 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_fs.c diff --git a/drivers

[PATCH v3 19/52] IB/qib: Add qib_init.c

2010-05-06 Thread Ralph Campbell
creates the qib_init.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_init.c | 1568 ++ 1 files changed, 1568 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_init.c diff --git

[PATCH v3 20/52] IB/qib: Add qib_intr.c

2010-05-06 Thread Ralph Campbell
creates the qib_intr.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_intr.c | 236 ++ 1 files changed, 236 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_intr.c diff --git

[PATCH v3 21/52] IB/qib: Add qib_keys.c

2010-05-06 Thread Ralph Campbell
creates the qib_keys.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_keys.c | 328 ++ 1 files changed, 328 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_keys.c diff --git

[PATCH v3 26/52] IB/qib: Add qib_pcie.c

2010-05-06 Thread Ralph Campbell
creates the qib_pcie.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_pcie.c | 738 ++ 1 files changed, 738 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_pcie.c diff --git

[PATCH v3 27/52] IB/qib: Add qib_pio_copy.c

2010-05-06 Thread Ralph Campbell
creates the qib_pio_copy.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_pio_copy.c | 64 ++ 1 files changed, 64 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_pio_copy.c diff --git

[PATCH v3 28/52] IB/qib: Add qib_qp.c

2010-05-06 Thread Ralph Campbell
creates the qib_qp.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_qp.c | 1255 1 files changed, 1255 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_qp.c diff --git a/drivers

[PATCH v3 29/52] IB/qib: Add qib_qsfp.c

2010-05-06 Thread Ralph Campbell
creates the qib_qsfp.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_qsfp.c | 564 ++ 1 files changed, 564 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_qsfp.c diff --git

[PATCH v3 32/52] IB/qib: Add qib_ruc.c

2010-05-06 Thread Ralph Campbell
creates the qib_ruc.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_ruc.c | 817 +++ 1 files changed, 817 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_ruc.c diff --git

[PATCH v3 33/52] IB/qib: Add qib_sd7220.c

2010-05-06 Thread Ralph Campbell
creates the qib_sd7220.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_sd7220.c | 1415 1 files changed, 1415 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_sd7220.c diff --git

[PATCH v3 34/52] IB/qib: Add qib_sd7220_img.c

2010-05-06 Thread Ralph Campbell
creates the qib_sd7220_img.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_sd7220_img.c | 1081 1 files changed, 1081 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_sd7220_img.c diff

[PATCH v3 35/52] IB/qib: Add qib_sdma.c

2010-05-06 Thread Ralph Campbell
creates the qib_sdma.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_sdma.c | 973 ++ 1 files changed, 973 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_sdma.c diff --git

[PATCH v3 36/52] IB/qib: Add qib_srq.c

2010-05-06 Thread Ralph Campbell
creates the qib_srq.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_srq.c | 374 +++ 1 files changed, 374 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_srq.c diff --git

[PATCH v3 37/52] IB/qib: Add qib_sysfs.c

2010-05-06 Thread Ralph Campbell
creates the qib_sysfs.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_sysfs.c | 691 + 1 files changed, 691 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_sysfs.c diff --git

[PATCH v3 38/52] IB/qib: Add qib_twsi.c

2010-05-06 Thread Ralph Campbell
creates the qib_twsi.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_twsi.c | 498 ++ 1 files changed, 498 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_twsi.c diff --git

[PATCH v3 40/52] IB/qib: Add qib_uc.c

2010-05-06 Thread Ralph Campbell
creates the qib_uc.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_uc.c | 555 1 files changed, 555 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_uc.c diff --git a/drivers

[PATCH v3 41/52] IB/qib: Add qib_ud.c

2010-05-06 Thread Ralph Campbell
creates the qib_ud.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_ud.c | 607 1 files changed, 607 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_ud.c diff --git a/drivers

[PATCH v3 42/52] IB/qib: Add qib_user_pages.c

2010-05-06 Thread Ralph Campbell
creates the qib_user_pages.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_user_pages.c | 157 1 files changed, 157 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_user_pages.c diff

[PATCH v3 43/52] IB/qib: Add qib_user_sdma.c

2010-05-06 Thread Ralph Campbell
creates the qib_user_sdma.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_user_sdma.c | 897 + 1 files changed, 897 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_user_sdma.c diff

[PATCH v3 44/52] IB/qib: Add qib_user_sdma.h

2010-05-06 Thread Ralph Campbell
creates the qib_user_sdma.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_user_sdma.h | 52 + 1 files changed, 52 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_user_sdma.h diff

[PATCH v3 46/52] IB/qib: Add qib_verbs.h

2010-05-06 Thread Ralph Campbell
creates the qib_verbs.h file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_verbs.h | 1099 + 1 files changed, 1099 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_verbs.h diff --git

[PATCH v3 47/52] IB/qib: Add qib_verbs_mcast.c

2010-05-06 Thread Ralph Campbell
creates the qib_verbs_mcast.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_verbs_mcast.c | 368 +++ 1 files changed, 368 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_verbs_mcast.c

[PATCH v3 49/52] IB/qib: Add qib_wc_x86_64.c

2010-05-06 Thread Ralph Campbell
creates the qib_wc_x86_64.c file. Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/hw/qib/qib_wc_x86_64.c | 171 + 1 files changed, 171 insertions(+), 0 deletions(-) create mode 100644 drivers/infiniband/hw/qib/qib_wc_x86_64.c diff

[PATCH v3 50/52] IB/qib: Hooks for adding the QIB driver into the framework

2010-05-06 Thread Ralph Campbell
Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- drivers/infiniband/Kconfig |1 + drivers/infiniband/Makefile |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig index 975adce..3a04822 100644

[PATCH v3 52/52] IB/core: allow HCAs to create IB port sysfs files

2010-05-06 Thread Ralph Campbell
This patch adds a new parameter to ib_register_device() so that HCAs can create files in /sys/class/infiniband/hca/ports/N/. There is no need for an unregister function since the kobject reference will go to zero when ib_unregister_device() is called. Signed-off-by: Ralph Campbell ralph.campb

[PATCH v4] IB/ipoib: fix dangling pointer references to ipoib_neigh and ipoib_path

2010-05-05 Thread Ralph Campbell
) not on the start_list, flags==0, and in the process of creating the RC QP. 3) not on the start_list, flags IPOIB_FLAG_INITIALIZED, and RC QP created. 4) on the priv-cm.reap_task list or being destroyed by ipoib_cm_tx_reap(). Signed-off-by: Ralph Campbell ralph.campb...@qlogic.com --- I updated the description

  1   2   >