For cxgb3,
Acked-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 6/15/2014 9:26 PM, Nick wrote:
This patch fixes memory by checking in function,
*get_skuff if it is be passing a Null skb
struct.
Cheers Nick
Signed-off-by: Nick xerofo...@gmail.com
---
drivers/infiniband/hw/cxgb4/cm.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git
On 6/16/2014 10:03 AM, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/infiniband/hw/cxgb4/cm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index
On 6/16/2014 10:14 AM, Nick Krause wrote:
From what I know yes so I would close the bug at the the link in
my previous email and just void my patch.
Cheers Nick
We shouldn't be kfree-ing an skb anyway. Should use kfree_skb().
There is still a leak if skb is non-null and the skb is non
On 6/16/2014 10:25 AM, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/infiniband/hw/cxgb4/cm.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index
On 6/16/2014 12:06 PM, Nicholas Krause wrote:
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index f9477e2..2d56983 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -340,15 +340,13 @@ static int status2errno(int status)
On 6/16/2014 10:45 AM, Nick Krause wrote:
Can we close this bug or is it still a issue as we can'
return NULL from kfree or kfree_skb. Here is the bug
ID 44631 I would close it if we are done with the bug
otherwise I think there are no other issues with
allocating a skb,
In what database is
On 6/16/2014 12:49 PM, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/infiniband/hw/cxgb4/cm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index
On 6/16/2014 1:30 PM, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/infiniband/hw/cxgb4/cm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index
On 6/16/2014 1:34 PM, Steve Wise wrote:
On 6/16/2014 1:30 PM, Nicholas Krause wrote:
Signed-off-by: Nicholas Krause xerofo...@gmail.com
---
drivers/infiniband/hw/cxgb4/cm.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/cxgb4/cm.c
b/drivers
On 6/12/2014 2:54 PM, Mark Lehrer wrote:
Awesome work on nfs-rdma in the later kernels! I had been having
panic problems for awhile and now things appear to be quite reliable.
Now that things are more reliable, I would like to help work on speed
issues. On this same hardware with SMB Direct
Hey Sean/Roland,
Does this look good for 3.16?
Steve.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
[mailto:linux-rdma-ow...@vger.kernel.org] On
Behalf Of Hefty, Sean
Sent: Tuesday, June 10, 2014 10:09 AM
To: Steve Wise; Roland Dreier
Cc: linux-rdma@vger.kernel.org
Subject: RE: [PATCH] rdma-cma/iw_cm: export tos field
Hi Steve, Tatyana
Reading this cover letter, I think it's good idea to follow Steve's
suggestion and add portions from here into the IB/core change you
introduced (patch #1 in this series) and is now merged into Roland's
for-next -- before Roland's sends his 3.16 merge window pull request
-Original Message-
From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com]
Sent: Monday, June 09, 2014 11:51 AM
To: Or Gerlitz
Cc: Tatyana Nikolova; Steve Wise; Roland Dreier; Lacombe, John S; Sean Hefty;
linux-rdma
Subject: Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper
-Original Message-
From: Christoph Lameter [mailto:c...@gentwo.org]
Sent: Monday, June 09, 2014 1:11 PM
To: Jason Gunthorpe
Cc: Or Gerlitz; Tatyana Nikolova; Steve Wise; Roland Dreier; Lacombe, John S;
Sean
Hefty;
linux-rdma
Subject: Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper
-Original Message-
From: Christoph Lameter [mailto:c...@gentwo.org]
Sent: Monday, June 09, 2014 1:28 PM
To: Steve Wise
Cc: 'Jason Gunthorpe'; 'Or Gerlitz'; 'Tatyana Nikolova'; 'Roland Dreier';
'Lacombe, John
S';
'Sean Hefty'; 'linux-rdma'
Subject: RE: [PATCH 0/3] RDMA/core
On 6/7/2014 2:40 PM, Or Gerlitz wrote:
Tatyana Nikolova tatyana.e.nikol...@intel.com wrote:
The patch adds support for iWarp Port Mapper user space service
Reading the change-log below, I noted that pretty much nothing in it
explains what
is the role of this port mapper, with that presentation
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/core/cma.c |2 ++
include/rdma/iw_cm.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index d570030..beda319 100644
-Original Message-
From: Bart Van Assche [mailto:bvanass...@acm.org]
Sent: Thursday, June 05, 2014 2:23 AM
To: Steve Wise; bfie...@fieldses.org
Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org;
t...@opengridcomputing.com
Subject: Re: [PATCH] svcrdma: Fence LOCAL_INV work
This applies on top of:
commit e5a070216356dbcb03607cb264cc3104e17339b3
Author: Steve Wise sw...@opengridcomputing.com
Date: Wed May 28 15:12:01 2014 -0500
svcrdma: refactor marshalling logic
Fencing forces the invalidate to only happen after all prior send
On 6/5/2014 8:55 AM, Steve Wise wrote
-Original Message-
From: Bart Van Assche [mailto:bvanass...@acm.org]
Sent: Thursday, June 05, 2014 2:23 AM
To: Steve Wise; bfie...@fieldses.org
Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org;
t...@opengridcomputing.com
Subject: Re: [PATCH
-Original Message-
From: J. Bruce Fields [mailto:bfie...@fieldses.org]
Sent: Thursday, June 05, 2014 11:14 AM
To: Steve Wise
Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org;
t...@opengridcomputing.com
Subject: Re: [PATCH V2] svcrdma: Fence LOCAL_INV work requests
On 6/4/2014 3:52 AM, Selvin Xavier wrote:
This patch series contains bug fixes for ocrdma driver.
Seems like the subject lines in each patch are getting truncated?
Like this:
Subject: [PATCH for-next 01/15] RDMA/ocrdma: Avoid posting DPP requests for
Steve.
--
To unsubscribe from this
to be in the current upstream code as
well. If an
IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it until the
prior read
completes.
Good catch! I'll post V4 soon.
Regards
Devesh
From: Steve Wise [sw...@opengridcomputing.com]
Sent
You're correct. And this bug appears to be in the current upstream code as
well. If
an
IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it until
the prior
read
completes.
Good catch! I'll post V4 soon.
Any chance that can be handled as a separate patch
On Mon, Jun 02, 2014 at 11:52:47AM -0500, Steve Wise wrote:
You're correct. And this bug appears to be in the current upstream
code as well.
If
an
IB_WR_LOCAL_INV wr is used, it must include IB_SEND_FENCE to fence it
until the
prior
read
completes.
Good catch
This applies on top of:
commit e5a070216356dbcb03607cb264cc3104e17339b3
Author: Steve Wise sw...@opengridcomputing.com
Date: Wed May 28 15:12:01 2014 -0500
svcrdma: refactor marshalling logic
Fencing forces the invalidate to only happen after all subsequent
-course
after putting a FENCE
indicator.
-Regards
Devesh
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Steve Wise
Sent: Thursday, May 29, 2014 10:26 PM
To: bfie...@fieldses.org
Cc: linux-...@vger.kernel.org
should all be a single commit anyway.
Please review, and test if you can. I'd like this to hit 3.16.
Signed-off-by: Tom Tucker t...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
include/linux/sunrpc/svc_rdma.h |3
net/sunrpc/xprtrdma
I tested this series over cxgb4 and mlx4, running cthon04, fio read/rand-rw,
and xfstests, and over mthca cthon04. No regressions.
Tested-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord
://patchwork.kernel.org/patch/4266551/
Steve
-Original Message-
From: Devesh Sharma [mailto:devesh.sha...@emulex.com]
Sent: Thursday, May 29, 2014 1:28 PM
To: Steve Wise; 'Chuck Lever'; linux-...@vger.kernel.org;
linux-rdma@vger.kernel.org
Cc: anna.schuma...@netapp.com
Subject: RE: [PATCH
Acked-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
[mailto:linux-rdma-ow...@vger.kernel.org] On
Behalf Of Roland Dreier
Sent: Monday, May 19, 2014 8:10 PM
To: Tatyana Nikolova
Cc: Lacombe, John S; Steve Wise; Sean Hefty; linux-rdma@vger.kernel.org
Subject: Re: [PATCH 0/3
-Original Message-
From: linux-nfs-ow...@vger.kernel.org
[mailto:linux-nfs-ow...@vger.kernel.org] On Behalf
Of Devesh Sharma
Sent: Monday, May 19, 2014 2:07 PM
To: Steve Wise; J. Bruce Fields
Cc: linux-...@vger.kernel.org; linux-rdma@vger.kernel.org;
t...@opengridcomputing.com
depth
From: Steve Wise sw...@opengridcomputing.com
Some rdma devices don't support a fast register page list depth of at least
RPCRDMA_MAX_DATA_SEGS. So xprtrdma needs to chunk its fast register
regions according to the minimum of the device max supported depth or
RPCRDMA_MAX_DATA_SEGS.
Signed-off
By the way, Devesh: Is the device advertising FRMR support, yet setting
the max page list len to zero? That's a driver bug...
On 5/16/2014 9:10 AM, Steve Wise wrote:
I guess the client code doesn't verify that the device supports the
chosen memreg mode. That's not good. Lemme fix
not support FRMRs?
Steve.
On 5/16/2014 9:14 AM, Steve Wise wrote:
By the way, Devesh: Is the device advertising FRMR support, yet
setting the max page list len to zero? That's a driver bug...
On 5/16/2014 9:10 AM, Steve Wise wrote:
I guess the client code doesn't verify that the device
RDMA connections over a vlan interface don't work due to
import_ep() not using the correct egress device.
- use the real device in import_ep()
- use rdma_vlan_dev_real_dev() in get_real_dev().
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 17
On 5/13/2014 4:44 PM, Chuck Lever wrote:
+static int rdma_read_chunks(struct svcxprt_rdma *xprt,
+ struct rpcrdma_msg *rmsgp,
+ struct svc_rqst *rqstp,
+ struct svc_rdma_op_ctxt *head)
{
- struct ib_send_wr
If you print ch_count, it is 2 for NFS WRITEs from a Linux client,
no matter how large the write payload is. Therefore I think the check
as it is written is not particularly useful.
Why are there 2?
The first chunk lists the pages the server is to read, and the second
chunk has
So the code as it stands violates the RFC by sending 2 chunks?
The Linux client is non-compliant because it sends two chunks. A compliant
server
ignores the
second chunk, so this is functionally harmless (but a waste of resources).
The Linux server is non-compliant because it
-Original Message-
From: Chuck Lever [mailto:chuckle...@gmail.com]
Sent: Tuesday, May 13, 2014 1:22 PM
To: Steve Wise
Cc: J. Bruce Fields; Linux NFS Mailing List; linux-rdma@vger.kernel.org; Tom
Tucker
Subject: Re: [PATCH V2 RFC 2/3] svcrdma: Recvfrom changes
Hi Steve-
Some
Tucker t...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 633 +--
1 files changed, 259 insertions(+), 374 deletions(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
b/net/sunrpc
think these changes
should all be a single commit anyway.
Please review, and test if you can.
Signed-off-by: Tom Tucker t...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
Tom Tucker (3):
svcrdma: Sendto changes
svcrdma: Recvfrom changes
svcrdma
...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
include/linux/sunrpc/svc_rdma.h |3 -
net/sunrpc/xprtrdma/svc_rdma_transport.c | 62 +-
2 files changed, 37 insertions(+), 28 deletions(-)
diff --git a/include/linux/sunrpc/svc_rdma.h
From: Tom Tucker t...@opengridcomputing.com
Don't use fast-register mrs for the source of RDMA writes and sends.
Instead, use either a local dma lkey or a dma_mr lkey based on what the
device supports.
Signed-off-by: Tom Tucker t...@opengridcomputing.com
Signed-off-by: Steve Wise sw
On 5/6/2014 2:21 PM, J. Bruce Fields wrote:
On Tue, May 06, 2014 at 12:46:27PM -0500, Steve Wise wrote:
From: Tom Tucker t...@opengridcomputing.com
Change poll logic to grab up to 6 completions at a time.
RDMA write and send completions no longer deal with fastreg objects.
Set
On 5/6/2014 2:27 PM, J. Bruce Fields wrote:
On Tue, May 06, 2014 at 12:46:21PM -0500, Steve Wise wrote:
This patch series refactors the NFSRDMA server marshalling logic to
remove the intermediary map structures. It also fixes an existing bug
where the NFSRDMA server was not minding the device
snip
diff --git a/drivers/infiniband/hw/cxgb4/provider.c
b/drivers/infiniband/hw/cxgb4/provider.c
index a94a3e12c349..9ba01d524f51 100644
--- a/drivers/infiniband/hw/cxgb4/provider.c
+++ b/drivers/infiniband/hw/cxgb4/provider.c
@@ -122,7 +122,7 @@ static struct ib_ucontext
This chunk doesn't apply. Not sure why. I can use -F 6 with patch, but it
should apply
cleanly. Can you please respin this against 89ca3b8 Linux 3.15-rc4?
I've hand-edited it before sending, but I've tested it with git am
against linux-next (as of today).
Anyway, I'm rolling an
Acked-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Acked-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Applied. Thanks!
Steve.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
are built against Roland's infiniband tree for-next branch.
Thank you,
Tatyana Nikolova (2):
RDMA/core: Add support for iWarp Port Mapper V2 user space service
RDMA/nes: Add support for iWarp Port Mapper V2 user space service
Steve Wise (1):
RDMA/cxgb4: Add support for iWarp Port Mapper V2
Hey Roland, do these 3 bug fixes look good for 3.15?
Thanks,
Steve.
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4/25/2014 8:24 AM, Chuck Lever wrote:
Hi Bruce-
On Apr 25, 2014, at 6:58 AM, J. Bruce Fields bfie...@fieldses.org wrote:
On Thu, Apr 10, 2014 at 01:37:23PM -0500, Steve Wise wrote:
From: Tom Tucker t...@ogc.us
This patch refactors the marshalling logic to remove the intermediary
map
to abort_connection() do so with the mutex held.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 31 ---
drivers/infiniband/hw/cxgb4/iw_cxgb4.h |1 +
drivers/infiniband/hw/cxgb4/qp.c |9 +
3 files
This is required to work around a T5 HW issue.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c |8
drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 14 ++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git
The whole db drop avoidance stuff is for T4 only. So we cannot allow
that to be enabled for T5 devices.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/qp.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw
to abort_connection() do so with the mutex held.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c | 31 ---
drivers/infiniband/hw/cxgb4/iw_cxgb4.h |1 +
drivers/infiniband/hw/cxgb4/qp.c |9 +
3 files
This is required to work around a T5 HW issue.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/cm.c |8
drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 14 ++
2 files changed, 22 insertions(+), 0 deletions(-)
diff --git
The whole db drop avoidance stuff is for T4 only. So we cannot allow
that to be enabled for T5 devices.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/qp.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/hw
-by: Christoph Jaeger christophjae...@linux.com
Acked-by: Steve Wise sw...@opengridcomputing.com
thanks!
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I know bruce is off-line, but does anyone else have comments? Can anyone else
test this?
Thanks,
Steve.
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
[mailto:linux-rdma-ow...@vger.kernel.org] On
Behalf Of Steve Wise
Sent: Thursday, April 17, 2014 12:59 PM
To: bfie
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
[mailto:linux-rdma-ow...@vger.kernel.org] On
Behalf Of Chuck Lever
Sent: Thursday, April 17, 2014 8:55 AM
To: Sagi Grimberg
Cc: Steve Wise; Linux NFS Mailing List; linux-rdma@vger.kernel.org
Subject: Re: [PATCH 7/8
Tested-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On 4/16/2014 7:48 AM, Sagi Grimberg wrote:
On 4/15/2014 1:23 AM, Chuck Lever wrote:
The current CQ handler uses the ib_wc.opcode field to distinguish
between event types. However, the contents of that field are not
reliable if the completion status is not IB_WC_SUCCESS.
When an error
-Original Message-
From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il]
Sent: Wednesday, April 16, 2014 9:13 AM
To: Steve Wise; Chuck Lever; linux-...@vger.kernel.org;
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 7/8] xprtrdma: Split the completion queue
On 4/16/2014 4:30 PM
Hmm, But if either FASTREG or LINV failed the QP will go to error state
and you *will* get the error wc (with a rain of FLUSH errors).
AFAICT it is safe to assume that it succeeded as long as you don't get
error completions.
But if an unsignaled FASTREG is posted and silently succeeds,
-Original Message-
From: Sagi Grimberg [mailto:sa...@dev.mellanox.co.il]
Sent: Wednesday, April 16, 2014 10:18 AM
To: Steve Wise; 'Chuck Lever'; linux-...@vger.kernel.org;
linux-rdma@vger.kernel.org
Subject: Re: [PATCH 7/8] xprtrdma: Split the completion queue
On 4/16/2014 5:43
-off-by: Steve Wise sw...@opengridcomputing.com
---
net/sunrpc/xprtrdma/verbs.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/net/sunrpc/xprtrdma/verbs.c b/net/sunrpc/xprtrdma/verbs.c
index 9b038e1..65ce677 100644
--- a/net/sunrpc/xprtrdma/verbs.c
+++ b/net/sunrpc
Tested-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
My testing was with the default memory registration mode by the way.
Over mlx4 and cxgb4.
Steve.
On 4/15/2014 3:15 PM, Steve Wise wrote:
Tested-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message
changes to rpcrdma_register_external() that were unnecessary
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
net/sunrpc/xprtrdma/rpc_rdma.c |4 ---
net/sunrpc/xprtrdma/verbs.c | 47 +--
net/sunrpc/xprtrdma/xprt_rdma.h |1 +
3 files changed
On 4/9/2014 7:26 PM, Chuck Lever wrote:
On Apr 9, 2014, at 7:56 PM, Devesh Sharma devesh.sha...@emulex.com wrote:
Hi Chuk and Trond
I will resend a v2 for this.
What if ib_post_send() fails with immidate error, I that case also
DECR_CQCOUNT() will be called but no completion will be
Some rdma devices don't support a fast register page list depth of
at least RPCRDMA_MAX_DATA_SEGS. So xprtrdma needs to chunk its fast
register regions according to the minimum of the device max supported
depth or RPCRDMA_MAX_DATA_SEGS.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Thursday, April 10, 2014 12:44 PM
To: Steve Wise
Cc: Devesh Sharma; Linux NFS Mailing List; linux-rdma@vger.kernel.org; Trond
Myklebust
Subject: Re: [PATCH V1] NFS-RDMA: fix qp pointer validation checks
From: Tom Tucker t...@ogc.us
This patch refactors the marshalling logic to remove the intermediary
map structures. It also fixes an existing bug where the NFSRDMA server
was not minding the device fast register page list length limitations.
Signed-off-by: Tom Tucker t...@ogc.us
---
Need to get the endpoint reference before calling
rdma_fini(), which might fail causing us to not
get the reference.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/qp.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers
Current hardware doesn't correctly support DSGL.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
drivers/infiniband/hw/cxgb4/mem.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/infiniband/hw/cxgb4/mem.c
b/drivers/infiniband/hw/cxgb4/mem.c
index
;
kuma...@chelsio.com; nirran...@chelsio.com
Subject: Re: [PATCH 8/8] iw_cxgb4: Use uninitialized_var()
Le mercredi 26 mars 2014 à 18:53 +0530, Hariprasad Shenai a écrit :
From: Steve Wise sw...@opengridcomputing.com
What for ? Please describe the reason to use uninitialized_var()
Function
Acked-by: Steve Wise sw...@opengridcomputing.com
Note: This fix applies only to net-next because the commit that introduced this
is still
pending in net-next:
commit 05eb23893c2cf9502a9cec0c32e7f1d1ed2895c8
Author: Steve Wise sw...@opengridcomputing.com
Date: Fri Mar 14 21:52:08 2014 +0530
+ uresp.status_page_size = PAGE_SIZE;
+
+ spin_lock(context-mmap_lock);
+ uresp.status_page_key = context-key;
+ context-key += PAGE_SIZE;
+ spin_unlock(context-mmap_lock);
+
Is it really necessary to spinlock here since context
-Original Message-
From: linux-rdma-ow...@vger.kernel.org
[mailto:linux-rdma-ow...@vger.kernel.org] On
Behalf Of Or Gerlitz
Sent: Monday, March 24, 2014 2:16 AM
To: Roland Dreier
Cc: Bart Van Assche; linux-rdma
Subject: device removal hangs where there are open uverbs refs
Hi
to db_state_str - thanks
to review by Steve Wise
In patch 10/31, t4_db_dropped() needs to disable dbs and send DB_FULL
event to iw_cxgb4 - thanks to review by Steve Wise
V5:
Dropped patch cxgb4: use spinlock_irqsave/spinlock_irqrestore for db
lock.
I do not see the spinlock patch
Added module option named adjust_win, defaulted to 1, that allows
disabling the 40G window bump. This allows a user to specify the exact
default window sizes via module options snd_win and rcv_win.
This is terrible. As is the existing other TCP tweaking module
parameters.
You can
You can just use the TCP settings the kernel already provides for
the real TCP stack.
Do you mean use sysctl_tcp_*mem, sysctl_tcp_timestamps,
sysctl_tcp_window_scaling,
etc?
I'll look into this.
And the socket memory limits, which we use to compute default window
sizes.
How's
How's this look (compile-tested only)? Note I had to export some of the
tcp limits.
Well, the problem is that you've dug your own hole already.
You can't just remove these existing module parameters that users can
set. They are user visible APIs, you can't just remove them.
The
with an md5sum of:
a78cace976958f562ec7861b4105909f
The git tree is available at:
git://www.openfabrics.org/~swise/libcxgb4
The tag is v1.3.3
This release contains one (important) bug fix from 1.3.2:
commit 98cea522707232b99ff5c07dd9f57937aa8a7d91
Author: Steve Wise sw...@opengridcomputing.com
Dropped patch cxgb4: use spinlock_irqsave/spinlock_irqrestore
for db
lock.
save/restore spinlock variants are not required - thanks to
review by
David Miller.
That is absolutely not what I said.
I said that specific instances of the transformation were not correct,
the
On 3/7/2014 2:41 PM, Steve Wise wrote:
Does this help?
They must have added this for some reason, but I'm not seeing how it
could have ever done anything
--b.
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index 0ce7552..e8f25ec 100644
I removed your change and started debugging original crash that
happens on top-o-tree. Seems like rq_next_pages is screwed up. It
should always be = rq_respages, yes? I added a BUG_ON() to assert
this in rdma_read_xdr() we hit the BUG_ON(). Look
crash svc_rqst.rq_next_page
On 3/8/2014 1:20 PM, Steve Wise wrote:
I removed your change and started debugging original crash that
happens on top-o-tree. Seems like rq_next_pages is screwed up. It
should always be = rq_respages, yes? I added a BUG_ON() to assert
this in rdma_read_xdr() we hit the BUG_ON(). Look
Resurrecting an old issue :)
More inline below...
-Original Message-
From: linux-nfs-ow...@vger.kernel.org [mailto:linux-nfs-
ow...@vger.kernel.org] On Behalf Of J. Bruce Fields
Sent: Thursday, February 07, 2013 10:42 AM
To: Yan Burman
Cc: linux-...@vger.kernel.org;
Does this help?
They must have added this for some reason, but I'm not seeing how it
could have ever done anything
--b.
diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
index 0ce7552..e8f25ec 100644
---
BTW, if you're frustrated from having to send these patches so many
times because of changes being requested, this is the main reason
why you shouldn't queue up such enormous numbers of patches at one
time.
Please try to keep your future submissions sizes more reasonable,
perhaps ~10
memory.
Changes from V1:
- allocate new send/recv buffers for the Final Sync message.
- post the Final Sync recv buffer at the beginning of the final iteration
of a test.
- tests ok on cxgb4 and mlx4 devices.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
test/dapltest/test
Hey Arlin,
I'd like to get this fix into OFED-3.12 if possible.
Thanks,
Steve.
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Steve Wise
Sent: Monday, March 03, 2014 10:13 AM
To: arlin.r.da...@intel.com
Cc
.
Similar logic is probably needed for the performance tests as well.
Signed-off-by: Steve Wise sw...@opengridcomputing.com
---
test/dapltest/test/dapl_transaction_stats.c | 10 ++
test/dapltest/test/dapl_transaction_test.c | 139 +++
2 files changed, 149 insertions
301 - 400 of 833 matches
Mail list logo
