Re: [PATCH 0/8] Critical bug fixes for RDMA/cxgb4

2013-08-08 Thread Vipul Pandya
On 07-08-2013 01:45, Or Gerlitz wrote: > On Tue, Aug 6, 2013 at 6:34 PM, Vipul Pandya wrote: > > [...] > >> The patch-series is based on Roland's infiniband tree for-next branch. >> This series is on top of previously submitted series "Add IPv6 support for

Re: [PATCH 0/8] Critical bug fixes for RDMA/cxgb4

2013-08-08 Thread Vipul Pandya
On 06-08-2013 23:12, Roland Dreier wrote: > On Tue, Aug 6, 2013 at 8:34 AM, Vipul Pandya wrote: > >> This series is on top of previously submitted series "Add IPv6 support for >> iWARP" which can be found at following location: >> http://comments.gmane.or

[PATCH 2/8] RDMA/cxgb4: Handle newer firmware changes

2013-08-06 Thread Vipul Pandya
d-off-by: Steve Wise Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 5 ++--- drivers/infiniband/hw/cxgb4/ev.c | 10 -- 2 files changed, 2 insertions(+), 13 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 31dee27..1b

[PATCH 3/8] RDMA/cxgb4: Fix QP flush logic

2013-08-06 Thread Vipul Pandya
have not already been flushed. Since we already track where in the SQ we've flushed via sq.cidx_flush, just start at that point and flush any remaining. This bug only caused a problem in the presence of unsignaled work requests. Signed-off-by: Steve Wise Signed-off-by: Vipul P

[PATCH 5/8] RDMA/cxgb4: Set arp error handler for PASS_ACCEPT_RPL messages.

2013-08-06 Thread Vipul Pandya
From: Steve Wise accept_cr() failed to set the arp error handler on a reused skb. This results in a kernel crash if the arp does indeed time out. Signed-off-by: Steve Wise Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PATCH 1/8] RDMA/cxgb4: Use correct bit shift macros for vlan filter tuples

2013-08-06 Thread Vipul Pandya
From: Steve Wise Signed-off-by: Steve Wise --- drivers/infiniband/hw/cxgb4/cm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 9423441..31dee27 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/driv

[PATCH 7/8] RDMA/cxgb4: Advertise ~0ULL as max MR size.

2013-08-06 Thread Vipul Pandya
From: Steve Wise Lustre uses a advertised max MR size of ~0ULL to indicate it should use a dma_mr. Hence advertise max MR size as ~0ULL. Signed-off-by: Steve Wise Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/t4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 4/8] RDMA/cxgb4: Account for unsignled SQ WRs that fails to deal with wrap

2013-08-06 Thread Vipul Pandya
From: Steve Wise When determining how many WRs are completed with a signaled CQE, correctly deal with queue wraps. Signed-off-by: Steve Wise Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cq.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 0/8] Critical bug fixes for RDMA/cxgb4

2013-08-06 Thread Vipul Pandya
review comments. Thanks, Vipul Pandya Steve Wise (8): RDMA/cxgb4: Use correct bit shift macros for vlan filter tuples RDMA/cxgb4: Handle newer firmware changes RDMA/cxgb4: Fix QP flush logic RDMA/cxgb4: Account for unsignled SQ WRs that fails to deal with wrap RDMA/cxgb4: Set arp er

[PATCH 6/8] RDMA/cxgb4: Always do GTS write if cidx_inc == CIDXINC_MASK.

2013-08-06 Thread Vipul Pandya
-off-by: Steve Wise Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/t4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/t4.h b/drivers/infiniband/hw/cxgb4/t4.h index 3a6a289..1272dfe 100644 --- a/drivers/infiniband/hw/cxgb4/t4.h +++ b

[PATCH 8/8] RDMA/cxgb4: Issue RI.FINI before closing when entering TERM

2013-08-06 Thread Vipul Pandya
From: Steve Wise Signed-off-by: Steve Wise Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/qp.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 22d1f01..5829367 100644 --- a/drivers

[PATCH V3 4/4] RDMA/cxgb4: Add support for active and passive open connection with IPv6 address

2013-07-04 Thread Vipul Pandya
listen_stop. Add support for iWARP over VLAN device and enable IPv6 support on VLAN device. Make use of import_ep in c4iw_reconnect. Signed-off-by: Vipul Pandya --- V2: Used local variables instead of typecasting in patch 1/4. V3: Removed dereferencing ep before initializing it in patch 4/4. drivers

[PATCH V3 2/4] cxgb4: Add routines to create and remove listening IPv6 servers

2013-07-04 Thread Vipul Pandya
it can be treated as an error and ULD can free STID which can result into an error in passive open reply. Add cpl structure for active open request with IPv6 address for T5. Signed-off-by: Vipul Pandya --- V2: Used local variables instead of typecasting in patch 1/4. V3: Removed dereferencing ep

[PATCH V3 1/4] RDMA/cma: Add IPv6 support for iWARP.

2013-07-04 Thread Vipul Pandya
From: Steve Wise This patch modifies the type of local_addr and remote_addr fields in struct iw_cm_id from struct sockaddr_in to struct sockaddr_storage to hold IPv6 and IPv4 addresses uniformly. It changes the references of local_addr and remote_addr in RDMA/cxgb4, RDMA/cxgb3, RDMA/nes and amso

[PATCH V3 3/4] cxgb4: Add CLIP support to store compressed IPv6 address

2013-07-04 Thread Vipul Pandya
P and the one stored in the CLIP region. Signed-off-by: Vipul Pandya --- V2: Used local variables instead of typecasting in patch 1/4. V3: Removed dereferencing ep before initializing it in patch 4/4. drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 1 + drivers/net/ethernet/chelsio/

[PATCH V3 0/4] Add IPv6 support for iWARP

2013-07-04 Thread Vipul Pandya
ubmit this patch series via Roland's infiniband tree for-next branch. We have included all the maintainers of respective drivers. Kindly review the change and let us know in case of any review comments. Thanks, Vipul Pandya V2: Used local variables instead of typecasting in patch 1/4. V

Re: [PATCH V2 0/4] Add IPv6 support for iWARP

2013-07-02 Thread Vipul Pandya
On 02-07-2013 12:37, David Miller wrote: > From: Vipul Pandya > Date: Tue, 02 Jul 2013 12:17:57 +0530 > >> I upgraded my GCC version from 4.4.6-4 to 4.8.1 and after that I am able >> to see that warning. I will resubmit this series soon. > > That's fine, but

Re: [PATCH V2 0/4] Add IPv6 support for iWARP

2013-07-01 Thread Vipul Pandya
On 20-06-2013 19:07, Vipul Pandya wrote: > > > On 20-06-2013 09:38, David Miller wrote: >> From: Steve Wise >> Date: Wed, 19 Jun 2013 21:19:13 -0500 >> >>> On 6/19/2013 8:01 PM, David Miller wrote: >>>> From: Vipul Pandya >>>> Date:

Re: [PATCH V2 0/4] Add IPv6 support for iWARP

2013-06-20 Thread Vipul Pandya
On 20-06-2013 09:38, David Miller wrote: > From: Steve Wise > Date: Wed, 19 Jun 2013 21:19:13 -0500 > >> On 6/19/2013 8:01 PM, David Miller wrote: >>> From: Vipul Pandya >>> Date: Wed, 12 Jun 2013 17:11:38 +0530 >>> >>>> We have incl

[PATCH V2 1/4] RDMA/cma: Add IPv6 support for iWARP.

2013-06-12 Thread Vipul Pandya
From: Steve Wise This patch modifies the type of local_addr and remote_addr fields in struct iw_cm_id from struct sockaddr_in to struct sockaddr_storage to hold IPv6 and IPv4 addresses uniformly. It changes the references of local_addr and remote_addr in RDMA/cxgb4, RDMA/cxgb3, RDMA/nes and amso

[PATCH V2 3/4] cxgb4: Add CLIP support to store compressed IPv6 address

2013-06-12 Thread Vipul Pandya
P and the one stored in the CLIP region. Signed-off-by: Vipul Pandya --- V2: Used local variables instead of typecasting in patch 1/4. drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 206 drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h | 23 +++ 2 files changed

[PATCH V2 4/4] RDMA/cxgb4: Add support for active and passive open connection with IPv6 address

2013-06-12 Thread Vipul Pandya
listen_stop. Add support for iWARP over VLAN device and enable IPv6 support on VLAN device. Make use of import_ep in c4iw_reconnect. Signed-off-by: Vipul Pandya --- V2: Used local variables instead of typecasting in patch 1/4. drivers/infiniband/hw/cxgb4/cm.c | 805

[PATCH V2 2/4] cxgb4: Add routines to create and remove listening IPv6 servers

2013-06-12 Thread Vipul Pandya
it can be treated as an error and ULD can free STID which can result into an error in passive open reply. Add cpl structure for active open request with IPv6 address for T5. Signed-off-by: Vipul Pandya --- V2: Used local variables instead of typecasting in patch 1/4. drivers/net/ethernet

[PATCH V2 0/4] Add IPv6 support for iWARP

2013-06-12 Thread Vipul Pandya
branch. We have created this patch series on top of net-next tree. We have included all the maintainers of respective drivers. Kindly review the change and let us know in case of any review comments. Thanks, Vipul Pandya V2: Used local variables instead of typecasting in patch 1/4. Steve Wise (1):

[PATCH 0/4] Add IPv6 support for iWARP

2013-06-06 Thread Vipul Pandya
branch. We have created this patch series on top of net-next tree. We have included all the maintainers of respective drivers. Kindly review the change and let us know in case of any review comments. Thanks, Vipul Pandya Steve Wise (1): RDMA/cma: Add IPv6 support for iWARP. Vipul Pandya (3

[PATCH 4/4] RDMA/cxgb4: Add support for active and passive open connection with IPv6 address

2013-06-06 Thread Vipul Pandya
listen_stop. Add support for iWARP over VLAN device and enable IPv6 support on VLAN device. Make use of import_ep in c4iw_reconnect. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 835 + drivers/infiniband/hw/cxgb4/device.c | 116

[PATCH 1/4] RDMA/cma: Add IPv6 support for iWARP.

2013-06-06 Thread Vipul Pandya
From: Steve Wise This patch modifies the type of local_addr and remote_addr fields in struct iw_cm_id from struct sockaddr_in to struct sockaddr_storage to hold IPv6 and IPv4 addresses uniformly. It changes the references of local_addr and remote_addr in RDMA/cxgb4, RDMA/cxgb3, RDMA/nes and amso

[PATCH 2/4] cxgb4: Add routines to create and remove listening IPv6 servers

2013-06-06 Thread Vipul Pandya
it can be treated as an error and ULD can free STID which can result into an error in passive open reply. Add cpl structure for active open request with IPv6 address for T5. Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 71 - drivers

[PATCH 3/4] cxgb4: Add CLIP support to store compressed IPv6 address

2013-06-06 Thread Vipul Pandya
P and the one stored in the CLIP region. Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 206 drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h | 23 +++ 2 files changed, 229 insertions(+) diff --git a/drivers/net/ethernet/chelsio/

[PATCH v2 net-next 01/22] cxgb4: Add register definations for T5

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 94 ++ 1 files changed, 94 insertions(+), 0 deletions(-) diff --git a

[PATCH v2 net-next 05/22] cxgb4: Add T5 write combining support

2013-03-14 Thread Vipul Pandya
it for processing. This patch copies coalesced work request to memory mapped BAR2 space. Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |2 + drivers/net/ethernet

[PATCH v2 net-next 22/22] csiostor: Cleanup chip specific operations.

2013-03-14 Thread Vipul Pandya
From: Arvind Bhushan This patch removes chip specific operations from the common hardware paths, as well as the Makefile change to accomodate the new files. Signed-off-by: Arvind Bhushan Signed-off-by: Naresh Kumar Inna --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db driver

[PATCH v2 net-next 21/22] csiostor: Header file modifications for chip support and bug fixes.

2013-03-14 Thread Vipul Pandya
From: Arvind Bhushan This patch defines the common operations to support multiple chips. It includes common header file modifications to support the current chips (T4 and T5). It also includes the following bug fixes: - reconfirms the rnode state after an implicit logo. - corrects the stats array

[PATCH v2 net-next 20/22] csiostor: Add T5 adapter operations.

2013-03-14 Thread Vipul Pandya
From: Arvind Bhushan This patch creates a new file for T5 adapter operations. Signed-off-by: Arvind Bhushan Signed-off-by: Naresh Kumar Inna --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/scsi/csiostor/csio_hw_t5.c | 397 1 fil

[PATCH v2 net-next 19/22] csiostor: Segregate T4 adapter operations.

2013-03-14 Thread Vipul Pandya
From: Arvind Bhushan This patch separates T4 adapter operations into a new file. Signed-off-by: Arvind Bhushan Signed-off-by: Naresh Kumar Inna --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/scsi/csiostor/csio_hw_t4.c | 403 1

[PATCH v2 net-next 18/22] RDMA/cxgb4: Fix onchip queue support for T5

2013-03-14 Thread Vipul Pandya
then host QP should be allocated before returning an error. Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/qp.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw

[PATCH v2 net-next 17/22] RDMA/cxgb4: Bump tcam_full stat and WR reply timeout

2013-03-14 Thread Vipul Pandya
Always bump the tcam_full stat. Also, bump wr reply timeout to 30 seconds. Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/cm.c |2 +- drivers/infiniband/hw/cxgb4/iw_cxgb4.h |2 +- 2 files changed, 2

[PATCH v2 net-next 16/22] RDMA/cxgb4: Map pbl buffers for dma if using DSGL.

2013-03-14 Thread Vipul Pandya
Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/mem.c | 29 +++-- 1 files changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4

[PATCH v2 net-next 15/22] RDMA/cxgb4: Use DSGLs for fastreg and adapter memory writes for T5.

2013-03-14 Thread Vipul Pandya
ULP_TX_MEM_WRITE command fields for T5. Ordering bit of ULP_TX_MEM_WRITE is at bit position 22 in T5 and at 23 in T4. Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/iw_cxgb4.h |2 +- drivers/infiniband/hw/cxgb4

[PATCH v2 net-next 13/22] RDMA/cxgb4: Turn off db coalescing when RDMA QPs are in use.

2013-03-14 Thread Vipul Pandya
Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/qp.c| 20 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 19 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h

[PATCH v2 net-next 09/22] cxgb4: Update driver version and description

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net

[PATCH v2 net-next 07/22] cxgb4: Add T5 debugfs support

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |3 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 55 +--- drivers/net

[PATCH v2 net-next 06/22] cxgb4: Enable doorbell drop recovery only for T4 adapter

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 87 ++ 1 files changed, 71 insertions(+), 16 deletions(-) diff --git a

[PATCH v2 net-next 04/22] cxgb4: Dump T5 registers

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 452 ++- 1 files changed, 448 insertions(+), 4 deletions(-) diff --git

[PATCH v2 net-next 02/22] cxgb4: Add macros, structures and inline functions for T5

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 50 - drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 45

[PATCH v2 net-next 00/22] Add support for Chelsio T5 adapter

2013-03-14 Thread Vipul Pandya
and storage related stress tests on this patch series. Thanks, Vipul Pandya v2: Replaced #ifdef with portable interface wmb in ring_tx_db Arvind Bhushan (4): csiostor: Segregate T4 adapter operations. csiostor: Add T5 adapter operations. csiostor: Header file modifications for chip s

[PATCH v2 net-next 14/22] RDMA/cxgb4: Add module_params to enable DB FC & Coalescing on T5

2013-03-14 Thread Vipul Pandya
Both DB Flow-Control and DB Coalescing are disabled by default on T5 Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/device.c | 25 +++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h |1 + drivers

[PATCH v2 net-next 12/22] RDMA/cxgb4: Add Support for Chelsio T5 adapter

2013-03-14 Thread Vipul Pandya
Adds support for Chelsio T5 adapter. Enables T5's Write Combining feature. Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/infiniband/hw/cxgb4/cm.c | 64 +++ drivers/infiniband/hw/cxgb4/device.c |

[PATCH v2 net-next 11/22] cxgb4vf: Add support for Chelsio T5 adapter

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4vf/adapter.h |1 + .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c| 35

[PATCH v2 net-next 10/22] cxgb4: Disable SR-IOV support for PF4-7 for T5

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur All T5 adapters will only support VFs on PF0-3 despite the ability of the hardware to support them on PF4-7. This keeps our T4 and T5 adapters more similar which simplifies host driver software. Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface

[PATCH v2 net-next 08/22] cxgb4: Add T5 PCI ids

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 38 +++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a

[PATCH v2 net-next 03/22] cxgb4: Initialize T5

2013-03-14 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- v2: Replaced #ifdef with portable interface wmb in ring_tx_db drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 85 ++--- drivers/net/ethernet/chelsio/cxgb4/sge.c| 37 -- drivers

Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

2013-03-13 Thread Vipul Pandya
On 12-03-2013 20:12, Steve Wise wrote: > On 3/12/2013 7:19 AM, David Miller wrote: >> From: Vipul Pandya >> Date: Tue, 12 Mar 2013 17:16:17 +0530 >> >>> + writel(n, adap->bar2 + q->udb + 8); >>> +#if de

[PATCH net-next 09/22] cxgb4: Update driver version and description

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net/ethernet/chelsio

[PATCH net-next 10/22] cxgb4: Disable SR-IOV support for PF4-7 for T5

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur All T5 adapters will only support VFs on PF0-3 despite the ability of the hardware to support them on PF4-7. This keeps our T4 and T5 adapters more similar which simplifies host driver software. Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h

[PATCH net-next 06/22] cxgb4: Enable doorbell drop recovery only for T4 adapter

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 87 ++ 1 files changed, 71 insertions(+), 16 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net

[PATCH net-next 00/22] Add support for Chelsio T5 adapter

2013-03-12 Thread Vipul Pandya
and storage related stress tests on this patch series. Thanks, Vipul Pandya Arvind Bhushan (4): csiostor: Segregate T4 adapter operations. csiostor: Add T5 adapter operations. csiostor: Header file modifications for chip support and bug fixes. csiostor: Cleanup chip specific operations.

[PATCH net-next 01/22] cxgb4: Add register definations for T5

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/t4_regs.h | 94 ++ 1 files changed, 94 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/t4_regs.h b/drivers/net

[PATCH net-next 05/22] cxgb4: Add T5 write combining support

2013-03-12 Thread Vipul Pandya
it for processing. This patch copies coalesced work request to memory mapped BAR2 space. Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |2 + drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 53

[PATCH net-next 11/22] cxgb4vf: Add support for Chelsio T5 adapter

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4vf/adapter.h |1 + .../net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c| 35 ++-- drivers/net/ethernet/chelsio/cxgb4vf/sge.c |8

[PATCH net-next 12/22] RDMA/cxgb4: Add Support for Chelsio T5 adapter

2013-03-12 Thread Vipul Pandya
Adds support for Chelsio T5 adapter. Enables T5's Write Combining feature. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 64 +++ drivers/infiniband/hw/cxgb4/device.c | 13 -- drivers/infiniband/hw/cxgb4/iw_cxgb4.h |

[PATCH net-next 20/22] csiostor: Add T5 adapter operations.

2013-03-12 Thread Vipul Pandya
From: Arvind Bhushan This patch creates a new file for T5 adapter operations. Signed-off-by: Arvind Bhushan Signed-off-by: Naresh Kumar Inna --- drivers/scsi/csiostor/csio_hw_t5.c | 397 1 files changed, 397 insertions(+), 0 deletions(-) create mode 1006

[PATCH net-next 21/22] csiostor: Header file modifications for chip support and bug fixes.

2013-03-12 Thread Vipul Pandya
From: Arvind Bhushan This patch defines the common operations to support multiple chips. It includes common header file modifications to support the current chips (T4 and T5). It also includes the following bug fixes: - reconfirms the rnode state after an implicit logo. - corrects the stats array

[PATCH net-next 22/22] csiostor: Cleanup chip specific operations.

2013-03-12 Thread Vipul Pandya
From: Arvind Bhushan This patch removes chip specific operations from the common hardware paths, as well as the Makefile change to accomodate the new files. Signed-off-by: Arvind Bhushan Signed-off-by: Naresh Kumar Inna --- drivers/scsi/csiostor/Makefile|3 +- drivers/scsi/csiostor/cs

[PATCH net-next 19/22] csiostor: Segregate T4 adapter operations.

2013-03-12 Thread Vipul Pandya
From: Arvind Bhushan This patch separates T4 adapter operations into a new file. Signed-off-by: Arvind Bhushan Signed-off-by: Naresh Kumar Inna --- drivers/scsi/csiostor/csio_hw_t4.c | 403 1 files changed, 403 insertions(+), 0 deletions(-) create mode 1

[PATCH net-next 18/22] RDMA/cxgb4: Fix onchip queue support for T5

2013-03-12 Thread Vipul Pandya
then host QP should be allocated before returning an error. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/qp.c | 13 + 1 files changed, 5 insertions(+), 8 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/qp.c b/drivers/infiniband/hw/cxgb4/qp.c index 90833d7

[PATCH net-next 17/22] RDMA/cxgb4: Bump tcam_full stat and WR reply timeout

2013-03-12 Thread Vipul Pandya
Always bump the tcam_full stat. Also, bump wr reply timeout to 30 seconds. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c |2 +- drivers/infiniband/hw/cxgb4/iw_cxgb4.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw

[PATCH net-next 16/22] RDMA/cxgb4: Map pbl buffers for dma if using DSGL.

2013-03-12 Thread Vipul Pandya
Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/mem.c | 29 +++-- 1 files changed, 23 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/mem.c b/drivers/infiniband/hw/cxgb4/mem.c index 33db9ee..4cb8eb2 100644 --- a/drivers/infiniband/hw

[PATCH net-next 15/22] RDMA/cxgb4: Use DSGLs for fastreg and adapter memory writes for T5.

2013-03-12 Thread Vipul Pandya
ULP_TX_MEM_WRITE command fields for T5. Ordering bit of ULP_TX_MEM_WRITE is at bit position 22 in T5 and at 23 in T4. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/iw_cxgb4.h |2 +- drivers/infiniband/hw/cxgb4/mem.c | 138 -- drivers

[PATCH net-next 14/22] RDMA/cxgb4: Add module_params to enable DB FC & Coalescing on T5

2013-03-12 Thread Vipul Pandya
Both DB Flow-Control and DB Coalescing are disabled by default on T5 Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/device.c | 25 +++-- drivers/infiniband/hw/cxgb4/iw_cxgb4.h |1 + drivers/infiniband/hw/cxgb4/qp.c | 10 ++ 3 files

[PATCH net-next 04/22] cxgb4: Dump T5 registers

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 452 ++- 1 files changed, 448 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers

[PATCH net-next 13/22] RDMA/cxgb4: Turn off db coalescing when RDMA QPs are in use.

2013-03-12 Thread Vipul Pandya
Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/qp.c| 20 drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 19 +++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h |3 +++ drivers/net/ethernet/chelsio/cxgb4/t4_regs.h

[PATCH net-next 07/22] cxgb4: Add T5 debugfs support

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h |3 +- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 55 +--- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 104

[PATCH net-next 03/22] cxgb4: Initialize T5

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 85 ++--- drivers/net/ethernet/chelsio/cxgb4/sge.c| 37 -- drivers/net/ethernet/chelsio/cxgb4/t4_hw.c | 152

[PATCH net-next 02/22] cxgb4: Add macros, structures and inline functions for T5

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4.h| 50 - drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 45 ++ drivers/net/ethernet/chelsio/cxgb4/t4fw_api.h

[PATCH net-next 08/22] cxgb4: Add T5 PCI ids

2013-03-12 Thread Vipul Pandya
From: Santosh Rastapur Signed-off-by: Santosh Rastapur Signed-off-by: Vipul Pandya --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 38 +++ 1 files changed, 38 insertions(+), 0 deletions(-) diff --git a/drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c b/drivers/net

Re: [PATCH 00/11] Critical bug fixes for RDMA/cxgb4

2013-01-15 Thread Vipul Pandya
On 08-01-2013 11:43, Vipul Pandya wrote: > > > On 08-01-2013 06:03, Roland Dreier wrote: >> On Mon, Jan 7, 2013 at 5:11 AM, Vipul Pandya wrote: >>> This patch series fixes critical bugs for RDMA/cxgb4. It fixes bugs in >>> following >>> areas:

Re: [PATCH 00/11] Critical bug fixes for RDMA/cxgb4

2013-01-07 Thread Vipul Pandya
On 08-01-2013 06:03, Roland Dreier wrote: > On Mon, Jan 7, 2013 at 5:11 AM, Vipul Pandya wrote: >> This patch series fixes critical bugs for RDMA/cxgb4. It fixes bugs in >> following >> areas: >> - Aborts connection in error scenarios >> - Logs only critical e

[PATCH 11/11] RDMA/cxgb4: Address sparse warnings

2013-01-07 Thread Vipul Pandya
restricted __be32 Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 68 +++--- drivers/infiniband/hw/cxgb4/device.c |3 +- 2 files changed, 40 insertions(+), 31 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw

[PATCH 10/11] RDMA/cxgb4: Insert hwtid in pass_accept_req instead in pass_establish

2013-01-07 Thread Vipul Pandya
CPL_ABORT_REQ_RSS can come before TCP connection is established. In such case peer_abort was trying to remove the hwtid which was not inserted. To avoid this we insert the hwtid when we are sure that we are surely going to send passive accept request. Signed-off-by: Vipul Pandya --- drivers

[PATCH 09/11] RDMA/cxgb4: Don't wakeup threads for MPAv2

2013-01-07 Thread Vipul Pandya
igned-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 88933af..06c3a52 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/dr

[PATCH 08/11] RDMA/cxgb4: don't reconnect on abort for mpa_rev 1

2013-01-07 Thread Vipul Pandya
only reconnect if the endpoint wasn't freed. peer_abort() should only attempt to reconnect if the endpoint wasn't freed. Also remove hwtid from the debugfs idr. Add missing check for peer2peer in MPAv2 code use correct mpa version on reject. Signed-off-by: Vipul Pandya --- drivers/

[PATCH 07/11] RDMA/cxgb4: endpoint timeout race condition

2013-01-07 Thread Vipul Pandya
The endpoint timeout logic had a race that could cause an endpoint object to be freed while it was still on the timedout list. This can happen if the timer is stopped after it had fired, but before the timedout thread processed the endpoint timeout. Signed-off-by: Vipul Pandya --- drivers

[PATCH 06/11] RDMA/cxgb4: only log rx_data warnings if cpl status is non zero.

2013-01-07 Thread Vipul Pandya
With newer firmware, we can get streaming data due to connection errors before the driver moves the QP out of RTS. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b

[PATCH 05/11] RDMA/cxgb4: Always log async errors.

2013-01-07 Thread Vipul Pandya
Log AEs even if the QP isn't in RTS. It is useful information. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c |6 +++--- drivers/infiniband/hw/cxgb4/ev.c |8 +--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4/c

[PATCH 04/11] RDMA/cxgb4: keep qp referenced until TID released.

2013-01-07 Thread Vipul Pandya
The driver is currently releasing the last ref on the QP too early. This can cause bus errors due to HW still fetching WRs from the hw queue. The fix is to keep a qp ref until we release the HW TID. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 20

[PATCH 03/11] RDMA/cxgb4: Display streaming mode error only if detected in RTS.

2013-01-07 Thread Vipul Pandya
With later firmware, the chances of getting streaming mode data after we exit RTS is likely, so we don't need to warn for it. The only real case where we don't expect it is when the QP is in RTS. move QP to ERROR when streaming mode data received. Signed-off-by: Vipul Pandya --

[PATCH 02/11] RDMA/cxgb4: abort connections when moving to ERROR state.

2013-01-07 Thread Vipul Pandya
If a FINI operation fails, then we need to ABORT instead of CLOSE. Also, if we ABORT due to unexpected STREAMING data, then wake up anybody blocked in FINI... Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c |1 + drivers/infiniband/hw/cxgb4/qp.c |1 + 2 files changed

[PATCH 01/11] RDMA/cxgb4: abort connections that receive unexpected streaming mode data

2013-01-07 Thread Vipul Pandya
This error means the rdma connection was knocked out of rdma mode probably due to an error on the connection. Signed-off-by: Vipul Pandya --- drivers/infiniband/hw/cxgb4/cm.c | 19 ++- 1 files changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/hw/cxgb4

[PATCH 00/11] Critical bug fixes for RDMA/cxgb4

2013-01-07 Thread Vipul Pandya
mismatch related bugs in MPAv2 related logic - Avoids removing hwtid which was not inserted - Addresses several sparse warnings The patch-series is based on Roland's infiniband tree for-next branch. Thanks, Vipul Pandya Vipul Pandya (11): RDMA/cxgb4: abort connections that receive unexp

Re: linux-next: build failure after merge of the infiniband tree

2012-12-20 Thread Vipul Pandya
On 20-12-2012 05:52, Roland Dreier wrote: > On Wed, Dec 19, 2012 at 2:44 PM, Stephen Rothwell > wrote: >> Hi all, >> >> After merging the infiniband tree, today's linux-next build (x86_64_ >> allmodconfig) failed like this: >> >> In file included from drivers/scsi/csiostor/csio_wr.h:42:0, >>

Re: [PATCH V4 0/5] Add LE hash collision bug fix for active and passive offloaded connections

2012-12-18 Thread Vipul Pandya
Hi Roland and David, Any feedback on this? Thanks, Vipul On 10-12-2012 15:00, Vipul Pandya wrote: > This patch series fixes the LE hash collision issue in cxgb4 and RDMA/cxgb4 > drivers in kernel.org. > > If the hash functionality is enabled in T4 then tuple information of a

Re: [PATCH V3 1/5] cxgb4: Add T4 filter support

2012-12-10 Thread Vipul Pandya
On 04-12-2012 00:32, David Miller wrote: > From: Vipul Pandya > Date: Mon, 3 Dec 2012 16:52:57 +0530 > >> +/* >> + * If the new or old filter have loopback rewriteing rules then we'll >> + * need to free any existing Layer Two Table (L2T) entries o

[PATCH V4 3/5] RDMA/cxgb4: Fix LE hash collision bug for active open connection

2012-12-10 Thread Vipul Pandya
than 1.4.10.0 ntuple bits are required to be set. Adds nocong and enable_ecn module parameter options. Signed-off-by: Vipul Pandya --- V2: Changed commenting style from kernel-doc format('/**') to normal V3: Resending the whole patch series again with the missing patches in V2 V4: Change

[PATCH V4 4/5] RDMA/cxgb4: Fix LE hash collision bug for passive open connection

2012-12-10 Thread Vipul Pandya
using firmware work request. Signed-off-by: Vipul Pandya --- V2: Changed commenting style from kernel-doc format('/**') to normal V3: Resending the whole patch series again with the missing patches in V2 V4: Changed comments for networking from '/*' to '/* Comment' f

[PATCH V4 5/5] RDMA/cxgb4: Fix bug for active and passive LE hash collision path

2012-12-10 Thread Vipul Pandya
filter region is set. Adds stat for ofld_connect_wr failures. This patch also adds debugfs file to show endpoints. Signed-off-by: Vipul Pandya --- V2: Changed commenting style from kernel-doc format('/**') to normal V3: Resending the whole patch series again with the missing patches in V2 V

[PATCH V4 1/5] cxgb4: Add T4 filter support

2012-12-10 Thread Vipul Pandya
ilter capabilities. It constructs a Firmware Filter Work Request which writes the filter at a specified index to get the work done. It hosts shadow copy of ingress filter entry to check field size limitations and save memory in the case where the filter table is large. Signed-off-by: Vipul Pandya -

[PATCH V4 2/5] cxgb4: Add LE hash collision bug fix path in LLD driver

2012-12-10 Thread Vipul Pandya
new stid will be used to open server filter in the filter region. Signed-off-by: Vipul Pandya --- V2: Changed commenting style from kernel-doc format('/**') to normal V3: Resending the whole patch series again with the missing patches in V2 V4: Changed comments for networking fr

[PATCH V4 0/5] Add LE hash collision bug fix for active and passive offloaded connections

2012-12-10 Thread Vipul Pandya
7;/**') to normal V3: Resending the whole patch series again with the missing patches in V2 V4: Changed comments for networking from '/*' to '/* Comment' format. Thanks, Vipul Pandya Vipul Pandya (5): cxgb4: Add T4 filter support cxgb4: Add LE hash collision bug fix

Re: Dapltest test error DAT_CONN_QUAL_IN_USE

2012-12-03 Thread Vipul Pandya
org/bugzilla/index.cgi > > >> -Original Message- >> From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- >> ow...@vger.kernel.org] On Behalf Of Vipul Pandya >> Sent: Friday, November 30, 2012 7:12 AM >> To: Davis, Arlin R >> Cc: Steve Wise; li

  1   2   >