Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

On 2013/9/9 22:55, Marciniszyn, Mike wrote: >> Subject: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to >> simplify >> code >> >> Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and >> pcie_get_mps() to simply code. Because pci core caches the "PCI-E Max >> Payload Size Sup

[PATCH 2/6] title/pci: use cached pci_dev->pcie_mpss to simplify code

The PCI core caches the "PCI-E Max Payload Size Supported" in pci_dev->pcie_mpss, so use that instead of pcie_capability_read_dword(). Signed-off-by: Yijing Wang --- arch/tile/kernel/pci.c |7 ++- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/tile/k

[PATCH 1/6] PCI: Export pcie_set_mps() and pcie_get_mps()

Export pcie_get_mps() and pcie_set_mps() functions, so driver can use them to simplify code. Signed-off-by: Yijing Wang --- drivers/pci/pci.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c index b821a62..e35f7ec 100644 --- a

[PATCH 3/6] IB/qib: Use pci_is_root_bus() to check whether it is a root bus

Use pci_is_root_bus() instead of "if (bus->parent)" statement for better readability. Signed-off-by: Yijing Wang --- drivers/infiniband/hw/qib/qib_pcie.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_pcie.c b/drivers/infi

[PATCH 6/6] radeon: Use pcie_get_readrq() and pcie_set_readrq() to simplify code

Use pcie_get_readrq() and pcie_set_readrq() functions to simplify code. Signed-off-by: Yijing Wang --- drivers/gpu/drm/radeon/evergreen.c | 19 ++- 1 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/radeon/evergreen.c b/drivers/gpu/drm/radeon

[PATCH 0/6] Simplify some mps and mrrs setting related code

ity. Yijing Wang (6): PCI: Export pcie_set_mps() and pcie_get_mps() title/pci: use cached pci_dev->pcie_mpss to simplify code IB/qib: Use pci_is_root_bus() to check whether it is a root bus IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code staging/et131x: Use cached pci_dev->

[PATCH 5/6] staging/et131x: Use cached pci_dev->pcie_mpss and pcie_set_readrq() to simplif code

The PCI core caches the "PCI-E Max Payload Size Supported" in pci_dev->pcie_mpss, so use that instead of pcie_capability_read_dword(). Also use pcie_set_readrq() instead of pcie_capability_clear_and_set_word() to simplify code. Signed-off-by: Yijing Wang --- drivers/staging/et

[PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and pcie_get_mps() to simply code. Because pci core caches the "PCI-E Max Payload Size Supported" in pci_dev->pcie_mpss, so use that instead of pcie_capability_read_word(). Remove the unused val2fld() and fld2val(). Signed-o

[PATCH 13/16] qib: clean up unnecessary MSI/MSI-X capability find

ill consume more time. Signed-off-by: Yijing Wang Cc: Mike Marciniszyn Cc: Roland Dreier Cc: Sean Hefty Cc: Hal Rosenstock Cc: linux-rdma@vger.kernel.org --- drivers/infiniband/hw/qib/qib_pcie.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/infinib