Re: device attr cleanup (was: Handle mlx4 max_sge_rd correctly)

2015-12-15 Thread santosh shilimkar
On 12/9/2015 10:42 AM, Christoph Hellwig wrote: On Tue, Dec 08, 2015 at 07:52:03PM -0500, ira.weiny wrote: Searching patchworks... I'm a bit worried about the size of the patch and I would like to see it split up for review. But I agree Christophs method is better long term. I'd be happy to

Re: Future of FMR support, was: Re: [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR

2015-11-25 Thread santosh shilimkar
On 11/25/2015 1:00 AM, Christoph Hellwig wrote: On Tue, Nov 24, 2015 at 01:54:02PM -0800, santosh shilimkar wrote: As already indicated to Sagi [1], RDS IB FR support is work in progress and I was hoping to get it ready for 4.5. There are few issues we found with one of the HCA and hence

Re: Future of FMR support, was: Re: [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR

2015-11-25 Thread santosh shilimkar
On 11/25/2015 10:22 AM, Or Gerlitz wrote: On Wed, Nov 25, 2015 at 7:09 PM, santosh shilimkar <santosh.shilim...@oracle.com> wrote: As already indicated to Sagi [1], RDS IB FR support is work in progress and I was hoping to get it ready for 4.5. These are really good news! can you

Re: Future of FMR support, was: Re: [PATCH v1 5/9] xprtrdma: Add ro_unmap_sync method for FMR

2015-11-24 Thread santosh shilimkar
Hi Christoph, On 11/23/2015 10:52 PM, Christoph Hellwig wrote: On Mon, Nov 23, 2015 at 07:57:42PM -0500, Tom Talpey wrote: On 11/23/2015 5:14 PM, Chuck Lever wrote: FMR's ro_unmap method is already synchronous because ib_unmap_fmr() is a synchronous verb. However, some improvements can be

[PATCH v2 04/14] RDS: Use per-bucket rw lock for bind hash-table

2015-09-30 Thread Santosh Shilimkar
-bucket lock to improve the scalability. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- net/rds/af_rds.c | 2 ++ net/rds/bind.c | 47 --- net/rds/rds.h|

[PATCH v2 14/14] RDS: IB: split mr pool to improve 8K messages performance

2015-09-30 Thread Santosh Shilimkar
lead to 8k pull being exhausted, we fall-back to 1m pool till 8k pool recovers for use. This helps to at least push ~55 kB/s bidirectional data which is a nice improvement. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@o

[PATCH v2 07/14] RDS: IB: ack more receive completions to improve performance

2015-09-30 Thread Santosh Shilimkar
mutual exclusion locks are being performed. In next patch, send completion is also split which re-uses the poll_cq() and hence the code is moved to ib_cm.c Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> ---

[PATCH v2 13/14] RDS: IB: use max_mr from HCA caps than max_fmr

2015-09-30 Thread Santosh Shilimkar
All HCA drivers seems to popullate max_mr caps and few of them do both max_mr and max_fmr. Hence update RDS code to make use of max_mr. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- net/rds/ib.c | 4

[PATCH v2 09/14] RDS: IB: handle rds_ibdev release case instead of crashing the kernel

2015-09-30 Thread Santosh Shilimkar
From: Santosh Shilimkar <ssant...@kernel.org> Just in case we are still handling the QP receive completion while the rds_ibdev is released, drop the connection instead of crashing the kernel. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> --- net/rds/ib_cm.c | 3 ++- 1 fil

[PATCH v2 05/14] RDS: defer the over_batch work to send worker

2015-09-30 Thread Santosh Shilimkar
case where we reached to over_batch code for some other reason so just retrying again before giving up. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- net/rds/send.c | 4 +++- 1 file changed, 3 insertions(+), 1 d

[PATCH v2 06/14] RDS: use rds_send_xmit() state instead of RDS_LL_SEND_FULL

2015-09-30 Thread Santosh Shilimkar
we are seeing connections stuck with the LL_SEND_FULL bit getting set and never cleared. We kick krdsd after any time we see -ENOMEM or -EAGAIN from the ring allocation code. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@o

[PATCH v2 02/14] RDS: make socket bind/release locking scheme simple and more efficient

2015-09-30 Thread Santosh Shilimkar
for bind hash-table. In subsequent patch, we also covert the global lock with per-bucket lock to reduce the global lock contention. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- net/rds/af_rds.c | 6 ---

[PATCH v2 08/14] RDS: IB: split send completion handling and do batch ack

2015-09-30 Thread Santosh Shilimkar
. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Signed-off-by: Santosh Shilimkar <santosh.shilim...@oracle.com> --- net/rds/ib.h | 6 ++- net/rds/ib_cm.c| 45 -- net/rds/ib_send.c | 110 + net/rd

[PATCH v2 01/14] RDS: use kfree_rcu in rds_ib_remove_ipaddr

2015-09-30 Thread Santosh Shilimkar
synchronize_rcu() slowing down un-necessarily the socket shutdown path. It is used just kfree() the ip addresses in rds_ib_remove_ipaddr() which is perfect usecase for kfree_rcu(); So lets use that to gain some speedup. Signed-off-by: Santosh Shilimkar <ssant...@kernel.org> Sign

[PATCH v2 00/14] RDS: connection scalability and performance improvements

2015-09-30 Thread Santosh Shilimkar
kernel.org/pub/scm/linux/kernel/git/ssantosh/linux.git net/rds/4.3-v2 As a side note, the IB HCA driver I used for testing misses at least 3 important patches in upstream to see the full blown IB performance and am hoping to get that in mainline with help of them. Santosh Shilimkar (14): RDS: use

Re: [PATCH v1 00/24] New fast registration API

2015-09-22 Thread santosh shilimkar
On 9/22/2015 12:56 AM, Sagi Grimberg wrote: On 9/22/2015 10:19 AM, Sagi Grimberg wrote: As mentioned earlier, I have a WIP RDS fastreg branch [3] which is functional (at least I can RDMA messages across nodes ;-)). Nice! So merging [2] and [3], I created [4] and applied a delta change

Re: [PATCH 00/15] RDS: connection scalability and performance improvements

2015-09-21 Thread santosh shilimkar
On 9/20/2015 1:37 AM, Sagi Grimberg wrote: On 9/20/2015 2:04 AM, Santosh Shilimkar wrote: This series addresses RDS connection bottlenecks on massive workloads and improve the RDMA performance almost by 3X. RDS TCP also gets a small gain of about 12%. RDS is being used in massive systems

Re: [PATCH v2 12/12] rds/ib: Remove ib_get_dma_mr calls

2015-08-13 Thread santosh shilimkar
as expected. The rds change looks also straight forward since ib_get_dma_mr() is being used for local write. So feel free to add below tag if you need one. Tested-Acked-by: Santosh Shilimkar santosh.shilim...@oracle.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body