[PATCH] Add fix to _do_madrpc to set the errno after umad_recv.

2013-02-18 Thread Sarat Kakarla
_do_madrpc() (in libibmad-1.3.3/src/rpc.c) sends the mad request through umad_send() and waits for a response from umad_recv() with the timeout passed by caller. Linux error number sent by peer in 'status' is not copied over to the process/thread local 'errno'. Signed-off-by: Sarat Kakarla $

Re: [PATCH] Add fix to _do_madrpc to set the errno after umad_recv.

2013-02-25 Thread Sarat Kakarla
FOlks, Just a gentle reminder, whenever you get a chance please review the following fix. Thanks Sarat On 2/18/2013 2:10 PM, Sarat Kakarla wrote: _do_madrpc() (in libibmad-1.3.3/src/rpc.c) sends the mad request through umad_send() and waits for a response from umad_recv() with the timeou

Re: [PATCH] Add fix to _do_madrpc to set the errno after umad_recv.

2013-02-26 Thread Ira Weiny
First, it is not documented that this function will set any errno value. umad_status is only documented to return ETIMEDOUT which will be returned in the p_error parameter (ib_rpc_t -> rstatus) value when an error occurs. Is this not sufficient for your needs? Secondly, this patch does not app

Re: [PATCH] Add fix to _do_madrpc to set the errno after umad_recv.

2013-03-18 Thread Sarat Kakarla
Ira, Thanks for the review. Sorry for the late reply. My answers are in-lined. Sarat On 2/26/2013 2:29 PM, Ira Weiny wrote: First, it is not documented that this function will set any errno value. umad_status is only documented to return ETIMEDOUT which will be returned in the p_error param