Re: [PATCH] IB/hfi: Properly set permissions for user device files

2015-09-17 Thread Don Dutile
On 09/16/2015 05:41 PM, ira.we...@intel.com wrote: From: Ira Weiny Some of the device files are required to be user accessible for PSM while most should remain accessible only by root. Add a parameter to hfi1_cdev_init which controls if the user should have access to this

Re: [PATCH] IB/hfi: Properly set permissions for user device files

2015-09-17 Thread Jason Gunthorpe
On Thu, Sep 17, 2015 at 06:18:15PM +0200, Michal Schmidt wrote: > On 09/16/2015 11:41 PM, ira.we...@intel.com wrote: > > @@ -125,7 +151,20 @@ int __init dev_init(void) > > ret = PTR_ERR(class); > > pr_err("Could not create device class (err %d)\n", -ret); > >

Re: [PATCH] IB/hfi: Properly set permissions for user device files

2015-09-17 Thread Michal Schmidt
On 09/16/2015 11:41 PM, ira.we...@intel.com wrote: > @@ -125,7 +151,20 @@ int __init dev_init(void) > ret = PTR_ERR(class); > pr_err("Could not create device class (err %d)\n", -ret); > unregister_chrdev_region(hfi1_dev, HFI1_NMINORS); > + goto

RE: [PATCH] IB/hfi: Properly set permissions for user device files

2015-09-17 Thread Marciniszyn, Mike
> Subject: [PATCH] IB/hfi: Properly set permissions for user device files > > From: Ira Weiny <ira.we...@intel.com> > Signed-off-by: Haralanov, Mitko <mitko.harala...@intel.com> > Signed-off-by: Ira Weiny <ira.we...@intel.com> Acked-by: Mike Marcin

RE: [PATCH] IB/hfi: Properly set permissions for user device files

2015-09-17 Thread Weiny, Ira
> > On Thu, Sep 17, 2015 at 06:18:15PM +0200, Michal Schmidt wrote: > > On 09/16/2015 11:41 PM, ira.we...@intel.com wrote: > > > @@ -125,7 +151,20 @@ int __init dev_init(void) > > > ret = PTR_ERR(class); > > > pr_err("Could not create device class (err %d)\n", -ret); > > >

[PATCH] IB/hfi: Properly set permissions for user device files

2015-09-16 Thread ira . weiny
From: Ira Weiny Some of the device files are required to be user accessible for PSM while most should remain accessible only by root. Add a parameter to hfi1_cdev_init which controls if the user should have access to this device which places it in a different class with the