Re: [PATCH] IB/ipoib: Initialize ipoib_neigh list properly

2010-08-30 Thread Ralph Campbell
You are correct that it needs to be initialized but I think you must have made an error in applying the patch. If you look again at the latest version of the patch this line is present. https://patchwork.kernel.org/patch/120013/ On Tue, 2010-08-24 at 20:51 -0700, Ira Weiny wrote: I applied

Re: [PATCH] IB/ipoib: Initialize ipoib_neigh list properly

2010-08-30 Thread Ira Weiny
On Mon, 30 Aug 2010 14:56:43 -0700 Ralph Campbell ralph.campb...@qlogic.com wrote: You are correct that it needs to be initialized but I think you must have made an error in applying the patch. If you look again at the latest version of the patch this line is present.

[PATCH] IB/ipoib: Initialize ipoib_neigh list properly

2010-08-24 Thread Ira Weiny
I applied Ralph's fix dangling pointer references to ipoib_neigh and ipoib_path patch to our local RHEL based kernel and experienced crashes in ipoib_neigh_cleanup. It turns out ipoib_neigh-list was not initialized properly. So the following code from Ralph's patch caused issues. if