Re: [PATCH] IB/mlx4: check iboe netdev pointer before dereferencing it

2012-08-13 Thread Kleber Sacilotto de Souza
On 08/12/2012 02:49 AM, Or Gerlitz wrote: > On 10/08/2012 21:25, Kleber Sacilotto de Souza wrote: >> This patch fixes the problem by checking for a valid netdev pointer >> before using it to get the port MAC address. > > just curious, how did you actually stepped on this, code inspection or > any

Re: [PATCH] IB/mlx4: check iboe netdev pointer before dereferencing it

2012-08-11 Thread Or Gerlitz
On 10/08/2012 21:25, Kleber Sacilotto de Souza wrote: This patch fixes the problem by checking for a valid netdev pointer before using it to get the port MAC address. just curious, how did you actually stepped on this, code inspection or any actual race? Or. -- To unsubscribe from this list:

[PATCH] IB/mlx4: check iboe netdev pointer before dereferencing it

2012-08-10 Thread Kleber Sacilotto de Souza
Unlike other parts of the mlx4_ib code, the function build_mlx_header() doesn't check if the iboe netdev of the given port is valid before derefering it, which can cause a crash if the ethernet interface has already been taken down. This patch fixes the problem by checking for a valid netdev point