Re: [PATCH] IB: mlx4: Fix mem leaks in ib_link_query_port()

2012-04-16 Thread Or Gerlitz
On 4/16/2012 8:05 AM, Roland Dreier wrote: thanks, applied (looks like a 3.4 regression so I'll send the fix to Linus with my next batch) not sure to follow on the next branch part, it is a regression introduced in 3.4-rc1 so it should be in your fixes branch and submitted within a batch

Re: [PATCH] IB: mlx4: Fix mem leaks in ib_link_query_port()

2012-04-15 Thread Or Gerlitz
On 4/12/2012 12:43 AM, Jesper Juhl wrote: If, in ib_link_query_port(), the call to mlx4_MAD_IFC() fails we will currently do 'return err;' which will leak 'in_mad' and 'out_mad' that we previously allocated. I believe we should instead do 'goto out;' where we'll properly free the memory we

Re: [PATCH] IB: mlx4: Fix mem leaks in ib_link_query_port()

2012-04-15 Thread Roland Dreier
thanks, applied (looks like a 3.4 regression so I'll send the fix to Linus with my next batch) -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] IB: mlx4: Fix mem leaks in ib_link_query_port()

2012-04-11 Thread Jesper Juhl
If, in ib_link_query_port(), the call to mlx4_MAD_IFC() fails we will currently do 'return err;' which will leak 'in_mad' and 'out_mad' that we previously allocated. I believe we should instead do 'goto out;' where we'll properly free the memory we previously allocated. Signed-off-by: Jesper Juhl