RE: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-18 Thread Hefty, Sean
> So it's possible on server side listen using AF_INET, but client > rdma_resolve_addr/rdma_resolve_route/rdma_connect with AF_IB? Yes

Re: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-18 Thread Jinpu Wang
Hi Sean, On Wed, Dec 17, 2014 at 6:58 PM, Hefty, Sean wrote: >> I checked nfiniBand TM Architecture Release 1.2.1 VOLUME 1 - GENERAL >> SPECIFICATIONS, for RDMA IP CM service, >> the private data for CM REQ is defined in: >> Table 532 IP Addressing CM REQ Message Private Data Format >> So you mea

RE: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-17 Thread Hefty, Sean
> I checked nfiniBand TM Architecture Release 1.2.1 VOLUME 1 - GENERAL > SPECIFICATIONS, for RDMA IP CM service, > the private data for CM REQ is defined in: > Table 532 IP Addressing CM REQ Message Private Data Format > So you mean even for RDMA IB, the private data format is also > required, coul

Re: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-17 Thread Jinpu Wang
Hi Or, We have some trouble in the past about IPoIB support about neighbour discovery, AF_IB doesn't relay on IPoIB, so we think have another option maybe give us more safe in some cases. On Wed, Dec 17, 2014 at 11:40 AM, Or Gerlitz wrote: > On 12/16/2014 5:43 PM, Jack Wang wrote: >> >> If use

Re: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-17 Thread Or Gerlitz
On 12/16/2014 5:43 PM, Jack Wang wrote: If user attach private data for AF_IB, Just out of curiosity, can you share what was the motivation for you to use AF_IB? Or. the first byte will be overwritten, because we always set the cma version no matter family is AF_IB, so move the version se

Re: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-17 Thread Jinpu Wang
Hi Sean, Thanks for looking into this. I checked nfiniBand TM Architecture Release 1.2.1 VOLUME 1 - GENERAL SPECIFICATIONS, for RDMA IP CM service, the private data for CM REQ is defined in: Table 532 IP Addressing CM REQ Message Private Data Format So you mean even for RDMA IB, the private data

RE: [PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-16 Thread Hefty, Sean
> If user attach private data for AF_IB, the first byte will > be overwritten, because we always set the cma version no matter > family is AF_IB, so move the version set inside if condition. > > Reported-by: Fabian Holler > Signed-off-by: Jack Wang > --- > drivers/infiniband/core/cma.c | 3 ++-

[PATCH] RDMA/cma: fix first byte overwritten for AF_IB

2014-12-16 Thread Jack Wang
If user attach private data for AF_IB, the first byte will be overwritten, because we always set the cma version no matter family is AF_IB, so move the version set inside if condition. Reported-by: Fabian Holler Signed-off-by: Jack Wang --- drivers/infiniband/core/cma.c | 3 ++- 1 file changed,

[PATCH]RDMA/cma: fix first byte overwritten for AF_IB

2014-12-16 Thread Jinpu Wang
commit 56e620c453f2588cfc9898a41b110477f6417a5d Author: Jack Wang Date: Tue Dec 16 15:44:17 2014 +0100 RDMA/cma: fix first byte overwritten for AF_IB If user attach private data for AF_IB, the first byte will be overwritten, because we always set the cma version no matter famil