RE: [PATCH] infiniband: Fixes memory leak in send_flowc

2014-06-17 Thread Steve Wise
el.com; > hal.rosenst...@gmail.com; linux-rdma@vger.kernel.org; > linux-ker...@vger.kernel.org > Subject: Re: [PATCH] infiniband: Fixes memory leak in send_flowc > > On Mon, 16 Jun 2014, Nick Krause wrote: > > > That's true David, > > I will resend this parch

Re: [PATCH] infiniband: Fixes memory leak in send_flowc

2014-06-16 Thread David Rientjes
On Mon, 16 Jun 2014, Nick Krause wrote: > That's true David, > I will resend this parch without the use of the pr_warn. There's no patch to resend if you don't use pr_warn(). kfree_skb(skb) is unnecessary if !skb, look at the first thing it checks: void kfree_skb(struct sk_buff *skb) {

Re: [PATCH] infiniband: Fixes memory leak in send_flowc

2014-06-16 Thread David Rientjes
On Mon, 16 Jun 2014, Nick Krause wrote: > If that is the case ,David I would mark bug id 44631 as closed due to no > need for my if statement. You don't want to depend on the implementation of the page allocator to never return NULL for orders < PAGE_ALLOC_COSTLY_ORDER with GFP_KERNEL, it could

Re: [PATCH] infiniband: Fixes memory leak in send_flowc

2014-06-16 Thread David Rientjes
On Mon, 16 Jun 2014, Steve Wise wrote: > On 6/16/2014 12:49 PM, Nicholas Krause wrote: > > Signed-off-by: Nicholas Krause > > --- > > drivers/infiniband/hw/cxgb4/cm.c | 5 - > > 1 file changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/infiniband/hw/cxgb4/cm.c > > b/driv

Re: [PATCH] infiniband: Fixes memory leak in send_flowc

2014-06-16 Thread Steve Wise
On 6/16/2014 12:49 PM, Nicholas Krause wrote: Signed-off-by: Nicholas Krause --- drivers/infiniband/hw/cxgb4/cm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 5e153f6..867e664 100644 --- a/dri

[PATCH] infiniband: Fixes memory leak in send_flowc

2014-06-16 Thread Nicholas Krause
Signed-off-by: Nicholas Krause --- drivers/infiniband/hw/cxgb4/cm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c index 5e153f6..867e664 100644 --- a/drivers/infiniband/hw/cxgb4/cm.c +++ b/drivers/infini