eth_link_query_port() returns error if a netdevice was not yet associated with
the IBoE port. This is not required since we already initialize the link as
down. On the other hand, we need other information that the query provides.
Specifically, this can cause a failure to initilize an IBoE device
applied, thanks.
(I didn't introduce this bug in my monkeying with the patches, did I?)
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Sun, Oct 24, 2010 at 08:42:06AM -0700, Roland Dreier wrote:
> applied, thanks.
>
> (I didn't introduce this bug in my monkeying with the patches, did I?)
No you did not. It was there already but we never noticed before
Yossi's patch.
--
To unsubscribe from this list: send the line "unsubscribe
> No you did not. It was there already but we never noticed before
> Yossi's patch.
But AFAICT Yossi's patch (5eb620c8) went into 2.6.22 about 2.5 years
ago... wasn't that already there way before the IBoE stuff started?
- R.
--
To unsubscribe from this list: send the line "unsubscribe linux-r
On Sun, Oct 24, 2010 at 6:22 PM, Roland Dreier wrote:
> > No you did not. It was there already but we never noticed before
> > Yossi's patch.
>
> But AFAICT Yossi's patch (5eb620c8) went into 2.6.22 about 2.5 years
> ago... wasn't that already there way before the IBoE stuff started?
>
I see...
OK... since my "fix" for the missing return of the error value ended up
breaking things, I just decided to fold this second fix into the
original patch. The end result is the same code but I didn't think
keeping the buggy point in the middle of history helped anything.
- R.
--
To unsubscribe fro
On Sun, Oct 24, 2010 at 09:12:37PM -0700, Roland Dreier wrote:
> OK... since my "fix" for the missing return of the error value ended up
> breaking things, I just decided to fold this second fix into the
> original patch. The end result is the same code but I didn't think
> keeping the buggy point
Eli Cohen wrote:
> On Sun, Oct 24, 2010 at 6:22 PM, Roland Dreier wrote:
>> > No you did not. It was there already but we never noticed before Yossi's
>> patch.
>> But AFAICT Yossi's patch (5eb620c8) went into 2.6.22 about 2.5 years
>> ago... wasn't that already there way before the IBoE stuff s
> I pulled/built/booted with the for-next branch of Roland's tree, and I can't
> get IB link for the node,
> I don't think this is my problem, since I'm on L2 IB and not Eth, but should
> this work with pre 2.7
> firmware?! if not, maybe patch the mlx4 driver to print some error,
Oh, I also se
On Mon, Oct 25, 2010 at 11:26:38AM +0200, Or Gerlitz wrote:
>
> I pulled/built/booted with the for-next branch of Roland's tree, and I can't
> get IB link for the node,
> I don't think this is my problem, since I'm on L2 IB and not Eth, but should
> this work with pre 2.7
> firmware?! if not,
On Mon, Oct 25, 2010 at 11:33:11AM +0200, Or Gerlitz wrote:
>
> Oh, I also see an error printed by some script provided by the RHEL5 libmlx4
> package,
>
You mean you're using for-next on a RHEL5 filesystem?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body o
On Mon, Oct 25, 2010 at 1:34 PM, Eli Cohen wrote:
> IBoE will not work with firmware prior to 2.7.000. I don't think an
> error message is required in this case.
But I'm on **IB** not IBoE, I don't think you mean that the Linux
kernel IB stack is not functional over pre-2.7 firmware with the IBoE
On Mon, Oct 25, 2010 at 04:15:47PM +0200, Or Gerlitz wrote:
> On Mon, Oct 25, 2010 at 1:34 PM, Eli Cohen wrote:
>
> But I'm on **IB** not IBoE, I don't think you mean that the Linux
> kernel IB stack is not functional over pre-2.7 firmware with the IBoE
> patches?! are you?
Of course not. I just
On Mon, Oct 25, 2010 at 4:36 PM, Eli Cohen wrote:
> Of course not. I just noticed that the IB link for IB link layer does
> come up, is that what you're seeing?
No, I didn't have IB Link when I used the for-next bits
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the
On Mon, Oct 25, 2010 at 06:46:39PM +0200, Or Gerlitz wrote:
>
> No, I didn't have IB Link when I used the for-next bits
Can you summarize what is the problem that you're seeing?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.ker
On Mon, Oct 25, 2010 at 7:13 PM, Eli Cohen wrote:
> On Mon, Oct 25, 2010 at 06:46:39PM +0200, Or Gerlitz wrote:
>> No, I didn't have IB Link when I used the for-next bits
> Can you summarize what is the problem that you're seeing?
Eli, this is pretty simple, I do the following
1. pull/build/boot
First, I suggest that you sync your tree again.
Second, I assume your link layer is IB since Ethernet will show either
Down or Active so I think you should be fine after syncing.
If that does not answer you, please don't spare words to explain what
is the problem that you're seeing.
On Mon, Oct 25
On Mon, Oct 25, 2010 at 9:15 PM, Eli Cohen wrote:
> First, I suggest that you sync your tree again.
I'll be able to do that tomorrow
> Second, I assume your link layer is IB since
I wrote black-over-white that its IB, what wasn't clear here?
Or.
--
To unsubscribe from this list: send the line
18 matches
Mail list logo
