Re: [PATCH] mlx4: confiugre cache line size

2009-09-22 Thread Roland Dreier
> I agree with you on both comments. Would you like me to resend or will > you make the necessary changes? please resend, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.ke

Re: [PATCH] mlx4: confiugre cache line size

2009-09-22 Thread Eli Cohen
On Tue, Sep 22, 2009 at 10:51:10AM -0700, Roland Dreier wrote: I agree with you on both comments. Would you like me to resend or will you make the necessary changes? > > > +#if defined(cache_line_size) > > Why the #if here? Do we just need to include explicitly > to make sure we get the defin

Re: [PATCH] mlx4: confiugre cache line size

2009-09-22 Thread Roland Dreier
> +#if defined(cache_line_size) Why the #if here? Do we just need to include explicitly to make sure we get the define? > +*((u8 *) mailbox->buf + INIT_HCA_CACHELINE_SZ_OFFSET) = > +order_base_2(cache_line_size() / 16) << 5; Trivial but I think it's safe to assume a cacheli

[PATCH] mlx4: confiugre cache line size

2009-09-16 Thread Eli Cohen
ConnectX can work more efficiently if the CPU cache line size is confiugred to it at INIT_HCA. This patch configures cache line size for systems that report it. Signed-off-by: Eli Cohen --- drivers/net/mlx4/fw.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drive