Re: [PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code

2009-10-12 Thread Sasha Khapyorsky
On 12:38 Mon 05 Oct , Rolf Manderscheid wrote: > Sasha Khapyorsky wrote: > > Move off subnet destination (router address) resolution code to separate > > function to improve readability. > > ... > > +static ib_net64_t find_router(osm_sa_t *sa, ib_net64_t prefix) > > Much better. The *sa argu

Re: [PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code

2009-10-12 Thread Sasha Khapyorsky
On 09:43 Mon 05 Oct , Hal Rosenstock wrote: > On Sat, Oct 3, 2009 at 8:19 PM, Sasha Khapyorsky wrote: > > > > Move off subnet destination (router address) resolution code to separate > > function to improve readability. > > > > Signed-off-by: Sasha Khapyorsky > > --- > >  opensm/opensm/osm_sa

Re: [PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code

2009-10-05 Thread Rolf Manderscheid
Sasha Khapyorsky wrote: Move off subnet destination (router address) resolution code to separate function to improve readability. ... +static ib_net64_t find_router(osm_sa_t *sa, ib_net64_t prefix) Much better. The *sa argument to find_router() can even be const. Rolf -- To unsubscribe fr

Re: [PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code

2009-10-05 Thread Hal Rosenstock
On Sat, Oct 3, 2009 at 8:19 PM, Sasha Khapyorsky wrote: > > Move off subnet destination (router address) resolution code to separate > function to improve readability. > > Signed-off-by: Sasha Khapyorsky > --- >  opensm/opensm/osm_sa_path_record.c |  122 +++ >  1 f

[PATCH] opensm/osm_sa_path_record.c: separate router guid resolution code

2009-10-03 Thread Sasha Khapyorsky
Move off subnet destination (router address) resolution code to separate function to improve readability. Signed-off-by: Sasha Khapyorsky --- opensm/opensm/osm_sa_path_record.c | 122 +++ 1 files changed, 52 insertions(+), 70 deletions(-) diff --git a/opensm/op