Re: [PATCH] opensm: Add per module logging support

2012-06-05 Thread Hal Rosenstock
On 6/4/2012 8:28 PM, Jim Foraker wrote: > > On Wed, 2012-05-30 at 14:30 -0700, Hal Rosenstock wrote: >> Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box >> Also, add these to libopensm.map >> Add _V2 forms of the various OSM_LOG macros > Why are the _V2 macros necessary? It a

Re: [PATCH] opensm: Add per module logging support

2012-06-04 Thread Jim Foraker
On Wed, 2012-05-30 at 14:30 -0700, Hal Rosenstock wrote: > Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box > Also, add these to libopensm.map > Add _V2 forms of the various OSM_LOG macros Why are the _V2 macros necessary? It appears that the calling semantics/effect are the

Re: [PATCH] opensm: Add per module logging support

2012-05-30 Thread Hal Rosenstock
On 5/30/2012 7:03 PM, Ira Weiny wrote: > On Wed, 30 May 2012 17:30:50 -0400 > Hal Rosenstock wrote: > >> >> Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box >> Also, add these to libopensm.map >> Add _V2 forms of the various OSM_LOG macros >> >> All of above pass additional parame

Re: [PATCH] opensm: Add per module logging support

2012-05-30 Thread Ira Weiny
On Wed, 30 May 2012 17:30:50 -0400 Hal Rosenstock wrote: > > Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box > Also, add these to libopensm.map > Add _V2 forms of the various OSM_LOG macros > > All of above pass additional parameter to identify module. > Each module defines a u

[PATCH] opensm: Add per module logging support

2012-05-30 Thread Hal Rosenstock
Add _v2 APIs for osm_log, osm_log_is_active, and osm_log_msg_box Also, add these to libopensm.map Add _V2 forms of the various OSM_LOG macros All of above pass additional parameter to identify module. Each module defines a unique FILE_ID from 0-254. 255 is reserved to indicate "name not found". F