Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Chuck Lever
On Sep 22, 2014, at 11:55 AM, J. Bruce Fields wrote: > On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote: >> On 9/22/2014 1:39 PM, J. Bruce Fields wrote: >>> On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: Svcrdma currently advertises 1MB, which is too large. The corre

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
On 9/22/2014 1:55 PM, J. Bruce Fields wrote: On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote: On 9/22/2014 1:39 PM, J. Bruce Fields wrote: On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: Svcrdma currently advertises 1MB, which is too large. The correct value is the max

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
On 9/22/2014 1:39 PM, J. Bruce Fields wrote: On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: Svcrdma currently advertises 1MB, which is too large. The correct value is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page size. This bug is usually benign because the

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread J. Bruce Fields
On Mon, Sep 22, 2014 at 01:42:07PM -0500, Steve Wise wrote: > On 9/22/2014 1:39 PM, J. Bruce Fields wrote: > >On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: > >>Svcrdma currently advertises 1MB, which is too large. The correct value > >>is the max scatter-gather allowed in an NFSRDMA

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Chuck Lever
On Sep 22, 2014, at 11:39 AM, J. Bruce Fields wrote: > On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: >> Svcrdma currently advertises 1MB, which is too large. The correct value >> is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page >> size. This bug is usually

Re: [PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread J. Bruce Fields
On Mon, Sep 22, 2014 at 01:36:53PM -0500, Steve Wise wrote: > Svcrdma currently advertises 1MB, which is too large. The correct value > is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page > size. This bug is usually benign because the Linux X64 NFSRDMA client > correctly limit

[PATCH] svcrdma: Advertise the correct max payload

2014-09-22 Thread Steve Wise
Svcrdma currently advertises 1MB, which is too large. The correct value is the max scatter-gather allowed in an NFSRDMA IO chunk * the host page size. This bug is usually benign because the Linux X64 NFSRDMA client correctly limits the payload size to the correct value (64*4096 = 256KB). But if th