Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-22 Thread Sagi Grimberg
On 10/20/2014 8:36 AM, Minh Duc Tran wrote: SNIP From: Minh Tran minhduc.t...@emulex.com This patch allows the underlying hardware to choose values other than hard coded max values for cqe and send_wr while preventing them from exceeding max supported values. Hi

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Or Gerlitz
On 10/21/2014 12:09 AM, Or Gerlitz wrote: So I was wrong, sorry... you were talking on CQEs not CQs. I think Sagi has some proposal on how to harden the code that deals with setting the size of CQs, let me talk to him. So just to recaphere. With your driver maximal attributes of 8K CQEs per

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Or Gerlitz
On 10/21/2014 5:22 PM, Or Gerlitz wrote: Are you hitting an ability to create a CQ? inability -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Sagi Grimberg
On 10/20/2014 8:36 AM, Minh Duc Tran wrote: Hi Sagi, I've created a new patch over the 21 iser patches you have mentioned early in this thread. It is pasted at the end of this email. If I understand correctly, this patch will be applied along with Or's TODO list. ISER_MAX_RX_CQ_LEN

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Minh Duc Tran
Hi Or, So just to recaphere. With your driver maximal attributes of 8K CQEs per CQ and 32 CQs per device, do/what we need to change s.t that the iser initiator functional with it's current code is functional on 3.18-rc1? Yes, I've just verified the patch with 3.18-rc1 on both ocrdma and mlx4

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Or Gerlitz
On 10/22/2014 12:11 AM, Minh Duc Tran wrote: Hi Or, So just to recaphere. With your driver maximal attributes of 8K CQEs per CQ and 32 CQs per device, do/what we need to change s.t that the iser initiator functional with it's current code is functional on 3.18-rc1? Yes, I've just verified

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Minh Duc Tran
On 10/22/2014 12:11 AM, Minh Duc Tran wrote: Hi Or, So just to recaphere. With your driver maximal attributes of 8K CQEs per CQ and 32 CQs per device, do/what we need to change s.t that the iser initiator functional with it's current code is functional on 3.18-rc1? Yes, I've just verified

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-21 Thread Or Gerlitz
On 10/22/2014 7:29 AM, Minh Duc Tran wrote: Not just that one liner change. The change is about 10 lines and very simple. It should take you about 30 seconds to read it. We need the whole patch to fix two problems: 1) the create CQ failure due to requested CQ entries too large. 2) the

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Or Gerlitz
On Mon, Oct 20, 2014 at 8:36 AM, Minh Duc Tran minhduc.t...@emulex.com --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device *device) if (IS_ERR(device-pd))

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Or Gerlitz
On Sun, Oct 19, 2014 at 6:50 PM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 10/16/2014 8:31 AM, Or Gerlitz wrote: On Thu, Oct 16, 2014 at 1:41 AM, Minh Duc Tran minhduc.t...@emulex.com wrote: With the HW and fw profile we are running with the ocrdma currently, it's 8k per CQ. This

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Sagi Grimberg
On 10/20/2014 11:01 AM, Or Gerlitz wrote: On Mon, Oct 20, 2014 at 8:36 AM, Minh Duc Tran minhduc.t...@emulex.com --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device *device)

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Minh Duc Tran
+++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device *device) if (IS_ERR(device-pd)) goto pd_err; + max_cqe = (dev_attr-max_cqe ISER_MAX_CQ_LEN) ? + dev_attr-max_cqe :

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Minh Duc Tran
On 10/20/2014 11:01 AM, Or Gerlitz wrote: On Mon, Oct 20, 2014 at 8:36 AM, Minh Duc Tran minhduc.t...@emulex.com --- a/drivers/infiniband/ulp/iser/iser_verbs.c +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Or Gerlitz
On Mon, Oct 20, 2014 at 9:11 PM, Minh Duc Tran minhduc.t...@emulex.com wrote: +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device *device) if (IS_ERR(device-pd)) goto pd_err; + max_cqe =

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-20 Thread Or Gerlitz
On Tue, Oct 21, 2014 at 12:06 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Mon, Oct 20, 2014 at 9:11 PM, Minh Duc Tran minhduc.t...@emulex.com wrote: +++ b/drivers/infiniband/ulp/iser/iser_verbs.c @@ -114,6 +114,9 @@ static int iser_create_device_ib_res(struct iser_device *device)

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-19 Thread Sagi Grimberg
On 10/15/2014 12:53 AM, Minh Duc Tran wrote: Hi Or Gerlitz, I am new to IB/iser so don't know much about the history of all these max settings being #define instead of taking the real numbers from querying the HW. Yes, our HW driver is the ocrdma which distributes number of cqe per CQ up to

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-19 Thread Sagi Grimberg
On 10/16/2014 8:31 AM, Or Gerlitz wrote: On Thu, Oct 16, 2014 at 1:41 AM, Minh Duc Tran minhduc.t...@emulex.com wrote: With the HW and fw profile we are running with the ocrdma currently, it's 8k per CQ. This number could change if we run on different hw or fw profile. OK. So CQEs per CQ

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-19 Thread Minh Duc Tran
Hi Sagi, I've created a new patch over the 21 iser patches you have mentioned early in this thread. It is pasted at the end of this email. If I understand correctly, this patch will be applied along with Or's TODO list. ISER_MAX_RX_CQ_LEN 4096 /* This number should

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-15 Thread Or Gerlitz
How many CQEs per CQ does the ocrdma driver supports? -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-15 Thread Minh Duc Tran
: Or Gerlitz; Jay Kallickal; micha...@cs.wisc.edu; linux-rdma@vger.kernel.org; Jayamohan Kallickal Subject: Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr How many CQEs per CQ does the ocrdma driver supports? N�r��yb�X��ǧv�^�)޺{.n�+{��ٚ�{ay�ʇڙ�,j��f���h���z��w

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-15 Thread Or Gerlitz
15, 2014 3:32 PM To: Minh Duc Tran Cc: Or Gerlitz; Jay Kallickal; micha...@cs.wisc.edu; linux-rdma@vger.kernel.org; Jayamohan Kallickal Subject: Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr How many CQEs per CQ does the ocrdma driver supports? -- To unsubscribe from

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-14 Thread Or Gerlitz
On 10/8/2014 2:41 AM, Jay Kallickal wrote: This patch allows the underlying hardware to choose values other than hard coded max values for cqe and send_wr while preventing them from exceeding max supported values. These values are not just hard coded. If your HW driver (ocrdma?) can't

RE: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-14 Thread Minh Duc Tran
@vger.kernel.org; Jayamohan Kallickal Subject: Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr On 10/8/2014 2:41 AM, Jay Kallickal wrote: This patch allows the underlying hardware to choose values other than hard coded max values for cqe and send_wr while preventing them from

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-13 Thread Sagi Grimberg
On 10/9/2014 8:14 AM, Jayamohan.K wrote: SNIP Hi Minh and Jayamohan, So I agree that we would want to take device capabilities into account here, but we need to be able to adjust scsi_cmds_max (can_queue) in case the max wqe supported is lower than scsi_cmds_max *

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-13 Thread Jayamohan Kallickal
On Tue, Oct 7, 2014 at 10:58 PM, Sagi Grimberg sa...@dev.mellanox.co.il wrote: On 10/8/2014 3:41 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamoh...@gmail.com This patch allows the underlying hardware to choose values other than hard coded max values for cqe and send_wr while

[PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-07 Thread Jay Kallickal
From: Jayamohan Kallickal jayamoh...@gmail.com This patch allows the underlying hardware to choose values other than hard coded max values for cqe and send_wr while preventing them from exceeding max supported values. Signed-off-by: Minh Tran minhduc.t...@emulex.com Signed-off-by:

Re: [PATCH 1/1] IB/iser: Remove hard coded values for cqe and send_wr

2014-10-07 Thread Sagi Grimberg
On 10/8/2014 3:41 AM, Jay Kallickal wrote: From: Jayamohan Kallickal jayamoh...@gmail.com This patch allows the underlying hardware to choose values other than hard coded max values for cqe and send_wr while preventing them from exceeding max supported values. Hi Minh and Jayamohan,