Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-09-03 Thread Doug Ledford
On 09/03/2015 05:23 PM, Jason Gunthorpe wrote: > On Thu, Sep 03, 2015 at 05:17:31PM -0400, Doug Ledford wrote: >> On 08/27/2015 07:33 PM, Jason Gunthorpe wrote: >>> On Wed, Aug 26, 2015 at 12:43:15PM -0400, Doug Ledford wrote: >>> That still takes us back to the fact that the locking changes a

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-09-03 Thread Jason Gunthorpe
On Thu, Sep 03, 2015 at 05:17:31PM -0400, Doug Ledford wrote: > On 08/27/2015 07:33 PM, Jason Gunthorpe wrote: > > On Wed, Aug 26, 2015 at 12:43:15PM -0400, Doug Ledford wrote: > > > >> That still takes us back to the fact that the locking changes are > >> unneeded. I'm not opposed to them, but a

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-09-03 Thread Doug Ledford
On 08/27/2015 07:33 PM, Jason Gunthorpe wrote: > On Wed, Aug 26, 2015 at 12:43:15PM -0400, Doug Ledford wrote: > >> That still takes us back to the fact that the locking changes are >> unneeded. I'm not opposed to them, but as you mentioned in your first >> email, they should go with the changes

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-09-03 Thread Christoph Lameter
On Fri, 21 Aug 2015, Jason Gunthorpe wrote: > Even though we don't expect the group to be created by the SM we > sill need to provide all the parameters to force the SM to validate > they are correct. Just ran into this issue with Redhat 7.1. Earlier code base. Same problem. qkey etc not set. OFE

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-27 Thread Jason Gunthorpe
On Wed, Aug 26, 2015 at 12:43:15PM -0400, Doug Ledford wrote: > That still takes us back to the fact that the locking changes are > unneeded. I'm not opposed to them, but as you mentioned in your first > email, they should go with the changes that require them, and none of > the changes in the fi

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-26 Thread Doug Ledford
On 08/26/2015 12:18 PM, Jason Gunthorpe wrote: > On Wed, Aug 26, 2015 at 09:37:50AM -0400, Doug Ledford wrote: > >>> Sure looks like these two race: >>> >>> if (test_and_set_bit(IPOIB_MCAST_FLAG_ATTACHED, >>> &mcast->flags)).. >>> clear_bit(IPOIB_MCAST_FLAG_FOUND, &mcast->

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-26 Thread Jason Gunthorpe
On Wed, Aug 26, 2015 at 09:37:50AM -0400, Doug Ledford wrote: > > Sure looks like these two race: > > > > if (test_and_set_bit(IPOIB_MCAST_FLAG_ATTACHED, > > &mcast->flags)).. > > clear_bit(IPOIB_MCAST_FLAG_FOUND, &mcast->flags); > > > > Resulting in corruption of the fl

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-26 Thread Doug Ledford
On 08/25/2015 03:49 PM, Jason Gunthorpe wrote: > On Tue, Aug 25, 2015 at 02:35:27PM -0400, Doug Ledford wrote: >> On 08/25/2015 02:22 PM, Jason Gunthorpe wrote: >>> On Tue, Aug 25, 2015 at 01:50:05PM -0400, Doug Ledford wrote: On 08/21/2015 07:34 PM, Jason Gunthorpe wrote: > Even though we

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Jason Gunthorpe
On Tue, Aug 25, 2015 at 02:35:27PM -0400, Doug Ledford wrote: > On 08/25/2015 02:22 PM, Jason Gunthorpe wrote: > > On Tue, Aug 25, 2015 at 01:50:05PM -0400, Doug Ledford wrote: > >> On 08/21/2015 07:34 PM, Jason Gunthorpe wrote: > >>> Even though we don't expect the group to be created by the SM we

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Doug Ledford
On 08/25/2015 02:22 PM, Jason Gunthorpe wrote: > On Tue, Aug 25, 2015 at 01:50:05PM -0400, Doug Ledford wrote: >> On 08/21/2015 07:34 PM, Jason Gunthorpe wrote: >>> Even though we don't expect the group to be created by the SM we >>> sill need to provide all the parameters to force the SM to valida

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Jason Gunthorpe
On Tue, Aug 25, 2015 at 01:50:05PM -0400, Doug Ledford wrote: > On 08/21/2015 07:34 PM, Jason Gunthorpe wrote: > > Even though we don't expect the group to be created by the SM we > > sill need to provide all the parameters to force the SM to validate > > they are correct. > > Why does this patch

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Doug Ledford
On 08/21/2015 07:34 PM, Jason Gunthorpe wrote: > Even though we don't expect the group to be created by the SM we > sill need to provide all the parameters to force the SM to validate > they are correct. Why does this patch embed locking changes that, as far I can tell, are not needed by the rest

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Jason Gunthorpe
On Tue, Aug 25, 2015 at 08:58:34AM -0400, Hal Rosenstock wrote: > On 8/21/2015 7:34 PM, Jason Gunthorpe wrote: > > Even though we don't expect the group to be created by the SM we > > sill need to provide all the parameters to force the SM to validate > > they are correct. > > Out of curiosity, ha

Re: [PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-25 Thread Hal Rosenstock
On 8/21/2015 7:34 PM, Jason Gunthorpe wrote: > Even though we don't expect the group to be created by the SM we > sill need to provide all the parameters to force the SM to validate > they are correct. Out of curiosity, has it been observed that there was inconsistency in these additional IPoIB pa

[PATCH 1/2] IB/ipoib: Clean up send-only multicast joins

2015-08-21 Thread Jason Gunthorpe
Even though we don't expect the group to be created by the SM we sill need to provide all the parameters to force the SM to validate they are correct. Signed-off-by: Jason Gunthorpe --- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 47 +- 1 file changed, 31 insertions(