Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Tue, Nov 17, 2015 at 09:16:28AM -0800, Bart Van Assche wrote: > How about renaming blk_iopoll into blk_poll ? That way the name still > refers to the block layer. And although the current implementation performs > polling from IRQ context future implementations maybe will allow polling >

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On 11/13/2015 11:02 PM, Christoph Hellwig wrote: On Fri, Nov 13, 2015 at 11:19:24AM -0800, Bart Van Assche wrote: On 11/13/2015 05:46 AM, Christoph Hellwig wrote: The new name is irq_poll as iopoll is already taken. Better suggestions welcome. Would it be possible to provide more background

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On 11/17/2015 09:16 AM, Bart Van Assche wrote: On 11/13/2015 11:02 PM, Christoph Hellwig wrote: On Fri, Nov 13, 2015 at 11:19:24AM -0800, Bart Van Assche wrote: On 11/13/2015 05:46 AM, Christoph Hellwig wrote: The new name is irq_poll as iopoll is already taken. Better suggestions welcome.

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg wrote: > Or is correct, > > I have attempted to convert iser to use blk_iopoll in the past, however > I've seen inconsistent performance and latency skews (comparing to > tasklets iser is using today). This was manifested

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: The new name is irq_poll as iopoll is already taken. Better suggestions welcome. Sagi (or Christoph if you can address that), @ some pointer over the last 18 months there was a port done at mellanox for iser to use

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Sun, Nov 15, 2015 at 10:48:41AM +0200, Sagi Grimberg wrote: > I have attempted to convert iser to use blk_iopoll in the past, however > I've seen inconsistent performance and latency skews (comparing to > tasklets iser is using today). This was manifested in IOPs test cases > where I ran

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On 15/11/2015 11:04, Or Gerlitz wrote: On Sun, Nov 15, 2015 at 10:48 AM, Sagi Grimberg wrote: Or is correct, I have attempted to convert iser to use blk_iopoll in the past, however I've seen inconsistent performance and latency skews (comparing to tasklets iser is

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: > The new name is irq_poll as iopoll is already taken. Better suggestions > welcome. Sagi (or Christoph if you can address that), @ some pointer over the last 18 months there was a port done at mellanox for iser to use

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On 11/13/2015 05:46 AM, Christoph Hellwig wrote: The new name is irq_poll as iopoll is already taken. Better suggestions welcome. Hello Christoph, Would it be possible to provide more background information about this ? Which other kernel subsystem is using the name iopoll ? I think the

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 05:23:39PM +0200, Or Gerlitz wrote: > On Fri, Nov 13, 2015 at 3:46 PM, Christoph Hellwig wrote: > > The new name is irq_poll as iopoll is already taken. Better suggestions > > welcome. > > Sagi (or Christoph if you can address that), > > @ some pointer over

Re: [PATCH 1/9] move blk_iopoll to limit and make it generally available

On Fri, Nov 13, 2015 at 11:19:24AM -0800, Bart Van Assche wrote: > On 11/13/2015 05:46 AM, Christoph Hellwig wrote: >> The new name is irq_poll as iopoll is already taken. Better suggestions >> welcome. > > Hello Christoph, > > Would it be possible to provide more background information about

[PATCH 1/9] move blk_iopoll to limit and make it generally available

The new name is irq_poll as iopoll is already taken. Better suggestions welcome. Signed-off-by: Christoph Hellwig --- Documentation/kernel-per-CPU-kthreads.txt | 2 +- block/Makefile| 2 +- block/blk-iopoll.c| 224