Re: [PATCH 10/27] drivers/infiniband/core: Use memdup_user

2010-05-25 Thread Roland Dreier
thanks, applied. -- Roland Dreier || For corporate legal information go to: http://www.cisco.com/web/about/doing_business/legal/cri/index.html -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at htt

Re: [PATCH 10/27] drivers/infiniband/core: Use memdup_user

2010-05-22 Thread Roland Dreier
> > + data = memdup_user((void __user *)(unsigned long)src, len); > > + if (IS_ERR(data)) > > + return PTR_ERR(data); > This cast look strange, can it happen that (unsigned long)<(u64) ? > (is there a 32bit infiniband) ? There is 32-bit infiniband. Linux kernel assumes that unsig

Re: [PATCH 10/27] drivers/infiniband/core: Use memdup_user

2010-05-22 Thread walter harms
Julia Lawall schrieb: > From: Julia Lawall > > Use memdup_user when user data is immediately copied into the > allocated region. > > The semantic patch that makes this change is as follows: > (http://coccinelle.lip6.fr/) > > // > @@ > expression from,to,size,flag; > position p; > identifier

[PATCH 10/27] drivers/infiniband/core: Use memdup_user

2010-05-22 Thread Julia Lawall
From: Julia Lawall Use memdup_user when user data is immediately copied into the allocated region. The semantic patch that makes this change is as follows: (http://coccinelle.lip6.fr/) // @@ expression from,to,size,flag; position p; identifier l1,l2; @@ - to = \(kmal...@p\|kzal...@p\)(size,f