Re: [PATCH 2/2] IB/iser: Enable SG clustering

2015-10-11 Thread Sagi Grimberg
but with arbitrary SG list support it will benefit greatly. Y? please put some wording here to clarify. Well, because when a device will accept true SG lists then it would benefit the HCA caching/fetching to have less SG elements. I'll add a sentence to the change log. -- To unsubscribe from

Re: [PATCH 2/2] IB/iser: Enable SG clustering

2015-10-10 Thread Or Gerlitz
On Sat, Oct 10, 2015 at 3:27 AM, Sagi Grimberg wrote: > iser can handle it and it can dramatically reduce the > number of SG elements. It doesn't make much of a difference at > the moment, Right, b/c we would go and break these SGs to 4k chunks. > but with arbitrary SG list

Re: [PATCH 2/2] IB/iser: Enable SG clustering

2015-10-10 Thread Christoph Hellwig
Looks good, Reviewed-by: Christoph Hellwig -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] IB/iser: Enable SG clustering

2015-10-09 Thread Sagi Grimberg
iser can handle it and it can dramatically reduce the number of SG elements. It doesn't make much of a difference at the moment, but with arbitrary SG list support it will benefit greatly. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +- 1