Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-25 Thread Jason Gunthorpe
On Mon, Oct 25, 2010 at 09:19:47PM -0700, Roland Dreier wrote: > OK, I got those 3 patches. Thanks While you are looking at patches, did you have any comment on: https://patchwork.kernel.org/patch/151491/ https://patchwork.kernel.org/patch/151501/ ? Jason -- To unsubscribe from this list: send

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-25 Thread Roland Dreier
OK, I got those 3 patches. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-25 Thread Jason Gunthorpe
On Mon, Oct 25, 2010 at 01:35:33PM -0700, Ralph Campbell wrote: > On Sat, 2010-10-23 at 13:54 -0700, Roland Dreier wrote: > > I'm lost on which initialization / cleanup fixes are the right ones to > > take for qib. Can someone point me to the definitive set of patches? > > If Jason agrees, they a

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-25 Thread Ralph Campbell
On Sat, 2010-10-23 at 13:54 -0700, Roland Dreier wrote: > I'm lost on which initialization / cleanup fixes are the right ones to > take for qib. Can someone point me to the definitive set of patches? > > - R. If Jason agrees, they are the attached. There are probably more error paths that need

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-23 Thread Roland Dreier
I'm lost on which initialization / cleanup fixes are the right ones to take for qib. Can someone point me to the definitive set of patches? - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-22 Thread Jason Gunthorpe
On Fri, Oct 22, 2010 at 03:29:54PM -0700, Ralph Campbell wrote: > Some PCIe root complex chip sets don't support advanced error reporting. > Allow the driver to load OK if pci_enable_pcie_error_reporting() fails. Thanks If you use this solution you'll want this hunk as well to avoid a leak: diff

[PATCH 2/2] IB/qib: Allow driver to load if PCIe advanced error reporting fails

2010-10-22 Thread Ralph Campbell
Some PCIe root complex chip sets don't support advanced error reporting. Allow the driver to load OK if pci_enable_pcie_error_reporting() fails. Signed-off-by: Ralph Campbell --- drivers/infiniband/hw/qib/qib_pcie.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/dri