On Mon, 14 Dec 2015, Weiny, Ira wrote:
> > How about
> >=20
> > ipoib_check_and_add_mcast_sendonly()
>
> Better.
Fixup patch:
Subject: ipoib: Fix up naming of ipoib_check_and_add_mcast_sendonly
Signed-off-by: Christoph Lameter
Index: linux/drivers/infiniband/ulp/ipoib/ipoib.h
===
On Fri, 11 Dec 2015, ira.weiny wrote:
> I think I would rather see this called something like
>
> ipoib_add_to_list_sendonly
>
> Or something...
>
> Calling it iboib_check* sounds like it should return a bool.
Hmm... It only adds the multicast group if the check was successful.
How about
>
> On Fri, 11 Dec 2015, ira.weiny wrote:
>
> > I think I would rather see this called something like
> >
> > ipoib_add_to_list_sendonly
> >
> > Or something...
> >
> > Calling it iboib_check* sounds like it should return a bool.
>
> Hmm... It only adds the multicast group if the check was succe
On Fri, Dec 11, 2015 at 06:21:43PM -0500, ira. weiny wrote:
> On Fri, Dec 11, 2015 at 12:16:54PM -0600, Christoph Lameter wrote:
> > Code cleanup to move multicast specific code that checks for
> > a sendonly join to ipoib_multicast.c. This allows the removal
> > of the export of __ipoib_mcast_find
On Fri, Dec 11, 2015 at 12:16:54PM -0600, Christoph Lameter wrote:
> Code cleanup to move multicast specific code that checks for
> a sendonly join to ipoib_multicast.c. This allows the removal
> of the export of __ipoib_mcast_find().
>
> Signed-off-by: Christoph Lameter
> ---
> drivers/infiniba
Code cleanup to move multicast specific code that checks for
a sendonly join to ipoib_multicast.c. This allows the removal
of the export of __ipoib_mcast_find().
Signed-off-by: Christoph Lameter
---
drivers/infiniband/ulp/ipoib/ipoib.h | 3 ++-
drivers/infiniband/ulp/ipoib/ipoib_main.
