Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-11 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 04:43:54PM -0400, Chuck Lever wrote: > I think the sanity check you pointed out is strictly satisfied by > testing against the unaligned number of bytes. Is there a strong > reason to do the extra math for that check during each WRITE? I can't think of any good reason why t

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
[ Correcting Steve’s e-mail address ] On Jul 10, 2014, at 3:43 PM, J. Bruce Fields wrote: > On Thu, Jul 10, 2014 at 03:07:34PM -0400, Chuck Lever wrote: >> Hi Bruce- >> >> On Jul 10, 2014, at 2:49 PM, J. Bruce Fields wrote: >> >>> On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: >

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 03:07:34PM -0400, Chuck Lever wrote: > Hi Bruce- > > On Jul 10, 2014, at 2:49 PM, J. Bruce Fields wrote: > > > On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: > >> > >> On Jul 10, 2014, at 2:19 PM, J. Bruce Fields wrote: > >> > >>> On Thu, Jul 10, 2014 at

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
Hi Bruce- On Jul 10, 2014, at 2:49 PM, J. Bruce Fields wrote: > On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: >> >> On Jul 10, 2014, at 2:19 PM, J. Bruce Fields wrote: >> >>> On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: The server should comply with RFC 566

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 02:24:57PM -0400, Chuck Lever wrote: > > On Jul 10, 2014, at 2:19 PM, J. Bruce Fields wrote: > > > On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: > >> The server should comply with RFC 5667, > > > > Where's the relevant language? (I took a quick look but d

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
On Jul 10, 2014, at 2:19 PM, J. Bruce Fields wrote: > On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: >> The server should comply with RFC 5667, > > Where's the relevant language? (I took a quick look but didn't see it.) Sorry, I listed the wrong RFC when I wrote the description

Re: [PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread J. Bruce Fields
On Thu, Jul 10, 2014 at 01:44:35PM -0400, Chuck Lever wrote: > The server should comply with RFC 5667, Where's the relevant language? (I took a quick look but didn't see it.) > and handle WRITE payloads > that may not have a zero pad on the end (XDR length round-up). > > Fixes: f34b9568 (The NF

[PATCH 2/2] svcrdma: Remove extra writeargs sanity check for NFSv2/3

2014-07-10 Thread Chuck Lever
The server should comply with RFC 5667, and handle WRITE payloads that may not have a zero pad on the end (XDR length round-up). Fixes: f34b9568 (The NFSv2/NFSv3 server does not handle zero...) BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=246 Signed-off-by: Chuck Lever --- fs/nfsd/nf