Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-18 Thread Hal Rosenstock
On 12/18/2015 10:46 AM, Christoph Lameter wrote: > Subject: IB core counters: Support noietf extended counters V2 > > V1-V2: Fix logic to detect when 64 bit counter are available > based on Hal's suggestions. > > Detect if we have extended counters but not IETF counters. > For that we need

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-18 Thread Christoph Lameter
On Fri, 18 Dec 2015, Hal Rosenstock wrote: > > This case would then use the 64 bit counters despite of the > > IB_PMA_CLASS_CAP_EXT_WIDTH not being set. > > Yes, IB_PMA_CLASS_CAP_EXT_WIDTH means all extended counters including > IETF ones whereas IB_PMA_CLASS_CAP_EXT_WIDTH_NOIETF means extended >

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-18 Thread Hal Rosenstock
On 12/18/2015 8:39 AM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: > >>> + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH) { >>> + /* We have extended counters */ >>> + >>> + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH_NOIETF) >>> +

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-18 Thread Christoph Lameter
On Thu, 17 Dec 2015, Hal Rosenstock wrote: > > + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH) { > > + /* We have extended counters */ > > + > > + if (cpi.capability_mask && IB_PMA_CLASS_CAP_EXT_WIDTH_NOIETF) > > + /* But not the IETF ones */ > > +

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Hal Rosenstock
On 12/17/2015 5:50 PM, Christoph Lameter wrote: > On Thu, 17 Dec 2015, Hal Rosenstock wrote: > >> On 12/17/2015 4:28 PM, Christoph Lameter wrote: >>> So port_check_extended_counters need to return another value for this. >>> The IETF ones are the uni/mcast xxx counters? >> >> Yes > > Ok. Then thi

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Christoph Lameter
On Thu, 17 Dec 2015, Hal Rosenstock wrote: > On 12/17/2015 4:28 PM, Christoph Lameter wrote: > > So port_check_extended_counters need to return another value for this. > > The IETF ones are the uni/mcast xxx counters? > > Yes Ok. Then this patch on top of the last one should give us all of what y

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Hal Rosenstock
On 12/17/2015 4:28 PM, Christoph Lameter wrote: > So port_check_extended_counters need to return another value for this. > The IETF ones are the uni/mcast xxx counters? Yes -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.or

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Christoph Lameter
On Thu, 17 Dec 2015, Hal Rosenstock wrote: > > - ret = sysfs_create_group(&p->kobj, &pma_group); > > + ret = sysfs_create_group(&p->kobj, > > + port_check_extended_counters(device) ? > > + &pma_group_ext : > > Would be nice to populate 2 different groups based on wh

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Leon Romanovsky
There are number of minor issues: Subject: Re: [PATCH 3/3] bject: IB Core: Display extended counter set if ^^^ On Thu, Dec 17, 2015 at 01:52:58PM -0600, Christoph Lameter wrote: > - in_mad->data[41] = port_num;/* PortSelect field */ > + if (port_num) > +

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Hal Rosenstock
On 12/17/2015 2:52 PM, Christoph Lameter wrote: > Check if the extended counters are available and if so > create the proper extended and additional counters. > > Signed-off-by: Christoph Lameter > > Index: linux/drivers/infiniband/core/sysfs.c > =

[PATCH 3/3] bject: IB Core: Display extended counter set if available

2015-12-17 Thread Christoph Lameter
Check if the extended counters are available and if so create the proper extended and additional counters. Signed-off-by: Christoph Lameter Index: linux/drivers/infiniband/core/sysfs.c === --- linux.orig/drivers/infiniband/core/sysf