Re: [PATCH 3/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Roland Dreier
+/* mailbox cmd response */ +struct ocrdma_mbx_rsp { +       u32 subsys_op; +       u32 status; +       u32 rsp_len; +       u32 add_rsp_len; +} __packed; ...similar comments about only using __packed where you really need it... +#define is_cqe_valid(cq, cqe) \ +      

RE: [PATCH 3/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread David Laight
+#define is_cqe_wr_imm(cqe) \ +       ((le32_to_cpu(cqe-flags_status_srcqpn) OCRDMA_CQE_WRITE_IMM) ? 1 : 0) ...similar comment about using readable typesafe inline functions instead of macros... and if you are using #defines, you need to enclose every reference to the parameters in

Re: [PATCH 3/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Roland Dreier
On Wed, Mar 21, 2012 at 12:04 PM, parav.pan...@emulex.com wrote: +/* mailbox cmd response */ +struct ocrdma_mbx_rsp { +       u32 subsys_op; +       u32 status; +       u32 rsp_len; +       u32 add_rsp_len; +} __packed; ...similar comments about only using __packed where you

Re: [PATCH 3/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-21 Thread Jason Gunthorpe
On Wed, Mar 21, 2012 at 12:33:00PM -0700, Roland Dreier wrote: On Wed, Mar 21, 2012 at 12:04 PM, parav.pan...@emulex.com wrote: +/* mailbox cmd response */ +struct ocrdma_mbx_rsp { + ? ? ? u32 subsys_op; + ? ? ? u32 status; + ? ? ? u32 rsp_len; + ? ? ? u32 add_rsp_len; +}

[PATCH 3/9] ocrdma: Driver for Emulex OneConnect RDMA adapter

2012-03-20 Thread parav.pandit
From: Parav Pandit parav.pan...@emulex.com - Header file for driver-adapter interface. Signed-off-by: Parav Pandit parav.pan...@emulex.com --- drivers/infiniband/hw/ocrdma/ocrdma_sli.h | 1672 + 1 files changed, 1672 insertions(+), 0 deletions(-) create mode 100644