Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-10-04 Thread Bjorn Helgaas
[-cc extra folks] On Tue, Sep 24, 2013 at 2:39 PM, Bjorn Helgaas wrote: > On Mon, Sep 09, 2013 at 09:13:06PM +0800, Yijing Wang wrote: >> Refactor qib_tune_pcie_caps() function, use pcie_set_mps() >> and pcie_get_mps() to simply code. Because pci core caches >> the "PCI-E Max Payload Size Support

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-10-04 Thread Bjorn Helgaas
On Mon, Sep 30, 2013 at 8:56 AM, Marciniszyn, Mike wrote: >> >> Is something like the following what you had in mind? If so, I can >> just queue it up. Otherwise, I'll wait for Yijing to post a v2 patch. >> >> >> IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code >> >> From: Yijing W

RE: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-30 Thread Marciniszyn, Mike
> > Is something like the following what you had in mind? If so, I can > just queue it up. Otherwise, I'll wait for Yijing to post a v2 patch. > > > IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code > > From: Yijing Wang > > Refactor qib_tune_pcie_caps(). Use pcie_get_mps(), p

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-24 Thread Bjorn Helgaas
On Mon, Sep 09, 2013 at 09:13:06PM +0800, Yijing Wang wrote: > Refactor qib_tune_pcie_caps() function, use pcie_set_mps() > and pcie_get_mps() to simply code. Because pci core caches > the "PCI-E Max Payload Size Supported" in pci_dev->pcie_mpss, > so use that instead of pcie_capability_read_word()

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-24 Thread Bjorn Helgaas
On Mon, Sep 09, 2013 at 02:55:46PM +, Marciniszyn, Mike wrote: > > Subject: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to > > simplify > > code > > > > Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and > > pcie_get_mps() to simp

Re: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-09 Thread Yijing Wang
On 2013/9/9 22:55, Marciniszyn, Mike wrote: >> Subject: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to >> simplify >> code >> >> Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and >> pcie_get_mps() to simply code. Because pci core c

RE: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-09 Thread Marciniszyn, Mike
> Subject: [PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify > code > > Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and > pcie_get_mps() to simply code. Because pci core caches the "PCI-E Max > Payload Size Supported" in pci_dev->

[PATCH 4/6] IB/qib: Use pcie_set_mps() and pcie_get_mps() to simplify code

2013-09-09 Thread Yijing Wang
Refactor qib_tune_pcie_caps() function, use pcie_set_mps() and pcie_get_mps() to simply code. Because pci core caches the "PCI-E Max Payload Size Supported" in pci_dev->pcie_mpss, so use that instead of pcie_capability_read_word(). Remove the unused val2fld() and fld2val(). Signed-off-by: Yijing W