Re: [PATCH 5/7] libmlx4: add IBoE support

2011-07-19 Thread Or Gerlitz
Jason Gunthorpe wrote: > Or Gerlitz wrote: >> Jason, as the change log explains, under Ethernet link type the code >> (see mlx4_resolve_grh_to_l2) goes and extracts the Ethernet L2 info >> (mac and vlan, look on the last patch) from the GID. > > Looking at the control flow of the actual code, the

Re: [PATCH 5/7] libmlx4: add IBoE support

2011-07-19 Thread Or Gerlitz
Jason Gunthorpe wrote: >> Modify libmlx4 to support IBoE, where the only user space piece >> to handle is the creation of UD address handles - the L2 Ethernet >> attributes have to be resolved from the DGID. > Other than rejecting some GIDs it doesn't seem like there is any > operational need to

Re: [PATCH 5/7] libmlx4: add IBoE support

2011-07-19 Thread Jason Gunthorpe
On Tue, Jul 19, 2011 at 12:32:52PM +0300, Or Gerlitz wrote: > Modify libmlx4 to support IBoE, where the only user space piece > to handle is the creation of UD address handles - the L2 Ethernet > attributes have to be resolved from the DGID. It seems a shame to add a kernel syscall to every ah cre

[PATCH 5/7] libmlx4: add IBoE support

2011-07-19 Thread Or Gerlitz
Modify libmlx4 to support IBoE, where the only user space piece to handle is the creation of UD address handles - the L2 Ethernet attributes have to be resolved from the DGID. Derived from work by Eli Cohen Signed-off-by: Or Gerlitz --- src/mlx4.h |1 + src/qp.c|1 + src/verbs.c |