Re: [PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-19 Thread Or Gerlitz
On 2/18/2015 8:07 AM, Roland Dreier wrote: On Tue, Feb 17, 2015 at 9:03 PM, Or Gerlitz wrote: Roland, can you please pick this one too, it's a bug fix and no comments were raised against it. I just failed to remove the Gerrit Issue: XXX line, so if you can do that, will be great OK. I not

Re: [PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-17 Thread Roland Dreier
On Tue, Feb 17, 2015 at 9:03 PM, Or Gerlitz wrote: > Roland, can you please pick this one too, it's a bug fix and no comments > were raised against it. > I just failed to remove the Gerrit Issue: XXX line, so if you can do that, > will be great OK. -- To unsubscribe from this list: send the lin

Re: [PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-17 Thread Or Gerlitz
On 2/5/2015 6:53 AM, Or Gerlitz wrote: From: Moshe Lazer The deadlock occurs on __uverbs_modify_qp, we take a lock (idr_read_qp) and in case of failure in ib_resolve_eth_l2_attrs we don't release it (put_qp_read). Fix that. Issue: 355606 Fixes: ed4c54e5b4ba ("IB/core: Resolve Ethernet L2 addre

Re: [PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-16 Thread Yann Droneaud
Le jeudi 05 février 2015 à 13:53 +0200, Or Gerlitz a écrit : > From: Moshe Lazer > > The deadlock occurs on __uverbs_modify_qp, we take a lock (idr_read_qp) > and in case of failure in ib_resolve_eth_l2_attrs we don't release > it (put_qp_read). Fix that. > > Issue: 355606 ^^ I'm no

[PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-05 Thread Or Gerlitz
From: Moshe Lazer The deadlock occurs on __uverbs_modify_qp, we take a lock (idr_read_qp) and in case of failure in ib_resolve_eth_l2_attrs we don't release it (put_qp_read). Fix that. Issue: 355606 Fixes: ed4c54e5b4ba ("IB/core: Resolve Ethernet L2 addresses when modifying QP") Signed-off-by: M