Re: [PATCH RESEND 10/11] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

> > - if (WARN_ON(vl > 8)) > > - return NULL; > > + /* NOTE This should only happen if SC->VL changed after the initial > > +* checks on the QP/AH > > +* Default will return engine 0 below > > +*/ > > + if (unlikely(vl >= num_vls)) { > > Can you prove that

[PATCH RESEND 10/11] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

From: Ira Weiny sdma_select_engine_vl only needs to protect itself from an invalid VL. Something higher up the stack should be warning the user when they try to use an SL which maps to an invalid VL. Reviewed-by: Dean Luick Reviewed-by: Mike Marciniszyn

Re: [PATCH RESEND 10/11] staging/rdma/hfi1: Eliminate WARN_ON when VL is invalid

On Fri, Nov 06, 2015 at 08:07:05PM -0500, Jubin John wrote: > From: Ira Weiny > > sdma_select_engine_vl only needs to protect itself from an invalid VL. > Something higher up the stack should be warning the user when they try > to use an SL which maps to an invalid VL. > >