[PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Marcel Apfelbaum
This patch implements IB spec extension of the PortInfo attribute: Component  : LinkSpeedExtActive Used By    : (All X's except base SP0) Access     : RO Length     : 4 Offset     : 496 Description: If PortInfo:CapabilityMask.IsExtendedSpeedsSupported, currently             active extended link sp

[PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Marcel Apfelbaum
This patch implements IB spec extension of the PortInfo attribute: Component : LinkSpeedExtActive Used By: (All X's except base SP0) Access : RO Length : 4 Offset : 496 Description: If PortInfo:CapabilityMask.IsExtendedSpeedsSupported, currently active extended link s

RE: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Hefty, Sean
> Index: b/drivers/infiniband/core/verbs.c > === > --- a/drivers/infiniband/core/verbs.c 2011-09-13 13:34:19.660539000 +0300 > +++ b/drivers/infiniband/core/verbs.c 2011-09-13 16:42:39.713754400 +0300 > @@ -77,6 +77,23 @@ enum ib_rate

Re: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Hal Rosenstock
On Mon, Sep 19, 2011 at 2:00 PM, Hefty, Sean wrote: >> Index: b/drivers/infiniband/core/verbs.c >> === >> --- a/drivers/infiniband/core/verbs.c 2011-09-13 13:34:19.660539000 +0300 >> +++ b/drivers/infiniband/core/verbs.c 2011-09-13 16

RE: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Hefty, Sean
> It maps to what was done in the PortInfo attribute to add the new > extended speeds. There was no room for expansion in the existing > original link speed fields so a "parallel" set of fields had to be > added there.. That's was an issue with the wire protocol format, correct? Why carry that s

Re: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Hal Rosenstock
On Mon, Sep 19, 2011 at 2:17 PM, Hefty, Sean wrote: >> It maps to what was done in the PortInfo attribute to add the new >> extended speeds. There was no room for expansion in the existing >> original link speed fields so a "parallel" set of fields had to be >> added there.. > > That's was an issu

Re: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Or Gerlitz
Hal Rosenstock wrote: > Hefty, Sean wrote: >> That's was an issue with the wire protocol format, correct? > Right. >> Why carry that same concept into a software interface?  It seems complex. > So as not to break existing verbs apps by inventing new values to > existing fields which wouldn't

Re: [PATCH RFC 1/4] ib/core: handle EDR/FDR extended speeds

2011-09-19 Thread Jason Gunthorpe
On Mon, Sep 19, 2011 at 02:26:13PM -0400, Hal Rosenstock wrote: > Right. > > > Why carry that same concept into a software interface? ??It seems complex. > > So as not to break existing verbs apps by inventing new values to > existing fields which wouldn't be understood. Every app I've ever wo